[plasma-pa] [Bug 408490] "Default" label is missing in "Devices" tab when fractional display scaling is used

2019-09-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408490

Nate Graham  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-pa/4a13cbf391b4faf30169
   ||fc096f0e7275248806b2
   Version Fixed In||5.17.0
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Nate Graham  ---
Git commit 4a13cbf391b4faf30169fc096f0e7275248806b2 by Nate Graham.
Committed on 16/09/2019 at 17:13.
Pushed by ngraham into branch 'master'.

Use visible buttons to switch the default device

Summary:
We get numerous complaints that it's hard to figure out how to make an audio
device the
default for playback or output. Despite the multiple methods (drag-and-drop,
hamburger
menu item, radio button in the KCM), it still seems un-discoverable for many
users.

This patch attempts to address the issue by standardizing on a single
consistent method:
{nav Make default} buttons right there on the list items for the devices, for
both the applet
and the KCM.The buttons are only shown when there is more than one device that
could
be the default.

Various other elements of the UI are slightly adjusted or adapted to
accommodate this change.
Related: bug 411065
FIXED-IN: 5.17.0

Test Plan:
Connected my Bluetooth speaker and toggled between it and the internal speakers
using
the new button.

Applet: {F7341848}
KCM: {F7341852}

My wife was impressed by how easy it was and how the audio instantly switched.

Reviewers: drosca, #plasma, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: broulik, GB_2, alexde, ndavis, anthonyfieroni, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23389

M  +25   -24   applet/contents/ui/ListItemBase.qml
D  +0-30   src/kcm/package/contents/ui/DefaultDeviceButton.qml
M  +6-10   src/kcm/package/contents/ui/DeviceListItem.qml
M  +1-1src/kcm/package/contents/ui/MuteButton.qml

https://commits.kde.org/plasma-pa/4a13cbf391b4faf30169fc096f0e7275248806b2

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-pa] [Bug 408490] "Default" label is missing in "Devices" tab when fractional display scaling is used

2019-09-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408490

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||n...@kde.org

--- Comment #2 from Nate Graham  ---
Will be fixed by https://phabricator.kde.org/D23389

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-pa] [Bug 408490] "Default" label is missing in "Devices" tab when fractional display scaling is used

2019-06-09 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=408490

--- Comment #1 from Patrick Silva  ---
Created attachment 120732
  --> https://bugs.kde.org/attachment.cgi?id=120732&action=edit
"Device" tab accessed via plasma-pa applet

-- 
You are receiving this mail because:
You are watching all bug changes.