[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[Benedikt Gollatz via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #14 from Benedikt Gollatz  ---
This patch is still a regression on machines where transparency worked fine in
the first place. It is visible e.g. in the hexchat icon, where
createHeuristicMap will leave the black spots in the middle of the icon
unchanged and not detect the semitransparency at the edges of the icon (leaving
a black seam).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[Rakyn Barker via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #15 from Rakyn Barker  ---
Can you name a few applications which worked fine before please?
I would like to check.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #17 from David Edmundson  ---
My usual test suite is

xchat, tuxguitar, spotify

as that's:
gtk, java, qt

then I get someone else to test Steam via Wine as that normally behaves
weirdly.

I've just run the 3 above. First two are fine, spotify isn't showing up at all
for me, but that's not related to your changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[Oleg via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

Oleg  changed:

   What|Removed |Added

 CC|mehanoid...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[Rakyn Barker via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #22 from Rakyn Barker  ---
Sorry no typo, i think it is just my poor english.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/plas
   ||ma-workspace/41df1bdb8b478e
   ||b27fb424d201c075c76ec0ed5a
 Status|CONFIRMED   |RESOLVED

--- Comment #24 from David Edmundson  ---
Git commit 41df1bdb8b478eb27fb424d201c075c76ec0ed5a by David Edmundson, on
behalf of Benedikt Gollatz.
Committed on 13/12/2015 at 20:49.
Pushed by davidedmundson into branch 'Plasma/5.5'.

Mitigate failed icon grabbing in xembed-sni-proxy

If grabbed icons are blank, try to salvage the copied data as well as
possible while leaving setups where image grabbing works fine alone.

Based on a patch by Rakyn Barker.
REVIEW: 126336

M  +110  -33   xembed-sni-proxy/sniproxy.cpp
M  +4-1xembed-sni-proxy/sniproxy.h

http://commits.kde.org/plasma-workspace/41df1bdb8b478eb27fb424d201c075c76ec0ed5a

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[Rakyn Barker via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #12 from Rakyn Barker  ---
Created attachment 96044
  --> https://bugs.kde.org/attachment.cgi?id=96044=edit
Patch for xembed-sni-proxy-0~git20151104-ded1538

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[Rakyn Barker via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #13 from Rakyn Barker  ---
(In reply to David Edmundson from comment #9)
> Rakyn, what's your surname. I need it for the commit author.
Rakyn Barker

Added sort of artificial alpha mask to the icons,
posting the patch at this place one last time.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #20 from David Edmundson  ---
Seems OK to me.

Code review: 
   - I don't like how update() has a call to isTransparentImage even when we
potentially we've already done that.

   can we make getImageNonComposite  have a second isTransparentImage  after
convertFromNative, and if applicable return  a null QImage. Then remove the
check from update(). It groups the logic together

  - don't leave commented out code
+//QImage image(xcbImage->data, xcbImage->width, xcbImage->height, format);

 - why did you remove the braces in isTransparentImage  ? 
https://techbase.kde.org/Policies/Kdelibs_Coding_Style

  - make methods const

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[Rakyn Barker via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #21 from Rakyn Barker  ---
Works fine here too.
There is a typo in na(t)ive.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #16 from David Edmundson  ---
I don't see how it's a regression? your new section only applies to images
where depth == 24, so they wouldn't have had any transparency anyway?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[Benedikt Gollatz via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #19 from Benedikt Gollatz  ---
Created attachment 96045
  --> https://bugs.kde.org/attachment.cgi?id=96045=edit
Try naive conversion, only then use alternative copying method

This patch doesn't regress on my machine where the current version works
already, though I suppose it should be checked whether it reintroduces the WINE
bug mentioned in the source code. The Battle.net launcher icon works fine on my
machine though.

One could probably also use createMaskFromColor(qRgba(0, 0, 0, 0)) instead of
createHeuristicMask() in Rakyn's copying routine, which gives somewhat better
results with the hexchat icon, but might of course be worse for other icons
that use the black colour intentionally.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

fadem...@gmail.com changed:

   What|Removed |Added

 CC||fadem...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #11 from ko...@indywidualni.org ---
Sorry for a duplicate I submitted. The same problem here. Arch Linux, Nvidia
driver. I will be glad to provide all the info needed to resolve it completely.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #8 from David Edmundson  ---
Patch looks good. 

In theory I specific what format embedded clients should be using, but they
also seem to just ignore it.

In future, if you can put patches on git.reviewboard.kde.org it's a bit easier
for me to comment especially if we have some back and forth.  (like to say that
method should be const)

and otherwise they get lost.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

David Edmundson  changed:

   What|Removed |Added

 CC||ad1r...@hotmail.fr

--- Comment #6 from David Edmundson  ---
*** Bug 355418 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

David Edmundson  changed:

   What|Removed |Added

 CC||lukas.schneiderbauer@gmail.
   ||com

--- Comment #7 from David Edmundson  ---
*** Bug 356430 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #9 from David Edmundson  ---
Rakyn, what's your surname. I need it for the commit author.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

jeremy9...@gmail.com changed:

   What|Removed |Added

 CC||jeremy9...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[Oleg via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

Oleg  changed:

   What|Removed |Added

 CC||mehanoid...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

d...@kaosx.us changed:

   What|Removed |Added

 CC||d...@kaosx.us

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[Viorel-Cătălin Răpițeanu via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

Viorel-Cătălin Răpițeanu  changed:

   What|Removed |Added

 CC||rapiteanu.cata...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

darkba...@linuxsystems.it changed:

   What|Removed |Added

 CC||darkba...@linuxsystems.it

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355684] xembedsniproxy system tray icons are blank

[Benedikt Gollatz via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355684

--- Comment #5 from Benedikt Gollatz  ---
Using Rakyn's patch, I get visible icons with a black background on both of my
systems, i.e. including the one where icon display worked well previously. This
is because for the icons grabbed those two systems, xcbImage->depth is 24,
whereas xcbImage->bpp is 32. This is in line with the comments in the
xcb-util-image source code:

  uint8_tdepth;   /**< Depth in bits. Valid depths
   *   are 1, 4, 8, 16, 24 for z format,
   *   1 for xy-bitmap-format, anything
   *   for xy-pixmap-format.
   */
  uint8_tbpp;   /**< Storage per pixel in bits.
 *   Must be >= depth. Valid bpp
 *   are 1, 4, 8, 16, 24, 32 for z
 *   format, 1 for xy-bitmap format,
 *   anything for xy-pixmap-format.
 */

Effectively, what Rakyn's code does in this case, is simply use
QImage::Format_RGB32 always and ignore the alpha channel completely (basically,
what I did with my hacky workaround above). Once one changes xcbImage->depth to
xcbImage->bpp in the switch statement, the old behaviour of the unpatched
version returns.

-- 
You are receiving this mail because:
You are watching all bug changes.