[plasmashell] [Bug 358039] Broken initial layout of the folder applet

[Hrvoje Senjan via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358039

Hrvoje Senjan  changed:

   What|Removed |Added

 CC||now...@gmail.com

--- Comment #5 from Hrvoje Senjan  ---
so this one 'broke' it:

commit 344dbeb93884af36f66e9a5133e7be7bd1b1e70d
Author: David Rosca 
Date:   Tue Dec 22 15:46:00 2015 +0100

AppletQuickItem: Drop timer to create full representation

The timer only added 250ms delay before creating the full representation,
sometimes resulting in showing empty popup for a moment.

REVIEW: 126468

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 358039] Broken initial layout of the folder applet

[David Rosca via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358039

--- Comment #7 from David Rosca  ---
Ah, so it did actually break something.

Please test https://git.reviewboard.kde.org/r/126778/

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 358039] Broken initial layout of the folder applet

[Hrvoje Senjan via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358039

--- Comment #8 from Hrvoje Senjan  ---
Yep, problem solved =)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 358039] Broken initial layout of the folder applet

[David Rosca via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358039

David Rosca  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
  Latest Commit||http://commits.kde.org/plas
   ||ma-framework/11937533e83659
   ||dc4dab6f7e8e6019863a28ddae

--- Comment #9 from David Rosca  ---
Git commit 11937533e83659dc4dab6f7e8e6019863a28ddae by David Rosca.
Committed on 17/01/2016 at 17:02.
Pushed by drosca into branch 'master'.

Ignore check if just one part of size is zero in compactRepresentationCheck

When debugging the linked bug, it looks like when item's geometry change
eg. from 0x0 to 100x100, geometryChanged may be called twice, first with 100x0
and then finally with 100x100.
This was not issue before, because we used timer to call
compactRepresentationCheck.
This changes compactRepresentationCheck so that it early returns also when just
one part of item's size is zero.

Fixes regression from 344dbeb938

REVIEW: 126778

M  +2-2src/plasmaquick/appletquickitem.cpp

http://commits.kde.org/plasma-framework/11937533e83659dc4dab6f7e8e6019863a28ddae

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 358039] Broken initial layout of the folder applet

[Hrvoje Senjan via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358039

Hrvoje Senjan  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1

--- Comment #2 from Hrvoje Senjan  ---
The issue is here for me when i also add the folder 'by hand'. I hope this
scenario is supported ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 358039] Broken initial layout of the folder applet

[Hrvoje Senjan via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358039

--- Comment #3 from Hrvoje Senjan  ---
Please note, the regression is somewhere in KF 5.17 -> 5.18 or Plasma 5.5.2 ->
5.5.3 as it worked correctly before.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 358039] Broken initial layout of the folder applet

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358039

--- Comment #4 from Eike Hein  ---
Ah sorry, I misunderstood your report initially. Seeing the problem now.

-- 
You are receiving this mail because:
You are watching all bug changes.