[plasmashell] [Bug 365295] The three icons in buttons "Search", "Filter" and "Close" are very small

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=365295

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||n...@kde.org
 Resolution|--- |FIXED

--- Comment #16 from Nate Graham  ---
Me neither, can't reproduce anymore. The buttons are the correct size now;
looks like this got fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365295] The three icons in buttons "Search", "Filter" and "Close" are very small

[Alexander Mentyu]

https://bugs.kde.org/show_bug.cgi?id=365295

Alexander Mentyu  changed:

   What|Removed |Added

 CC||notux...@gmail.com

--- Comment #15 from Alexander Mentyu  ---
Can't reproduce this bug in:

Plasma: 5.12.1
Apps: 17.12.2
Frameworks: 5.43.0
Qt: 5.10.1
Kernel: 4.14.20-2-MANJARO
OS: Netrunner Rolling

Both 'Add Widgets...' and 'Activities...' windows have icons of the same size

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365295] The three icons in buttons "Search", "Filter" and "Close" are very small

[Michail Vourlakos via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365295

--- Comment #14 from Michail Vourlakos  ---
David I tried and it didnt work, 

some numbers for my case,
heading.height and heading.implicitHeight , are both 29 in my system
searchInput.height is 0 in the beginning,

if I set directly 
Layout.minimumHeight: 30   //for header
the problem is fixed, it is one pixel difference, I suppose 29 gives us icon
size:24 and 30 gives us icon size: 36 
is this is why it is fixed that way?

I hope that helps

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365295] The three icons in buttons "Search", "Filter" and "Close" are very small

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365295

--- Comment #13 from David Edmundson  ---
that would break the case of the buttons being taller than the font.

Can you try:

diff --git a/desktoppackage/contents/explorer/WidgetExplorer.qml
b/desktoppackage/contents/explorer/WidgetExplorer.qml
index b8761b4..41b1baf 100644
--- a/desktoppackage/contents/explorer/WidgetExplorer.qml
+++ b/desktoppackage/contents/explorer/WidgetExplorer.qml
@@ -105,7 +105,7 @@ Item {

 Action {
 shortcut: "Up"
-onTriggered: list.currentIndex = (list.count + list.currentIndex - 1)
% list.count 
+onTriggered: list.currentIndex = (list.count + list.currentIndex - 1)
% list.count
 }

 Action {
@@ -207,11 +207,11 @@ Item {
 id: header
 property bool showingSearch: false
 Layout.fillWidth: true
-Layout.minimumHeight: Math.max(heading.height, searchInput.height)
+Layout.minimumHeight: Math.max(heading.implicitHeight,
searchInput.implicitHeight)
 Layout.alignment: Qt.AlignVCenter
 PlasmaExtras.Title {
 id: heading
-anchors.verticalCenter: parent.verticalCenter
+Layout.alignment: Qt.AlignVCenter
 text: i18nd("plasma_shell_org.kde.plasma.desktop", "Widgets")
 width: parent.width
 elide: Text.ElideRight
@@ -221,7 +221,7 @@ Item {
 id: searchInput
 width: parent.width
 clearButtonShown: true
-anchors.verticalCenter: parent.verticalCenter
+Layout.alignment: Qt.AlignVCenter
 placeholderText: i18nd("plasma_shell_org.kde.plasma.desktop",
"Search...")
 onTextChanged: {
 list.positionViewAtBeginning()

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365295] The three icons in buttons "Search", "Filter" and "Close" are very small

[Michail Vourlakos via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365295

--- Comment #12 from Michail Vourlakos  ---
This can be fixed in my system if at
   WidgetExplorer.qml:210  (Plasma 5.8.0)
I comment the line and do the following that looks a little how activities
manager is using height
---

//Layout.minimumHeight: Math.max(heading.height,
searchInput.height)
Layout.fillHeight: true

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365295] The three icons in buttons "Search", "Filter" and "Close" are very small

[Michail Vourlakos via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365295

Michail Vourlakos  changed:

   What|Removed |Added

Version|5.7.0   |5.8.0

--- Comment #11 from Michail Vourlakos  ---
This still remains in my system with Plasma 5.8.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365295] The three icons in buttons "Search", "Filter" and "Close" are very small

[Michail Vourlakos via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365295

--- Comment #10 from Michail Vourlakos  ---
I havent updated after plasma 5.7.3, so I can not confirm it yet...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365295] The three icons in buttons "Search", "Filter" and "Close" are very small

[Marco Martin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365295

Marco Martin  changed:

   What|Removed |Added

 CC||notm...@gmail.com

--- Comment #9 from Marco Martin  ---
is the bug still valid after above commit? (icons between widget explorer and
activity manager are the same here)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365295] The three icons in buttons "Search", "Filter" and "Close" are very small

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365295

--- Comment #8 from David Edmundson  ---
Git commit 79f842066d0544d879434b50aecee2cff7156336 by David Edmundson.
Committed on 01/08/2016 at 12:50.
Pushed by davidedmundson into branch 'Plasma/5.7'.

Remove dead code

Summary:
Setting the layout height to be the height of one of the layout items is
both pointless, it will be calculated from all child items
implicitHeight anyway, and wrong as the heading/textField could be
bigger.

Test Plan: Opened it, looked the same

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2241

M  +0-2desktoppackage/contents/activitymanager/Heading.qml

http://commits.kde.org/plasma-desktop/79f842066d0544d879434b50aecee2cff7156336

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365295] The three icons in buttons "Search", "Filter" and "Close" are very small

[Michail Vourlakos via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365295

Michail Vourlakos  changed:

   What|Removed |Added

 Status|NEEDSINFO   |UNCONFIRMED
 Resolution|WAITINGFORINFO  |---

--- Comment #7 from Michail Vourlakos  ---
uploaded my kdeglobals

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365295] The three icons in buttons "Search", "Filter" and "Close" are very small

[Michail Vourlakos via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365295

--- Comment #6 from Michail Vourlakos  ---
Created attachment 100226
  --> https://bugs.kde.org/attachment.cgi?id=100226=edit
this is my kdeglobals

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365295] The three icons in buttons "Search", "Filter" and "Close" are very small

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365295

David Edmundson  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #5 from David Edmundson  ---
If the icons are different to activity manager that's a bug, yes. Sorry to
misunderstand you at first.

Unfortunately I can't reproduce it, and the code between the two is mostly
identical.

Can you send me your exact font and icon config and reopen this bug report.
(ideally just attach your ~/.config/kdeglobals)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365295] The three icons in buttons "Search", "Filter" and "Close" are very small

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365295

David Edmundson  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX
 CC||k...@davidedmundson.co.uk

--- Comment #1 from David Edmundson  ---
Thanks for the report.

I'm afraid we can't match everyone's opinion - if we make them bigger we'll get
a bug report "the icons are too big" from someone.

It's using the stanard icon size - which is customisable in system settings.

-- 
You are receiving this mail because:
You are watching all bug changes.