[plasmashell] [Bug 367990] [Activity Pager] - Does not set Vertical Layout properly without corresponding Virtual Desktops

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=367990

Eike Hein  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||http://commits.kde.org/plas
   ||ma-desktop/2a5580d486acb175
   ||4913b17c19409b66ddec4d84

--- Comment #6 from Eike Hein  ---
Git commit 2a5580d486acb1754913b17c19409b66ddec4d84 by Eike Hein, on behalf of
Michail Vourlakos.
Committed on 24/10/2016 at 21:35.
Pushed by hein into branch 'master'.

Improve Activity Pager Layout for horizontal and vertical cases

Adds option to configure layout.

M  +2-1applets/kicker/package/contents/ui/ItemGridDelegate.qml
M  +12   -0applets/kicker/package/contents/ui/ItemGridView.qml
M  +9-0applets/pager/package/contents/config/main.xml
M  +13   -0applets/pager/package/contents/ui/configGeneral.qml
M  +17   -7applets/pager/package/contents/ui/main.qml

http://commits.kde.org/plasma-desktop/2a5580d486acb1754913b17c19409b66ddec4d84

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 367990] [Activity Pager] - Does not set Vertical Layout properly without corresponding Virtual Desktops

[Michail Vourlakos via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=367990

--- Comment #5 from Michail Vourlakos  ---
I would like someone to review this please:

https://phabricator.kde.org/D3130

regards,
michail

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 367990] [Activity Pager] - Does not set Vertical Layout properly without corresponding Virtual Desktops

[Michail Vourlakos via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=367990

--- Comment #4 from Michail Vourlakos  ---
> If we make it a 1D list, is there ever a case to have a vertical list in a 
> horizontal panel? They don't really fit.

yes, it depends from the height of the panel, which is something the user is
setting.
1. My case is that I use 2-3 running activities and the rest are disabled,
which fit with a little biger height in a vertical layout.
2. I also want the activities pager layout to correspond with what the
"Activity Switcher" is presenting (this is something to be fixed also later,
the activity pager is not showing the activities with the order the "Activity
Switcher" does).
3. Setting only horizontal for a horizontal panel will create problems, for
example if the panel's height is a little bigger then 2-3 activities would
catch too much space.

I propose that the user should decide the layout with 3 choices:
1. Default (the current behavior which I dont think actually it makes any sense
but because it is used very long could be also the defaul behavior)
2. Horizontal
3. Vertical

we could also drop choice (1), and use Horizontal for a horizontal panel by
default, but the user could change this to vertical from pager settings and
vice versa.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 367990] [Activity Pager] - Does not set Vertical Layout properly without corresponding Virtual Desktops

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=367990

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #3 from David Edmundson  ---
If we make it a 1D list, is there ever a case to have a vertical list in a
horizontal panel? They don't really fit.

At which point maybe we don't need the option and can just use the
Plasmoid.location?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 367990] [Activity Pager] - Does not set Vertical Layout properly without corresponding Virtual Desktops

[Michail Vourlakos via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=367990

--- Comment #2 from Michail Vourlakos  ---
I am working on a patch for this,

current status is that the activity pager uses the virtual desktops layout in
order to present itself,
I propose that for the activity pager there should be an horizontal or a 
vertical layout which can be set through its settings...
Or it could be the default behavior(using vds layout),only horizontal,only
vertical  

what do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 367990] [Activity Pager] - Does not set Vertical Layout properly without corresponding Virtual Desktops

[Michail Vourlakos via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=367990

Michail Vourlakos  changed:

   What|Removed |Added

Summary|[Activity Pager] - Can not  |[Activity Pager] - Does not
   |set Vertical Layout |set Vertical Layout
   |properly|properly without
   ||corresponding Virtual
   ||Desktops

-- 
You are receiving this mail because:
You are watching all bug changes.