[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

Eike Hein  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|FIXED   |---
 Ever confirmed|1   |0

--- Comment #20 from Eike Hein  ---
Thanks, I see the problems now. Unfortunately I can't reason about what's
broken from them though, seems I will have to make/find the time to install
this app.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[David Brooke via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #19 from David Brooke  ---
Per your request I have provided the following information to better clarify
the main issue.

I have created three short videos:
Expected correct condition (which shows the group popup):
https://dl.dropboxusercontent.com/u/17574275/group-popup.mp4
Error condition - hidden panel (C3770-P2):
https://dl.dropboxusercontent.com/u/17574275/TMWP-5.8-neon-C3770-P2-1.mp4
Error condition - group popup (C4790K-P1):
https://dl.dropboxusercontent.com/u/17574275/TMWP-5.8-neon-C4790K-P1-1.mp4


Error conditions:
The hidden panel cannot be accessed or if it can, the wine program (Sierra
Chart) task button does not have a group popup showing the available windows.
In either instance a transparent outline of the panel or the group popup is
displayed and other windows cannot be brought into focus while in this error
condition.
Error correction:
Switching to another virtual desktop and moving the mouse over then away from
the panel seems to correct the problem condition.

You can decide whether to conquer both error conditions or separate them into
two different bugs. I lean toward that both originate from the same issue but
manifest slightly different results.

Note:
Both test computers are very similar but the video capability difference stands
out to me as a possible key element.

Computer-3770 
CPU - CI7-3770
Video - HD4000
Memory - 8GB
Partition2 or C3770-P2
KDE Neon 5.8
Plasma 5.8.0
Frameworks 5.26
KDE Apps 16.08.1
QT5 - version 5.7
xf86-video-intel 2.99.917*

Computer-4790K
CPU - CI7-4790K
Video - HD4600
Memory - 8GB
Partition1 or C4790K-P1
KDE Neon 5.8
Plasma 5.8.0
Frameworks 5.26
KDE Apps 16.08.1
QT5 - version 5.7
xf86-video-intel 2.99.917*

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #18 from Eike Hein  ---
I'm sorry, I'm just lost in all of this data right now. To make progress, can
we try to do this:

a) Please get ahold of the latest stable release of Plasma, which contains the
fixes made so far, i.e. Plasma 5.8 - if you can't install this easily, you can
download KDE Neon User Edition with 5.8 and install wine and Sierra there. From
your above comments I currently don't know whether you've re-tested with the
new code, and because the fixes fundamentally change how the Task Manager
identifies wine client windows, it might well affect any of your wine-related
issues. I.e. I don't know if your assessment that "a small piece of the puzzle
was addressed" is based on testing or not.

b) Using Plasma 5.8, please try to reproduce your problem(s) and see if they
remain

c) We need to make sure we're on the same page as far as terminology goes. By
"group popup", do you refer to the vertical list of task buttons that appears
when clicking a group button on the panel, or do you mean the horizontal list
of window thumbnails that appears as a tooltip when hovering the group button?
Freezes related to window thumbnails may actually be out of the purview of the
Task Manager, as they can be e.g. graphics driver related, so to sort this out
I need to understand what you mean precisely.

I did try to take a look at the video in comment 12, but it was very long and I
wasn't sure what the problem was. It would help to supply e.g. time indices
inside a video where things go wrong. But again, it would be best to start over
on the current code (Plasma 5.8).

Thank you for going to the trouble to describe how to obtain Sierra Charts for
testing purposes, I'll do that if we can't get ahead with the above approach.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[David Brooke via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #17 from David Brooke  ---
(In reply to Eike Hein from comment #16)
> I'm confused as well. Your problem was grouping, right? That's fixed. If
> not, please don't create monster tickets that combined multiple bugs into
> one.

I try to report  all relevant data for the issue so that the best attempt with
the least amount of effort may be accomplished by the person resolving the
issue. Along with the data,  I supplied several videos to further fully inform.
In doing the above, if I have created "multiple bugs" I apologize.
I believe that if you just review the supplied videos...there really would be
any confusion.
See comments 1 and 12 for the videos of the main issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #16 from Eike Hein  ---
I'm confused as well. Your problem was grouping, right? That's fixed. If not,
please don't create monster tickets that combined multiple bugs into one.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[David Brooke via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #15 from David Brooke  ---
I'm confused and need additional direction.
The bug has been labeled "Resolved" but the main issue remains open. One small
part of the puzzle  has been solved but the main issue has not been addressed.
I have provided addition data to help resolve the main issue, is additional
data required? Please let me know how to proceed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

Eike Hein  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/plas
   ||ma-workspace/5e30fc609e7692
   ||129f444e4455d5b9300bfc23ff
 Status|CONFIRMED   |RESOLVED

--- Comment #14 from Eike Hein  ---
Git commit 5e30fc609e7692129f444e4455d5b9300bfc23ff by Eike Hein.
Committed on 19/09/2016 at 07:51.
Pushed by hein into branch 'Plasma/5.8'.

Add an ultimate fallback to WM_CLASS Class for AbstractTasksModel::AppId in
XWindowsTasksModel.

Summary:
This makes grouping work for apps we can't find on the system and
can't produce a launcher URL for, such as wine clients. Any better
app will use our superior codepath, the wonky ones like wine then
get left to making sure their WM_CLASS Class makes sense as per the
ICCCM spec.

Of course this doesn't work for XWayland clients on Wayland though.

Also nixes an obsolete FIXME and adds a small check to avoid
producing launcher URLs that are only the window icon pixmap
query element.

Reviewers: #plasma, davidedmundson, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2804

M  +10   -1libtaskmanager/taskgroupingproxymodel.cpp
M  +19   -1libtaskmanager/xwindowtasksmodel.cpp

http://commits.kde.org/plasma-workspace/5e30fc609e7692129f444e4455d5b9300bfc23ff

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[David Brooke via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #12 from David Brooke  ---
https://dl.dropboxusercontent.com/u/17574275/TMWP-Patch-C3770-P2.mp4

The video shows Sierra Chart being used on C3770-P2. Everything seems to be
working:
1. The panel can hide/unhide
2. The group popup
3. Grouping function
Once more Sierra Chart windows are added, the panel and group popup start to
malfunction. The panel and group popup seem to freeze, being non-accessible.
The malfunction can be corrected by:
1. Switching to another virtual desktop
2. Moving the mouse over the panel area then back to the desktop

The following post I will layout wine and Sierra Chart installation and setup
for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[David Brooke via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #11 from David Brooke  ---
I have tested the patch on three computers (see below) and the grouping
function works with notepad and Sierra Chart programs.
1. I opened 40 windows of notepad without issue.
2. Sierra Chart has a limit to the number of windows that can be opened before
a "freezing" issue occurs which I will explain further in the next post. The
limited number of windows is less than the current ability of Plasma 5.6 of
which an upper limit has not been tested.

Partition2 or C3770-P2
Gentoo AMD64 Stable
Plasma 5.7.95
Frameworks 5.26
KDE Apps 16.08.1
QT5 - version 5.6.1
xf86-video-intel 2.99.917-r2

Partition2 or C4790K-P2
Gentoo AMD64 Stable
Plasma 5.7.95
Frameworks 5.26
KDE Apps 16.08.1
QT5 - version 5.6.1
xf86-video-intel 2.99.917-r2

Partition1 or C4790-P1
Gentoo AMD64 Stable
Plasma 5.7.5
Frameworks 5.26
KDE Apps 16.08.1
QT5 - version 5.6.1
nvidia-drivers 361.28

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #10 from Eike Hein  ---
Patch: https://phabricator.kde.org/D2804

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #9 from Eike Hein  ---
Apparently newer versions of wine changed behavior somewhat. Notepad now has a
WM_CLASS of "notepad.exe, notepad.exe". We of course can't map this to a
.desktop file nor an executable URL, so we don't have working app ids or a
working launcher URL and nothing to group by. Tricky, but I have an idea.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

Eike Hein  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #8 from Eike Hein  ---
I can reproduce something now - will take a closer look soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[David Brooke via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #7 from David Brooke  ---
Tested plasma 5.7.95 and the results are the same. Refer to the first "Doesn't
work as expected" video.

Partition2 or C3770-P2
Gentoo AMD64 Stable
Plasma 5.7.95
Frameworks 5.26
KDE Apps 16.08.1
QT5 - version 5.6.1
xf86-video-intel 2.99.917-r2

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

Eike Hein  changed:

   What|Removed |Added

   Severity|critical|normal

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[David Brooke via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #6 from David Brooke  ---
To date:
I have installed three different distro's:
Gentoo
Arch
KDE Neon
All reproduce the same issue with the Task Manager's grouping function and wine
programs.
Please let me know if other info is needed.
Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[David Brooke via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #5 from David Brooke  ---
9/14/16 Update

Plasma-Task Manager and Wine issues
I have simplified the issue of grouping not working for wine programs:
1. The issue is reproducible by:
A. Opening 2 or more windows of notepad while the grouping function is always
enforced.
B. Opening 9 windows of notepad while grouping is only enforced when the task
manager is full.
Either of the above two options will show that grouping does not work for wine
programs but does work for others (dolphin, konsole, etc...).

Three computers have been used for evaluation (See below). Computer-3770
originally showed the issue then Computer-4790K and Computer-4790 were used for
additional testing.
Partition1 or C3770-P1 is the only setup that works correctly. All others fail.

Test1
Currently Plasma 5.7.0 through 5.7.5 has an issue with Sierra Chart running
under Wine 1.9.18 for C3770-P2.
Results are the same as before.

Test2
Currently Plasma 5.7.3 and 5.7.5 has an issue with Sierra Chart running under
Wine 1.9.18 for C4790K-P1, C4790K-P2 and C4790-P1. C4790K-P1 with KDE Neon uses
wine 1.6.2.
Results are the same as before.



Computer-3770 
CPU - CI7-3770
Video - HD4000
Memory - 8GB

Partition1 or C3770-P1
Gentoo AMD64 Stable
Plasma 5.6.5
Frameworks 5.26
KDE Apps 16.08.1
QT5 - version 5.6.1
xf86-video-intel 2.99.917-r2

Partition2 or C3770-P2
Gentoo AMD64 Stable
Plasma 5.7.5
Frameworks 5.26
KDE Apps 16.08.1
QT5 - version 5.6.1
xf86-video-intel 2.99.917-r2

###

Computer-4790K
CPU - CI7-4790K
Video - HD4600
Memory - 8GB

Partition1 or C4790K-P1
Arch
Plasma 5.7.4
Frameworks 5.26
KDE Apps 16.08.1
QT5 - version 5.7.0
xf86-video-intel 2.99.917+697+g12c14de

Partition1 or C4790K-P1
KDE Neon
Plasma 5.7.5
Frameworks 5.26
KDE Apps 16.08.0
QT5 - version 5.7.0
xserver-xorg-video-intel 2:2.99.917+git20160325-1ubuntu1.1

Partition2 or C4790K-P2
Gentoo AMD64 Stable
Plasma 5.7.5
Frameworks 5.26
KDE Apps 16.08.1
QT5 - version 5.6.1
xf86-video-intel 2.99.917-r2

###

Computer-4790
CPU - CI7-4790
Video - Nvidia GTX-950
Memory - 8GB

Partition1 or C4790-P1
Gentoo AMD64 Stable
Plasma 5.7.5
Frameworks 5.26
KDE Apps 16.08.1
QT5 - version 5.6.1
nvidia-drivers 361.28

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #4 from Eike Hein  ---
Grouping "wine notepad" works OK on my Plasma 5.7.x ...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[David Brooke via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #3 from David Brooke  ---
I have tested the "window list" alternative to the "task manager".  The panel
hide functions as expected also the "window list" alternative does not have a
grouping function.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[David Brooke via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #2 from David Brooke  ---
I have tested using notepad instead of Sierra Chart. The only issue that I can
see, is that the grouping function fails or doesn't work with any video intel
or nvidia.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368078] Plasma-Task Manager and Wine issues

[David Brooke via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368078

--- Comment #1 from David Brooke  ---
Videos:
Works as expected (C3770-P1)
https://dl.dropboxusercontent.com/u/17574275/TMWPlasma5.6.5.mp4
Doesn't work as expected (C3770-P2, C4790K-P1, C4790K-P2 and C4790-P1)
https://dl.dropboxusercontent.com/u/17574275/TMWPlasma5.7.3.mp4
https://dl.dropboxusercontent.com/u/17574275/TMWPlasma5.7.3-arch.mp4

-- 
You are receiving this mail because:
You are watching all bug changes.