[plasmashell] [Bug 369622] KDE apps always use 32px icons in system tray
https://bugs.kde.org/show_bug.cgi?id=369622 Marco Martin changed: What|Removed |Added Resolution|INVALID |FIXED Latest Commit||http://commits.kde.org/plas ||ma-framework/f37cc1361481a2 ||d6ce530e87c68706d81c326b98 --- Comment #9 from Marco Martin --- Git commit f37cc1361481a2d6ce530e87c68706d81c326b98 by Marco Martin. Committed on 08/11/2016 at 09:53. Pushed by mart into branch 'master'. Fix SVG icon ID prefix As https://bugs.kde.org/show_bug.cgi?id=369622#c5 mentioned, if icon has both 22px and 32px sizes, the 22px one should have prefix of 22-22- in object ID while the 32px one shouldn't. Checked all existing icons and to correct wrong IDs. patch by Yunhe Guo CCMAIL:guoyunhebr...@gmail.com Change-Id: I9d8728cfa9ce47a3b0e5042ed616f142c19a REVIEW:129329 M +---src/desktoptheme/breeze/icons/akonadi.svgz M +---src/desktoptheme/breeze/icons/akregator.svgz M +---src/desktoptheme/breeze/icons/amarok.svgz M +---src/desktoptheme/breeze/icons/apport.svgz M +---src/desktoptheme/breeze/icons/cantata.svgz M +---src/desktoptheme/breeze/icons/configure.svgz M +---src/desktoptheme/breeze/icons/document.svgz M +---src/desktoptheme/breeze/icons/drive.svgz M +---src/desktoptheme/breeze/icons/edit.svgz M +---src/desktoptheme/breeze/icons/kalarm.svgz M +---src/desktoptheme/breeze/icons/konv_message.svgz M +---src/desktoptheme/breeze/icons/media.svgz M +---src/desktoptheme/breeze/icons/nepomuk.svgz M +---src/desktoptheme/breeze/icons/phone.svgz M +---src/desktoptheme/breeze/icons/touchpad.svgz http://commits.kde.org/plasma-framework/f37cc1361481a2d6ce530e87c68706d81c326b98 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 369622] KDE apps always use 32px icons in system tray
https://bugs.kde.org/show_bug.cgi?id=369622 --- Comment #8 from Guo Yunhe (郭云鹤) --- https://git.reviewboard.kde.org/r/129329/ This patch should fix the 22-22- ID prefix proglem. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 369622] KDE apps always use 32px icons in system tray
https://bugs.kde.org/show_bug.cgi?id=369622 --- Comment #7 from Guo Yunhe (郭云鹤) --- I also have a suggestion: force every size to provide a prefix: * 22-22-amarok * 32-32-amarok Then here will be no confusing about naming. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 369622] KDE apps always use 32px icons in system tray
https://bugs.kde.org/show_bug.cgi?id=369622 Guo Yunhe (郭云鹤) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #6 from Guo Yunhe (郭云鹤) --- (In reply to Marco Martin from comment #5) > tried with that exact svg and it's yellow. > but, for how the svg is done is kinda expected. > the problem is that the version without prefix is the 22x22px, while the > bigger 32x32 version has a prefix. > > the supported way (that works and makes the icon red) is the other way > around: the biggest available version without prefix, and the smallest ones > with a prefix instead, so if you have ids: > 22-22-amarok > and > amarok > > then the 22px version gets correctly picked OK, I understand. Then it is the problem of SVG files. I checked those SVG files a long time ago and most of them are not correctly prefixed. When both 32px and 22px are available, 32px is prefixed but 22px is not. I could submit a patch for that later. But I think this bug could be closed (not really a problem of programming). -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 369622] KDE apps always use 32px icons in system tray
https://bugs.kde.org/show_bug.cgi?id=369622 --- Comment #5 from Marco Martin --- tried with that exact svg and it's yellow. but, for how the svg is done is kinda expected. the problem is that the version without prefix is the 22x22px, while the bigger 32x32 version has a prefix. the supported way (that works and makes the icon red) is the other way around: the biggest available version without prefix, and the smallest ones with a prefix instead, so if you have ids: 22-22-amarok and amarok then the 22px version gets correctly picked -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 369622] KDE apps always use 32px icons in system tray
https://bugs.kde.org/show_bug.cgi?id=369622 --- Comment #4 from Guo Yunhe (郭云鹤) --- I have new evidence to support it. From latest git, folder src/desktoptheme/breeze/icons 1. In start.svgz file, objects are: * 22-22-start-here-kde (22px) * start-here-kde (32px) 2. In amarok.svgz file, objects are: * amarok (22px) * 32-32-amarok (32px) I believe here must be some problems in naming and loading icon sizes. Otherwise, it won't be using inconsistent id. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 369622] KDE apps always use 32px icons in system tray
https://bugs.kde.org/show_bug.cgi?id=369622 --- Comment #3 from Guo Yunhe (郭云鹤) --- (In reply to Marco Martin from comment #2) > is the system high dpi? > locally i can't reproduce, i get the 22px graphics for 22 pixels and less > systray icons Not High-DPI. It is Full HD (1920x1080) screen. Can you test with my amarok.svgz and take a screenshot? Is it a red or yellow square on your system? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 369622] KDE apps always use 32px icons in system tray
https://bugs.kde.org/show_bug.cgi?id=369622 Marco Martin changed: What|Removed |Added CC||notm...@gmail.com --- Comment #2 from Marco Martin --- is the system high dpi? locally i can't reproduce, i get the 22px graphics for 22 pixels and less systray icons -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 369622] KDE apps always use 32px icons in system tray
https://bugs.kde.org/show_bug.cgi?id=369622 --- Comment #1 from Guo Yunhe (郭云鹤) --- Created attachment 101375 --> https://bugs.kde.org/attachment.cgi?id=101375&action=edit amarok.svgz -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 369622] KDE apps always use 32px icons in system tray
https://bugs.kde.org/show_bug.cgi?id=369622 Guo Yunhe (郭云鹤) changed: What|Removed |Added Platform|Other |openSUSE RPMs -- You are receiving this mail because: You are watching all bug changes.