[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384031

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/pla
   ||sma-framework/a21bc11fe1165
   ||1f6d211489ebfc8435cef877194

--- Comment #19 from Nate Graham  ---
Git commit a21bc11fe11651f6d211489ebfc8435cef877194 by Nathaniel Graham.
Committed on 16/03/2018 at 22:26.
Pushed by ngraham into branch 'master'.

Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is
set

Summary:
When `PLASMA_USE_QT_SCALING=1` is set, Plasma uses native Qt scaling. This
works fine for integer scale factors, and fixes a lot of bugs (see
[[https://bugs.kde.org/show_bug.cgi?id=356446|Bug 356446]]) but it introduces a
new one: with non-integer scale factors, text becomes blurry and pixellated
because of a bug in `Text.NativeRendering`:
https://bugreports.qt.io/browse/QTBUG-67007

QQC2-desktop-style forces the use of `Text.QtRendering` rendering for
non-integer scale factors, successfully working around the problem. But
PlasmaComponents QML objects don't implement the same workaround, so we see the
issue in Plasma. This patch fixes that, and gets us one step closer to being
able to use Qt scaling in Plasmashell.

There is no effect when `PLASMA_USE_QT_SCALING=1` is not being used.

FIXED-IN 5.13
Related: bug 391691, bug 386216, bug 391695, bug 391694, bug 385547, bug
391692, bug 356446

Test Plan:
Before: `PLASMA_USE_QT_SCALING=1` set, 1.2 scale factor: Plasma text looks
awful:
{F5749797}

After: `PLASMA_USE_QT_SCALING=1` set, 1.2 scale factor: Plasma text looks
amazing!
{F5749798}

Note that we still get sub-pixel anti-aliasing and good kerning. There appear
to be no layout regressions.

Without both `PLASMA_USE_QT_SCALING=1` and a non-integer scale factor set,
there is no visual change compared to the status quo.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: mart, broulik, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D11244

M  +4-2examples/applets/testtheme/contents/ui/FontGizmo.qml
M  +5-1src/declarativeimports/plasmacomponents/qml/Label.qml
M  +5-1   
src/declarativeimports/plasmacomponents/qml/private/DualStateButton.qml
M  +4-0src/declarativeimports/plasmacomponents3/ComboBox.qml
M  +5-1src/declarativeimports/plasmacomponents3/Label.qml
M  +5-1src/declarativeimports/plasmacomponents3/TextArea.qml
M  +5-1src/declarativeimports/plasmacomponents3/TextField.qml
M  +5-0src/declarativeimports/plasmastyle/ComboBoxStyle.qml
M  +4-1src/declarativeimports/plasmastyle/SpinBoxStyle.qml
M  +4-1src/declarativeimports/plasmastyle/TextAreaStyle.qml
M  +4-1src/declarativeimports/plasmastyle/TextFieldStyle.qml

https://commits.kde.org/plasma-framework/a21bc11fe11651f6d211489ebfc8435cef877194

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384031

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #18 from Nate Graham  ---
This is caused by the use of QTQuickControls widgets that use a font rendering
style that doesn't support non-integer scale factors. System Settings KCMs are
being rewritten (see https://phabricator.kde.org/tag/plasma_kcm_redesign/),
which will fix this one KCM at a time. Plasma itself will be fixed with
https://phabricator.kde.org/D11244

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=384031

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384031

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[Simonas]

https://bugs.kde.org/show_bug.cgi?id=384031

Simonas  changed:

   What|Removed |Added

 CC||obuol...@gmail.com

--- Comment #17 from Simonas  ---
I can confirm the same issue on my dell xps 15 4k, when i set scaling to non
integer value (2.2 in my case) i get the same fuzzy looking fonts. Im also
running qt 5.10, and it didnt solve any issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[Felix]

https://bugs.kde.org/show_bug.cgi?id=384031

Felix  changed:

   What|Removed |Added

 CC||felixbuett...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[sac]

https://bugs.kde.org/show_bug.cgi?id=384031

--- Comment #16 from sac  ---
Created attachment 108547
  --> https://bugs.kde.org/attachment.cgi?id=108547=edit
Side by side comparism 1,5 & 2,0

Exactly, the left sidebar is fine, just the right content area is messed up.

BTW: just checked, files are named correctly (as mentioned, they have to be
opened in the original size, not zoomed). Attached here is a side-by-side
comparism.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=384031

--- Comment #15 from David Edmundson  ---
It's very interesting that the left sidebar looks ok in that screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[Robert Lindgren]

https://bugs.kde.org/show_bug.cgi?id=384031

--- Comment #14 from Robert Lindgren  ---
I think the prefix for the images is wrong since the 2.0 is fuzzy in the last
example.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=384031

--- Comment #13 from David Edmundson  ---
What's wrong with the 1.5 in that picture?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[sac]

https://bugs.kde.org/show_bug.cgi?id=384031

--- Comment #12 from sac  ---
You're right, tested with "openSUSE_Krypton.x86_64-5.11.90-Build1.44.iso" (QT
5.10, before I just tested with Neon Live and guess that not all was loaded
after logging out and back in). 

>(which btw, is fixed for next Applications release)
Yes, fixed in Krypton ;)

>Everything should work fine with 2.0
True, all stuff is fine with 2.0.

Just the login screen & desktop effects has not changed with QT5.10 and is
still not aliased ( https://bugs.kde.org/attachment.cgi?id=107578 ) with "about
system settings -> libraries" = "build against 5.10.0". Env attached.
With 1.5 broken: https://bugs.kde.org/attachment.cgi?id=108509
With 2.0 it's OK: https://bugs.kde.org/attachment.cgi?id=108510

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[sac]

https://bugs.kde.org/show_bug.cgi?id=384031

--- Comment #11 from sac  ---
Created attachment 108511
  --> https://bugs.kde.org/attachment.cgi?id=108511=edit
env

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[sac]

https://bugs.kde.org/show_bug.cgi?id=384031

--- Comment #10 from sac  ---
Created attachment 108510
  --> https://bugs.kde.org/attachment.cgi?id=108510=edit
1.5 NOK Desktop effects

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[sac]

https://bugs.kde.org/show_bug.cgi?id=384031

--- Comment #9 from sac  ---
Created attachment 108509
  --> https://bugs.kde.org/attachment.cgi?id=108509=edit
2.0 OK Desktop effects

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=384031

--- Comment #8 from David Edmundson  ---
Okular is unrelated. That's on them to fix.
(which btw, is fixed for next Applications release)

Everything should work fine with 2.0 - please post a screenshot of that and
include the output of running "env".

Embedded QtQuick did have an issue with fractional scaling but that should be
fixed by dfce0a8feceeb7156eba6ac5d8d3521e3009a583 in QtDeclarative. 

Can you double double check you have Qt 5.10 running please. You can see it in
menu -> about system settings -> libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[Robert Lindgren]

https://bugs.kde.org/show_bug.cgi?id=384031

Robert Lindgren  changed:

   What|Removed |Added

 CC||r...@x0.se

--- Comment #7 from Robert Lindgren  ---
I have the same problem in KDE Neon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[sac]

https://bugs.kde.org/show_bug.cgi?id=384031

--- Comment #6 from sac  ---
Created attachment 108488
  --> https://bugs.kde.org/attachment.cgi?id=108488=edit
Scale 1,5 NOK Plasma 5.11.90

Even worse in Plasma 5.11.90

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[sac]

https://bugs.kde.org/show_bug.cgi?id=384031

sac  changed:

   What|Removed |Added

 Attachment #107578|Original OK |Scale 1,5 Login NOK
description||

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[sac]

https://bugs.kde.org/show_bug.cgi?id=384031

--- Comment #5 from sac  ---
Created attachment 108413
  --> https://bugs.kde.org/attachment.cgi?id=108413=edit
Scale 1,0 OK

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[sac]

https://bugs.kde.org/show_bug.cgi?id=384031

sac  changed:

   What|Removed |Added

 Resolution|UPSTREAM|---
 Status|RESOLVED|UNCONFIRMED

--- Comment #4 from sac  ---
Sry, but this is not fixed. 

Exactly the same result with Qt 5.10 Beta (tested with KDE Neon devn unstable
"deb http://archive.neon.kde.org/testing xenial main"). Same on Qt 5.9.2
(tested with Suse Krypton).

Apart from the ugly fonts in Okular and system settings, all log screen images
are not aliased, too (after clicking kde menu->logout images for shutdown,
logout, restart are totally ugly).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=384031

Christoph Feck  changed:

   What|Removed |Added

 CC||cf...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=384031

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from David Edmundson  ---
Fixed in Qt 5.10

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[sac]

https://bugs.kde.org/show_bug.cgi?id=384031

--- Comment #2 from sac  ---
Created attachment 107578
  --> https://bugs.kde.org/attachment.cgi?id=107578=edit
Original OK

Open this image with 100% (original size) and compare the "e" in "Hint: to find
out or configure"

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[sac]

https://bugs.kde.org/show_bug.cgi?id=384031

--- Comment #1 from sac  ---
Created attachment 107577
  --> https://bugs.kde.org/attachment.cgi?id=107577=edit
Scale 1,5 NOK

Open this image with 100% (original size) and compare the "e" in "Hint: to find
out or configure"

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384031] Monitor Scaling / HiDPI support breaks font Anti-Aliasing

[sac]

https://bugs.kde.org/show_bug.cgi?id=384031

sac  changed:

   What|Removed |Added

Summary|Monitor Scaling breaks font |Monitor Scaling / HiDPI
   |Anti-Aliasing   |support breaks font
   ||Anti-Aliasing

-- 
You are receiving this mail because:
You are watching all bug changes.