[plasmashell] [Bug 384950] Breeze decorator uses wrong colors
https://bugs.kde.org/show_bug.cgi?id=384950 Nate Graham changed: What|Removed |Added Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 384950] Breeze decorator uses wrong colors
https://bugs.kde.org/show_bug.cgi?id=384950 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 384950] Breeze decorator uses wrong colors
https://bugs.kde.org/show_bug.cgi?id=384950 --- Comment #13 from Pulfer --- (In reply to Martin Flöser from comment #8) > This is something startkde or kcminit needs to take care of to make sure the > color scheme is synced to kdeglobals. Can someone with good knowledge of Plasma internals implement this feature? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 384950] Breeze decorator uses wrong colors
https://bugs.kde.org/show_bug.cgi?id=384950 --- Comment #12 from Christoph Feck --- KWin decoration colors are indeed unrelated to KColorScheme colors. The systemsettings color editor copies the colors of the selected scheme into the appropiate sections of 'kdeglobals'. If the [WM] section (with decoration colors) is not present in the 'kdeglobals' file, KConfig falls back to try the application configuration file, in this case 'kwinrc'. I do not see how it is a bug. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 384950] Breeze decorator uses wrong colors
https://bugs.kde.org/show_bug.cgi?id=384950 --- Comment #11 from Pulfer --- Still it's quite surprising and unexpected behavior (of overall desktop) that most colors can be properly loaded from color scheme (with "~/.config/kdeglobals -> /etc/xdg/kdeglobals -> color scheme" priority order). While [WM] colors can be loaded only from ~/.config/kdeglobals. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 384950] Breeze decorator uses wrong colors
https://bugs.kde.org/show_bug.cgi?id=384950 --- Comment #10 from Martin Flöser --- (In reply to Pulfer from comment #9) > (In reply to Martin Flöser from comment #8) > > (In reply to Pulfer from comment #7) > > > And it looks like only [WM] from ~/.config/kdeglobals is loaded. Even [WM] > > > colors from /etc/xdg/kdeglobals are ignored, not only from color scheme. > > > > Given the code this is intended. It explicitly does not ask for cascading > > config. > > Maybe there should be an exception for kdeglobals (as there are other hacks > for kdeglobals in the code)? As I wrote: this is intended here, so no: this should not use a special case for kdeglobals. Otherwise let's please keep this bug focused on the default config not having the WM group -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 384950] Breeze decorator uses wrong colors
https://bugs.kde.org/show_bug.cgi?id=384950 --- Comment #9 from Pulfer --- (In reply to Martin Flöser from comment #8) > (In reply to Pulfer from comment #7) > > And it looks like only [WM] from ~/.config/kdeglobals is loaded. Even [WM] > > colors from /etc/xdg/kdeglobals are ignored, not only from color scheme. > > Given the code this is intended. It explicitly does not ask for cascading > config. Maybe there should be an exception for kdeglobals (as there are other hacks for kdeglobals in the code)? -auto config = KSharedConfig::openConfig(m_colorScheme, KConfig::SimpleConfig); +KConfig::OpenFlags openMode = KConfig::SimpleConfig; +if (m_colorScheme.endsWith(QStringLiteral("/kdeglobals"))) +openMode = KConfig::FullConfig; + +auto config = KSharedConfig::openConfig(m_colorScheme, openMode); -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 384950] Breeze decorator uses wrong colors
https://bugs.kde.org/show_bug.cgi?id=384950 Martin Flöser changed: What|Removed |Added Assignee|kwin-bugs-n...@kde.org |k...@davidedmundson.co.uk Component|decorations |general CC||plasma-b...@kde.org Target Milestone|--- |1.0 Product|kwin|plasmashell --- Comment #8 from Martin Flöser --- (In reply to Pulfer from comment #7) > And it looks like only [WM] from ~/.config/kdeglobals is loaded. Even [WM] > colors from /etc/xdg/kdeglobals are ignored, not only from color scheme. Given the code this is intended. It explicitly does not ask for cascading config. KWin itself does not have any idea about which color scheme is used and KWin certainly does not care about it. This does not belong into KWin. This is something startkde or kcminit needs to take care of to make sure the color scheme is synced to kdeglobals. Actually this bug should be reassigned to a component "plasma-workspace" or "startkde" but those do not exist, so reassigning to plasmashell as it's the most closest thing to the overall desktop. -- You are receiving this mail because: You are watching all bug changes.