[plasmashell] [Bug 385522] Present Windows: Don't darken all windows and denote selection some other way than restoring original lightness

2017-10-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385522

--- Comment #7 from Nate Graham  ---
You don't need my permission; patches are always welcome!

My preference would be to not lighten or darken windows at all, and use
something else to show selection, like how macOS does it. Then we don't even
need to add a new user-facing setting.

But it's your patch, so you get to choose. :) Once you have something working,
please submit it on https://phabricator.kde.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385522] Present Windows: Don't darken all windows and denote selection some other way than restoring original lightness

2017-10-09 Thread Salva Corts
https://bugs.kde.org/show_bug.cgi?id=385522

--- Comment #6 from Salva Corts  ---
Exactly, you are actually having the same feedback when you select a windows
with dark windows as with fully bright windows. I would like to help you
implementing that feature. Do I have green light?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385522] Present Windows: Don't darken all windows and denote selection some other way than restoring original lightness

2017-10-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385522

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
Summary|Present Windows: Do not |Present Windows: Don't
   |hardcode brightness on  |darken all windows and
   |presentwindows.cpp  |denote selection some other
   ||way than restoring original
   ||lightness

--- Comment #5 from Nate Graham  ---
The idea is that when you mouse over a window, it becomes bright, to show that
it's selected.

But I see what you mean, it's a bit dim. And not only Windows 10 that keeps
them bright all the time; macOSalso keeps then un-darkened during a Present
Windows operation. In macOS, selection is denoted by a blue border and the a
floating box showing the window title.

While a user-facing option would resolve this issue, it may be worth revisiting
the default state as well, so that people don't feel like they have to tweak
anything.

-- 
You are receiving this mail because:
You are watching all bug changes.