[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=390632

Vlad Zagorodniy  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-framework/dce258bee3da8
   ||54980b6f2430b26f7025752a505
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from Vlad Zagorodniy  ---
Git commit dce258bee3da854980b6f2430b26f7025752a505 by Vlad Zagorodniy.
Committed on 06/06/2018 at 17:52.
Pushed by vladz into branch 'master'.

FrameSvg: Recache maskFrame if enabledBorders has been changed

Summary:
In some cases, when rendering frame svg background, measures & margins
do not correspond to `enabledBorders`. I.e. `bottomHeight` may be equal to 5,
but the bottom border is disabled. This causes visual artifacts like this

{F5878318, layout=center, size=full}

//Pay close attention to the bottom of the Task switcher. It has a transparent
strip at the bottom, which shouldn't be there.//

The cause of this problem is that FrameSVGPrivate::alphaMask doesn't take
enabledBorders
into account when it's making decision whether it should update maskFrame.

Just for reference, this is "after"

{F5878319, layout=center, size=full}
Related: bug 382324, bug 391659

Test Plan:
* Triggered the Breeze task switcher (with compositing on and off)
* Didn't see any transparent strips

---

* Tried running FrameSvgTest, still passes

Reviewers: #plasma, #frameworks, mart

Reviewed By: #plasma, mart

Subscribers: abetts, mart, aseigo, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D13215

M  +16   -10   src/plasma/framesvg.cpp

https://commits.kde.org/plasma-framework/dce258bee3da854980b6f2430b26f7025752a505

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=390632

--- Comment #11 from Vlad Zagorodniy  ---
https://phabricator.kde.org/D13215

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=390632

--- Comment #10 from Vlad Zagorodniy  ---
I fixed it. I'll push fix soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=390632

Vlad Zagorodniy  changed:

   What|Removed |Added

   Assignee|k...@davidedmundson.co.uk|vladz...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[Alexander Mentyu]

https://bugs.kde.org/show_bug.cgi?id=390632

Alexander Mentyu  changed:

   What|Removed |Added

 CC||notux...@gmail.com

--- Comment #9 from Alexander Mentyu  ---
If Compositor is disabled - here are possibly related Panel bugs:
https://bugs.kde.org/show_bug.cgi?id=382324 
https://bugs.kde.org/show_bug.cgi?id=391659
https://bugs.kde.org/show_bug.cgi?id=389215
https://bugs.kde.org/show_bug.cgi?id=381574

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=390632

--- Comment #8 from Vlad Zagorodniy  ---
I hope it'll help somehow.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=390632

--- Comment #7 from Vlad Zagorodniy  ---
Dialog's blur region is set to a mask(I don't really know what it is and how it
is computed :(

https://github.com/KDE/plasma-framework/blob/master/src/plasmaquick/dialog.cpp#L245

And, in my case, the mask for task switcher is QRegion(size=2, bounds=(0,0
216x768) - [(0,0 216x758), (206,758 10x10)])

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=390632

--- Comment #6 from Vlad Zagorodniy  ---
KWin has nothing to do with this. For example, the blur effect gets the
following blur region 

QRegion(size=2, bounds=(0,0 216x768) - [(0,0 216x758), (206,758 10x10)])

You can clearly see that bottom part is omitted. (my screen resolution is
1366x768)

Anyway, after digging a little bit, I think these issues are (maybe) caused by
PlasmaCore.Dialog or dialogs/background.svgz.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=390632

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #5 from Nate Graham  ---
Notably, the gray bar is visible on the bottom even if the pop-up loads from
the side of the screen (e.g. if your panel is on the side).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=390632

--- Comment #4 from Vlad Zagorodniy  ---
Created attachment 111324
  --> https://bugs.kde.org/attachment.cgi?id=111324=edit
Digital clock/calendar also has transparent parts

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=390632

--- Comment #3 from Kai Uwe Broulik  ---
*** Bug 390831 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=390632

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=390632

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=390632

--- Comment #2 from Vlad Zagorodniy  ---
... So, who sets blur region?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=390632

--- Comment #1 from David Edmundson  ---
Technically this window is in kwin, but frame comes plasma stuff, so here
works.

We've got a  similar bug reported for panels. Potentially the same cause.

-- 
You are receiving this mail because:
You are watching all bug changes.