[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 Nate Graham changed: What|Removed |Added Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla |sma-framework/e2cd97d822d3c |sma-framework/144bb90715410 |96754c875a83a41276db6114347 |178dd8334a73841d287d729e41f --- Comment #29 from Nate Graham --- Git commit 144bb90715410178dd8334a73841d287d729e41f by Nate Graham, on behalf of Konstantin Lisin. Committed on 09/08/2019 at 02:33. Pushed by ngraham into branch 'master'. Fix incorrect initial tabs position for vertical tab bars Summary: This fixes the incorrect initial positioning of the tabs for vertical tab bars that persisted until the user switched to another tab manually. FIXED-IN: 5.62 Reviewers: #plasma, ngraham, hein Reviewed By: #plasma, ngraham, hein Subscribers: kde-frameworks-devel Tags: #frameworks Maniphest Tasks: T10047 Differential Revision: https://phabricator.kde.org/D23036 M +5-11 src/declarativeimports/plasmacomponents/qml/TabBar.qml https://commits.kde.org/plasma-framework/144bb90715410178dd8334a73841d287d729e41f -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 Nate Graham changed: What|Removed |Added Version Fixed In||5.62 Latest Commit||https://commits.kde.org/pla ||sma-framework/e2cd97d822d3c ||96754c875a83a41276db6114347 Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #28 from Nate Graham --- Git commit e2cd97d822d3c96754c875a83a41276db6114347 by Nate Graham. Committed on 09/08/2019 at 02:28. Pushed by ngraham into branch 'master'. Fix incorrect initial tabs position for vertical tab bars Summary: This fixes the incorrect initial positioning of the tabs for vertical tab bars that persisted until the user switched to another tab manually. FIXED-IN: 5.62 Reviewers: #plasma, ngraham, hein Reviewed By: #plasma, ngraham, hein Subscribers: kde-frameworks-devel Tags: #frameworks Maniphest Tasks: T10047 Differential Revision: https://phabricator.kde.org/D23036 M +5-11 src/declarativeimports/plasmacomponents/qml/TabBar.qml https://commits.kde.org/plasma-framework/e2cd97d822d3c96754c875a83a41276db6114347 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 --- Comment #27 from Nate Graham --- The patch was submitted on Phabricator: https://phabricator.kde.org/D22988 It's winding its way through the review process now :) -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 --- Comment #26 from Piotr Mierzwinski --- I can confirm that patch works. I mean that issue I reported here: Bug 396583 just disappeared. I followed for instruction placed here: https://gitlab.com/snippets/1882509 BTW. There is also thread on reddit mentioning about this issue: https://www.reddit.com/r/kde/comments/cm8bef/i_forked_kickoff_and_made_favorites_display_in_a/ -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 --- Comment #25 from Nate Graham --- Thanks very much! Looking at your patch, it seems like the changes to do round() instead of floor() are unrelated; if so, please omit them. Also code that's commented out should be deleted instead. After that, I would encourage you to submit your patch to https://phabricator.kde.org! Here's the documentation: https://community.kde.org/Infrastructure/Phabricator For reviewers, you can add #plasma, @hein, and @ngraham Looking forward to seeing it there! -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 cupn8d...@gmail.com changed: What|Removed |Added CC||cupn8d...@gmail.com --- Comment #24 from cupn8d...@gmail.com --- Created attachment 121955 --> https://bugs.kde.org/attachment.cgi?id=121955=edit Attempt to patch Hello! I have attempted to fix it, or at least some portions of it that I did reproduce. I'm not sure how correct the code is, but so far it's working fine on my laptop and desktop. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 --- Comment #23 from MitraX --- Still present, in Plasma v5.16.2. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 MitraX changed: What|Removed |Added Version|5.14.5 |5.16.2 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 Nate Graham changed: What|Removed |Added CC||ki...@vladimiroff.org --- Comment #22 from Nate Graham --- *** Bug 408648 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 Björn Feber changed: What|Removed |Added CC||febe...@gmail.com --- Comment #21 from Björn Feber --- Ping -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 HM changed: What|Removed |Added CC||mcmailf...@protonmail.com --- Comment #20 from HM --- I can confirm the bug on plasmashell 5.15.1. And although I remember this bug appearing only after I updated to a plasma version a while back, I unfortunately do not remember the version. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 --- Comment #18 from Piotr Mierzwinski --- (In reply to Dmitry Khlestkov from comment #17) > Piotr, > > how it is supposed to look like? I checked your original Bug 396583 and both > screenshots looks different from this one. I meant that whole window should have the same color like vertical button bar or don't have such contrast between body and vertical button bar. Just please take a look at attached (new) screen shot. > Anyway, I don't think I can help. You have to "play" with qml to find what > is working for you. I was playing a little bit just changing code you proposed. Unfortunately without success, because usually vertical buttons bar just disappeared after my changes. I will wait maybe somebody more experienced in qml will look at out issue. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 --- Comment #19 from Piotr Mierzwinski --- Created attachment 118260 --> https://bugs.kde.org/attachment.cgi?id=118260=edit my original look of KickOff -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 --- Comment #17 from Dmitry Khlestkov --- Piotr, how it is supposed to look like? I checked your original Bug 396583 and both screenshots looks different from this one. Anyway, I don't think I can help. You have to "play" with qml to find what is working for you. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 --- Comment #16 from Piotr Mierzwinski --- Created attachment 118236 --> https://bugs.kde.org/attachment.cgi?id=118236=edit Changed colors of KickOff after applying Dmiry fix -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390
--- Comment #15 from Piotr Mierzwinski ---
(In reply to Dmitry Khlestkov from comment #13)
> I'm using locally modified version of kickoff with this modifications for
> "left" orientation (ui/FullRepresentation.qml):
>
> AnchorChanges {
> target: tabBar
> anchors {
> left: root.left
> - top: root.top
> right: undefined
> bottom: header.top
> }
> }
>
> + PropertyChanges {
> + target: tabBar
> + height: units.gridUnit * 29
> + }
>
> E.g. anchors.top replaced with implicit height. Similar workaround may be
> applied to "right" orientation. Obviously height should be calculated from
> tab count instead of being hardcoded.
>
> Yes, this is not a proper fix but we can't be picky at this moment, can we?
> I've reported this issue 10 months ago and no one seems to have skills
> and/or resolve to fix it properly.
I applied your changes to the "right" orientation. Issue with disappearing
button seems to be fixed, but unfortunately body (place where I see for example
"All Applications") just changed color or actually became much brightest (looks
like all would be disabled) than right vertical bar with buttons. Note that in
original version color body and vertical bar are the same. I suppose this is
because of using "tabBar" in "PropertyChanges".
I use Breeze dark scheme and kvantum addon.
After changes I restarted plasmashell like this:
kbuildsycoca5 && kquitapp5 plasmashell && kstart5 plasmashell
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 --- Comment #14 from Dmitry Khlestkov --- > implicit height sorry, it is "explicit" -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390
--- Comment #13 from Dmitry Khlestkov ---
I'm using locally modified version of kickoff with this modifications for
"left" orientation (ui/FullRepresentation.qml):
AnchorChanges {
target: tabBar
anchors {
left: root.left
- top: root.top
right: undefined
bottom: header.top
}
}
+ PropertyChanges {
+ target: tabBar
+ height: units.gridUnit * 29
+ }
E.g. anchors.top replaced with implicit height. Similar workaround may be
applied to "right" orientation. Obviously height should be calculated from tab
count instead of being hardcoded.
Yes, this is not a proper fix but we can't be picky at this moment, can we?
I've reported this issue 10 months ago and no one seems to have skills and/or
resolve to fix it properly.
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 Piotr Mierzwinski changed: What|Removed |Added Version|5.13.0 |5.14.5 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 --- Comment #12 from David Edmundson --- >Here, visible: is used before it's set. No, QML is a declarative language not a programmatic one, there's no concept of order at this level. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390
Thomas Florenson changed:
What|Removed |Added
CC||thomas.florenson@gmx.fr
--- Comment #11 from Thomas Florenson ---
Hi!
For me this bug reeks of an init problem when the display is vertical. I
couldn't find where the horizontal/vertical properties are set in the kickoff
code but it's probably done in a more generic piece of code.
Anyway, browsing the source code in
https://cgit.kde.org/plasma-desktop.git/tree/applets/kickoff/package/contents/ui
I could find a suspicious function in KickoffItem.qml:
PlasmaCore.SvgItem {
id: arrow
anchors {
right: parent.right
rightMargin: units.gridUnit * 2
verticalCenter: parent.verticalCenter
}
width: visible ? units.iconSizes.small : 0
height: width
visible: (model.hasChildren == true)
opacity: (listItem.ListView.view.currentIndex == index) ? 1.0 : 0.4
svg: arrowsSvg
elementId: (Qt.application.layoutDirection == Qt.RightToLeft) ?
"left-arrow" : "right-arrow"
}
Here, visible: is used before it's set. Therefore, if it's been initialized to
false, the SvgItem will not be visible at the first call (the first item), but
visible on subsequent calls. Also the height and width properties will be 0,
which is consistent with the observed behavior (see picture by MitraX).
I would simply set visible: before width: and see if it corrects the problem.
Unfortunately I don't have KDE dev tools installed so it's a bother to test.
Would someone try it? Thanks!
NB: I don't use QML so my code reading might be wrong
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted
https://bugs.kde.org/show_bug.cgi?id=395390 Nate Graham changed: What|Removed |Added Summary|Favorites panel missing in |After making the default |KDE Application Launcher on |panel vertically-oriented, |first launch in vertically |Kickoff's layout is messed |oriented panel |up until plasmashell is ||restarted -- You are receiving this mail because: You are watching all bug changes.
