[plasmashell] [Bug 396666] Assert dragging desktop items
https://bugs.kde.org/show_bug.cgi?id=39 Marco Martin changed: What|Removed |Added Resolution|--- |DUPLICATE CC||notm...@gmail.com Status|CONFIRMED |RESOLVED --- Comment #6 from Marco Martin --- *** This bug has been marked as a duplicate of bug 421339 *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 396666] Assert dragging desktop items
https://bugs.kde.org/show_bug.cgi?id=39 Nate Graham changed: What|Removed |Added CC||n...@kde.org Status|REOPENED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 396666] Assert dragging desktop items
https://bugs.kde.org/show_bug.cgi?id=39 Tim Mason changed: What|Removed |Added CC||marv3...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 396666] Assert dragging desktop items
https://bugs.kde.org/show_bug.cgi?id=39 David Edmundson changed: What|Removed |Added CC||j...@ristioja.ee --- Comment #5 from David Edmundson --- *** Bug 400533 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 396666] Assert dragging desktop items
https://bugs.kde.org/show_bug.cgi?id=39 Gunter Ohrner changed: What|Removed |Added Status|RESOLVED|REOPENED CC||kdeb...@customcdrom.de Resolution|FIXED |--- --- Comment #4 from Gunter Ohrner --- According to the Plasma 5.13.5 changelog, this fix was reverted again in commit https://cgit.kde.org/plasma-desktop.git/commit/?id=f23b9dc0d57df80863e988208e60135a7f42ad12 So probably this issue should be reopened again? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 396666] Assert dragging desktop items
https://bugs.kde.org/show_bug.cgi?id=39 Eike Hein changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/pla ||sma-desktop/1cb71a2cca8a465 ||12f5ac0cb03da268dde8d9c7d Resolution|--- |FIXED --- Comment #3 from Eike Hein --- Git commit 1cb71a2cca8a46512f5ac0cb03da268dde8d9c7d by Eike Hein. Committed on 01/08/2018 at 10:43. Pushed by hein into branch 'Plasma/5.12'. Fix bad model hygiene in Positioner::move() Summary: Don't change the proxy maps prior to insert/remove transactions so rowCount() at transaction start time matches the count passed into the method. The old code hits an ASSERT in Qt 5.11 otherwise. Care is taken not to emit dataChanged() in the middle of another transaction. Also cleaned up vestiges of caching lastRow(): This cache was evicted all over the places but never actually filled anymore, so maybe we don't need it. Reviewers: davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D14243 M +32 -21 containments/desktop/plugins/folder/positioner.cpp M +0-2containments/desktop/plugins/folder/positioner.h https://commits.kde.org/plasma-desktop/1cb71a2cca8a46512f5ac0cb03da268dde8d9c7d -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 396666] Assert dragging desktop items
https://bugs.kde.org/show_bug.cgi?id=39 --- Comment #2 from Eike Hein --- Patch waiting for review for a few days: https://phabricator.kde.org/D14243 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 396666] Assert dragging desktop items
https://bugs.kde.org/show_bug.cgi?id=39
--- Comment #1 from David Edmundson ---
Pasting the code, though you'll see it yourself as soon as you open the file.
...do some changes
const int newCount = rowCount();
if (newCount > oldCount) {
...
beginInsertRows(QModelIndex(), oldCount, newCount - 1);
endInsertRows();
}
at the time of beginInsertRows rowCount must be the size it was before any
changes, with the correct value at the time of endInsertRows
This was always the case, but Qt5.11 now has an assert for it.
Whether this has any real impact on non dev builds I don't know, but given how
flaky QtQuick models can be, probably best to be as safe as possible.
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 396666] Assert dragging desktop items
https://bugs.kde.org/show_bug.cgi?id=39 David Edmundson changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
