[plasmashell] [Bug 405921] Plasma crashes when dragging task from taskmanager to a different virtual desktop
https://bugs.kde.org/show_bug.cgi?id=405921 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com Status|REOPENED|RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from Patrick Silva --- *** This bug has been marked as a duplicate of bug 415423 *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 405921] Plasma crashes when dragging task from taskmanager to a different virtual desktop
https://bugs.kde.org/show_bug.cgi?id=405921 --- Comment #10 from Franz Trischberger --- Yes, that fixes the issue. Please also close this issue: https://bugs.kde.org/show_bug.cgi?id=404909 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 405921] Plasma crashes when dragging task from taskmanager to a different virtual desktop
https://bugs.kde.org/show_bug.cgi?id=405921 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #9 from Kai Uwe Broulik --- Looks like Bug 415423 then, see https://cgit.kde.org/plasma-desktop.git/commit/?id=f5d1675a0dc1a1a0098eb5b1c727b5fe197e9930 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 405921] Plasma crashes when dragging task from taskmanager to a different virtual desktop
https://bugs.kde.org/show_bug.cgi?id=405921 --- Comment #8 from Franz Trischberger --- Christoph, it looks like it's the Pager. I just found out that the dragEnter event (and starting of the timer + changePage invocation with the bad index) is handled in a QML file "hidden" under the package structure. Likely the cause is there. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 405921] Plasma crashes when dragging task from taskmanager to a different virtual desktop
https://bugs.kde.org/show_bug.cgi?id=405921 --- Comment #7 from Christoph Feck --- If I understand comment 6 correctly, the issue is in the pager, not in the task manager, right? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 405921] Plasma crashes when dragging task from taskmanager to a different virtual desktop
https://bugs.kde.org/show_bug.cgi?id=405921
Franz Trischberger changed:
What|Removed |Added
Resolution|WORKSFORME |---
Status|RESOLVED|REOPENED
Ever confirmed|0 |1
--- Comment #6 from Franz Trischberger ---
I finally looked at the source code, and found the issue!
The root lies in the indexing of QList vs. virtual desktops. lists get indexed
starting from 0 while workspaces start from 1 (I am on X11).
The crash also doesn't happen in drag/dropping code but when the pager switches
to the VD you hover with the LMB still pressed (which happens after a certain
timeout).
I have 2 VDs configured.
Then look at this function:
void PagerModel::changePage(int page)
{
if (currentPage() == page) {
if (d->showDesktop) {
QDBusConnection::sessionBus().asyncCall(QDBusMessage::createMethodCall(QLatin1String("org.kde.plasmashell"),
QLatin1String("/PlasmaShell"),
QLatin1String("org.kde.PlasmaShell"),
QLatin1String("toggleDashboard")));
}
} else {
if (d->pagerType == VirtualDesktops) {
d->virtualDesktopInfo->requestActivate(d->virtualDesktopInfo->desktopIds().at(page));
/// here it crashes
} else {
const QStringList =
d->activityInfo->runningActivities();
if (page < runningActivities.length()) {
KActivities::Controller activitiesController;
activitiesController.setCurrentActivity(runningActivities.at(page));
}
}
}
}
That function gets a page and directly hands it down to QVariantList in the
marked line. From the callstack you can see that this function gets called with
page == 2. desktopIds().at(2) is one off the end resulting in an invalid
QVariant object.
I created a quick proof patch:
-
d->virtualDesktopInfo->requestActivate(d->virtualDesktopInfo->desktopIds().at(page));
+
d->virtualDesktopInfo->requestActivate(d->virtualDesktopInfo->desktopIds().at(page-1));
which fixes the crash when moving a task to a different desktop, the task lands
on the selected VD and the pager switches to it. Apperently changing VDs with a
click on the pager is broken with this patch.
I do not know the codebase where all those dragging and clicking events get
handled. But at least now the devs know how/where to fix it.
A quite tricky thing to handle is wayland. Here it looks like indices are
0-based (From the code handling is done with strings). With the patch applied
dragging from VD1 to VD2 now doesn't switch but call showDesktop on VD1 (which
is the active desktop)...
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 405921] Plasma crashes when dragging task from taskmanager to a different virtual desktop
https://bugs.kde.org/show_bug.cgi?id=405921 --- Comment #5 from Franz Fellner --- Created attachment 124856 --> https://bugs.kde.org/attachment.cgi?id=124856=edit New crash information added by DrKonqi plasmashell (5.17.4) using Qt 5.13.2 I am now at 5.17.4, this still happens - What I was doing when the application crashed: As before I tried to move a task to a different VT. If you can't reproduce just hesitate before dropping. It also crashes when you just hover the VT widget and slowly move the mouse, keeping the left mouse button pressed. -- Backtrace (Reduced): #7 0x7fdc7cc8d416 in qNumVariantToHelper (handlerManager=..., val=, ok=0x7ffdeb7d82df, d=...) at kernel/qvariant.cpp:3140 #8 0x7fdc7cc8d416 in QVariant::toInt(bool*) const (this=0x6e6f, ok=0x7ffdeb7d82df) at kernel/qvariant.cpp:3140 #9 0x7fdc7516f2a7 in TaskManager::VirtualDesktopInfo::XWindowPrivate::requestActivate(QVariant const&) (this=, desktop=...) at /var/tmp/portage/kde-plasma/plasma-workspace-5.17.4-r1/work/plasma-workspace-5.17.4/libtaskmanager/virtualdesktopinfo.cpp:172 #10 0x7fdc5e72cc17 in PagerModel::changePage(int) (this=, page=2) at /var/tmp/portage/kde-plasma/plasma-desktop-5.17.4-r1/work/plasma-desktop-5.17.4/applets/pager/plugin/pagermodel.cpp:566 #11 0x7fdc5e72dc24 in PagerModel::qt_metacall(QMetaObject::Call, int, void**) (this=0x2a47d50, _c=QMetaObject::InvokeMetaMethod, _id=12, _a=0x7ffdeb7d84c0) at applets/pager/pagerplugin_autogen/include/moc_pagermodel.cpp:354 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 405921] Plasma crashes when dragging task from taskmanager to a different virtual desktop
https://bugs.kde.org/show_bug.cgi?id=405921 Franz Fellner changed: What|Removed |Added CC||alpine.art...@googlemail.co ||m -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 405921] Plasma crashes when dragging task from taskmanager to a different virtual desktop
https://bugs.kde.org/show_bug.cgi?id=405921 Bug Janitor Service changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO |RESOLVED --- Comment #3 from Bug Janitor Service --- This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 405921] Plasma crashes when dragging task from taskmanager to a different virtual desktop
https://bugs.kde.org/show_bug.cgi?id=405921 --- Comment #2 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 405921] Plasma crashes when dragging task from taskmanager to a different virtual desktop
https://bugs.kde.org/show_bug.cgi?id=405921 Eike Hein changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED|NEEDSINFO --- Comment #1 from Eike Hein --- I can't reproduce this unortunately, does it still happen to you with 5.16.x? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 405921] Plasma crashes when dragging task from taskmanager to a different virtual desktop
https://bugs.kde.org/show_bug.cgi?id=405921 Christoph Feck changed: What|Removed |Added Component|general |Task Manager Assignee|k...@davidedmundson.co.uk|h...@kde.org -- You are receiving this mail because: You are watching all bug changes.
