[plasmashell] [Bug 407881] new notifications system does not work with Snap package of Discord

2019-05-29 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=407881

Kai Uwe Broulik  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.16.0
  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/17f1834e98ae0
   ||61226b10b572c4aeebcaca042bc

--- Comment #7 from Kai Uwe Broulik  ---
Git commit 17f1834e98ae061226b10b572c4aeebcaca042bc by Kai Uwe Broulik.
Committed on 29/05/2019 at 11:47.
Pushed by broulik into branch 'Plasma/5.16'.

[Notifications] Spawn new notification if one to replace doesn't exist

Since the Notification Server knows nothing about what notifications were sent,
it tells us a notification was replaced and
uses the ID supplied by the application. Only in the model we then realize it
didn't exist.
This means we will potentially reuse the notification ID sent by the
application as we just increment a counter.
However, in practice I haven't encountered this issue before (maybe we just
never noticed?) but I think this is an
acceptable workaround.
FIXED-IN: 5.16.0

Differential Revision: https://phabricator.kde.org/D21474

M  +2-0libnotificationmanager/notificationsmodel.cpp

https://commits.kde.org/plasma-workspace/17f1834e98ae061226b10b572c4aeebcaca042bc

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 407881] new notifications system does not work with Snap package of Discord

2019-05-28 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=407881

Kai Uwe Broulik  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #6 from Kai Uwe Broulik  ---
Thank you very much! From the output I can tell that it asks us to replace an
existing notification with ID 1767 with a new one. Testing suggests that when
replacing a non-existing notification we end up not displaying anything.

The notification spec isn't clear about how to deal with that situation but
given it describes it as "An optional ID of an existing notification that this
notification is intended to replace." and the fact that it previously worked,
I'll adjust our system to just add a new notification in this case. This is
still an application bug imho as I have never seen any application do that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 407881] new notifications system does not work with Snap package of Discord

2019-05-28 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=407881

--- Comment #5 from Patrick Silva  ---
Created attachment 120360
  --> https://bugs.kde.org/attachment.cgi?id=120360&action=edit
full output of dbus-monitor

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 407881] new notifications system does not work with Snap package of Discord

2019-05-26 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=407881

--- Comment #4 from Nate Graham  ---
(In reply to Kai Uwe Broulik from comment #3)
> The file is cut off at the top, you might want to redirect the output of
> dbus-monitor directly into a file.
Here's how to do that:

dbus-monitor interface=org.freedesktop.Notifications >> ~/log.txt

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 407881] new notifications system does not work with Snap package of Discord

2019-05-26 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=407881

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 407881] new notifications system does not work with Snap package of Discord

2019-05-23 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=407881

--- Comment #3 from Kai Uwe Broulik  ---
The file is cut off at the top, you might want to redirect the output of
dbus-monitor directly into a file.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 407881] new notifications system does not work with Snap package of Discord

2019-05-23 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=407881

--- Comment #2 from Patrick Silva  ---
Created attachment 120277
  --> https://bugs.kde.org/attachment.cgi?id=120277&action=edit
output of dbus-monitor

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 407881] new notifications system does not work with Snap package of Discord

2019-05-23 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=407881

--- Comment #1 from Kai Uwe Broulik  ---
Can you monitor notification dbus traffic and see what it does?

dbus-monitor interface=org.freedesktop.Notifications

Also, run plasma from console, enabling notification logging 

QT_LOGGING_RULES=org.kde.plasma.notifications=true plasmashell

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 407881] new notifications system does not work with Snap package of Discord

2019-05-23 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=407881

Patrick Silva  changed:

   What|Removed |Added

Summary|new noticiations system |new notifications system
   |does not work with Snap |does not work with Snap
   |package of Discord  |package of Discord

-- 
You are receiving this mail because:
You are watching all bug changes.