[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 Konrad Materka changed: What|Removed |Added Status|CONFIRMED |RESOLVED Version Fixed In||5.18.0 Resolution|--- |FIXED Latest Commit||https://commits.kde.org/pla ||sma-workspace/31303ad3542b6 ||d05537b733e08857c43622ecc93 --- Comment #19 from Konrad Materka --- Git commit 31303ad3542b6d05537b733e08857c43622ecc93 by Konrad Materka. Committed on 03/02/2020 at 15:57. Pushed by kmaterka into branch 'Plasma/5.18'. [SNI] Fix race condition in item registration Summary: If StatusNotifierItem is registered and then immediately destroyed, it is possible that QDBusServiceWatcher will not emit the serviceUnregistered signal. Add an additional check to avoid such situations. FIXED-IN: 5.18.0 Test Plan: Telegram should not add empty items. Reviewers: #plasma_workspaces, #plasma, davidedmundson Reviewed By: #plasma_workspaces, #plasma, davidedmundson Subscribers: davidedmundson, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D27126 M +11 -7statusnotifierwatcher/statusnotifierwatcher.cpp https://commits.kde.org/plasma-workspace/31303ad3542b6d05537b733e08857c43622ecc93 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 --- Comment #18 from Konrad Materka --- Fix: https://phabricator.kde.org/D27126 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 --- Comment #17 from Konrad Materka --- Found it! On start Telegram opens microphone, but only for a very short moment. This is detected by microphone indicator and notify icon is automatically created. Immediately after that indicator icon is destroyed, before StatusNotifierWatcher is able to detect that (race condition). -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652
Konrad Materka changed:
What|Removed |Added
Attachment #125539|0 |1
is obsolete||
Attachment #125540|0 |1
is obsolete||
--- Comment #16 from Konrad Materka ---
Created attachment 125558
--> https://bugs.kde.org/attachment.cgi?id=125558=edit
session bus monitor logs (cleared)
My investigation:
There are 3 parties involved:
:1.10 = org.kde.StatusNotifierWatcher
:1.33 = org.freedesktop.Notifications = com.canonical.Unity = plasmashell
:1.763 - Telegram
Tray icon is created twice:
> Sender=:1.33 Destination=org.kde.StatusNotifierWatcher
> Path=/StatusNotifierWatcher Interface=org.kde.StatusNotifierWatcher
> Member=RegisterStatusNotifierItem -> ":1.765"
> Sender=:1.763 Destination=org.kde.StatusNotifierWatcher
> Path=/StatusNotifierWatcher Interface=org.kde.StatusNotifierWatcher
> Member=RegisterStatusNotifierItem -> ":1.766"
The ":1.765" is immediately destroyed. I was able to observe similar behavior
with snap package on my computer to.
There is a race condition, if service is destroyed too soon,
StatusNotifierWatcher can't notice it. From StatusNotifierWatcher cpp:
//check if the service has registered a SystemTray object
org::kde::StatusNotifierItem trayclient(service, path,
QDBusConnection::sessionBus());
if (trayclient.isValid()) { // it exists here
m_registeredServices.append(notifierItemId); // it dies here
m_serviceWatcher->addWatchedService(service); // it is dead by now, no
chance to get notification
emit StatusNotifierItemRegistered(notifierItemId);
}
Race condition is a problem on it's own, but bigger issue is: why plasmashell
is creating SNI? For a brief moment there a SNI object with hidden menu with
only one item: toggled checkbox.
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 Konrad Materka changed: What|Removed |Added Resolution|DOWNSTREAM |--- Ever confirmed|0 |1 Status|RESOLVED|REOPENED -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 Konrad Materka changed: What|Removed |Added Status|REOPENED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 --- Comment #15 from hexchain --- Created attachment 125540 --> https://bugs.kde.org/attachment.cgi?id=125540=edit wireshark dbus-session capture This is another try. Relevant syslog: After starting Telegram: > kded5[1952]: Registering ":1.840/StatusNotifierItem" to system tray > kded5[1952]: Registering ":1.841/StatusNotifierItem" to system tray > kded5[1952]: Service ":1.841" unregistered > kded5[1952]: Registering ":1.842/StatusNotifierItem" to system tray And after quitting: > kded5[1952]: Service ":1.842" unregistered This time I have wireshark listening on dbus-session. The attached capture file is filtered with: > dbus.value.str contains ":1.84" -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 --- Comment #14 from hexchain --- Created attachment 125539 --> https://bugs.kde.org/attachment.cgi?id=125539=edit session bus monitor logs I have encountered this problem again today, with telegram-desktop 1.9.9-1 on Arch Linux. Some system logs after starting Telegram: > kded5[1952]: Registering ":1.765/StatusNotifierItem" to system tray > kded5[1952]: Registering ":1.766/StatusNotifierItem" to system tray And after quitting Telegram (tray icon right click -> Quit): > kded5[1952]: Service ":1.766" unregistered I have managed to reproduce the problem with `busctl --user monitor` running. The log file is attached. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 Konrad Materka changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |DOWNSTREAM --- Comment #13 from Konrad Materka --- (In reply to hexchain from comment #12) > Telegram desktop client used to require lots of patches to work with system > libraries. After 1.9.4, there are some build options to make it link to the > system libraries so the patches are no longer required. As a result, some > large chunks of code may get disabled/enabled, which may affect its SNI > behavior. Yes, this might be related, definitely. I'm closing this. Feel free to reopen if it happens again. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 --- Comment #12 from hexchain --- (In reply to Konrad Materka from comment #11) > I'm not so familiar with DBus and StatusNotifierWatcher, but it looks that > everything is OK on KDE side. It uses QDBusServiceWatcher to watch for > service unregistration. There is a small possibility that > QDBusServiceWatcher has a bug (unlikely) but most probably it was a bug in > Telegram. I quickly checked Telegrams commit log, there was some work > related to DBus, but for notifications, including > https://blog.broulik.de/2020/01/venturing-out/ :) > If you would like to, you could probably also check out https://git.archlinux.org/svntogit/community.git/log/trunk?h=packages/telegram-desktop. Telegram desktop client used to require lots of patches to work with system libraries. After 1.9.4, there are some build options to make it link to the system libraries so the patches are no longer required. As a result, some large chunks of code may get disabled/enabled, which may affect its SNI behavior. > If everything is ok now, I would close it. I'm not against it. I'll report back if anything new happens. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 --- Comment #11 from Konrad Materka --- I'm not so familiar with DBus and StatusNotifierWatcher, but it looks that everything is OK on KDE side. It uses QDBusServiceWatcher to watch for service unregistration. There is a small possibility that QDBusServiceWatcher has a bug (unlikely) but most probably it was a bug in Telegram. I quickly checked Telegrams commit log, there was some work related to DBus, but for notifications, including https://blog.broulik.de/2020/01/venturing-out/ :) If everything is ok now, I would close it. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 --- Comment #10 from Nate Graham --- So this fixed itself? Is there anything we could conceivably fix here, Konrad? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 --- Comment #9 from hexchain --- I have not seen any new empty items for several days. Looking at the log I suspect the empty items belong to Telegram prior to 1.9.3-1 (Arch package), because all dbus IDs of the stale items are registered before upgrading from that version, and after starting Telegram (supposedly) each time. However, there are big changes between 1.9.3-1 and 1.9.4-2 so I couldn't really tell what has fixed the problem. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 --- Comment #8 from Konrad Materka --- There are some "ghost" items in StatusNotifierWatcher. After restart/log out they should disappear. It is hard to tell what is causing this, probably some app is registering notification icons and removal is not notified correctly by the app. Or there is a bug in StatusNotifierWatcher and some items are not removed even if StatusNotifierWatcher is notified to remove them. Really hard to tell... -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 --- Comment #7 from hexchain --- Somehow those empty icons disappeared, probably because I logged out once? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 --- Comment #6 from hexchain --- Created attachment 125361 --> https://bugs.kde.org/attachment.cgi?id=125361=edit Script output The output of the script is attached. The number of non-exist names is the same as the number of empty items. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652
--- Comment #5 from Konrad Materka ---
Created attachment 125360
--> https://bugs.kde.org/attachment.cgi?id=125360=edit
Script to list all Status Notifier Icons
Both "hidden items" and "Entries configuration" are using the same data source,
but entirely different rendering and model. I guess that these empty items are
in the data source. Maybe something is polluting DBus service
("/StatusNotifierWatcher").
Can you use attached script to list all registered icons directly from the DBus
service?
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 --- Comment #4 from hexchain --- (In reply to Nate Graham from comment #3) > If you click on them, are they real? Or does nothing happen? Nothing happens. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 Nate Graham changed: What|Removed |Added Keywords||regression CC||mate...@gmail.com, ||n...@kde.org --- Comment #3 from Nate Graham --- If you click on them, are they real? Or does nothing happen? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 --- Comment #1 from hexchain --- Created attachment 125330 --> https://bugs.kde.org/attachment.cgi?id=125330=edit Empty items in configuration -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 416652] Empty items in system tray area
https://bugs.kde.org/show_bug.cgi?id=416652 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #2 from Kai Uwe Broulik --- Yeah I have noticed the same but also failed to find a pattern. -- You are receiving this mail because: You are watching all bug changes.
