[plasmashell] [Bug 419853] Panel and panel widgets are too easy to accidentally delete
https://bugs.kde.org/show_bug.cgi?id=419853 Rik Mills changed: What|Removed |Added CC||rikmi...@kde.org --- Comment #13 from Rik Mills --- (In reply to Nate Graham from comment #10) > Currently that'll be up to whether the Kubuntu people decide to cherry-pick > the change, as Kubuntu will ship with Plasma 5.18 and the patch is targeted > for Plasma 5.19 because it changes the UI. > > It's possible that this could be considered a bugfix as it doesn't add any > new strings, in which case it can land for a 5.18 bugfix release, which > would get it into Kubuntu with no extra packaging necessary. I can see about > that. I certainly can't cherry pick what is arguably a UI feature change this late for 20.04. It is also somewhat doubtful that this would be acceptable as a 'bugfix' for the 5.18.5 SRU update in a few weeks. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 419853] Panel and panel widgets are too easy to accidentally delete
https://bugs.kde.org/show_bug.cgi?id=419853
Nate Graham changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Version Fixed In||5.18.5
Latest Commit||https://commits.kde.org/pla
||sma-desktop/ba66d2eabe38bc3
||57d799bff391cf5edbce139c0
Resolution|--- |FIXED
--- Comment #12 from Nate Graham ---
Git commit ba66d2eabe38bc357d799bff391cf5edbce139c0 by Nate Graham.
Committed on 13/04/2020 at 17:05.
Pushed by ngraham into branch 'Plasma/5.18'.
Make accidental panel and panel widget deletion more difficult
Summary:
We make it very easy to delete panels and panel widgets--perhaps a bit too
easy. User
feedback has indicated that we may need to re-work this a bit, and that perhaps
D20144 was a
mistake.
This patch moves the {nav Remove Panel} button back into the {nav More} menu
where it used to
be, to make it harder to accidentally click on. It also moves the {nav Remove}
button for
panel widgets higher up in the menu so it's not so close to the cursor.
To adjust to these changes, the layout of buttons on the panel toolbar is
changed to
preserve visual balance, and the {nav More} menu's name is adjusted to reflect
the fact that
removing a panel is not a setting.
FIXED-IN: 5.18.5
Test Plan: {F8227561}
Reviewers: #vdg, #plasma, ndavis
Reviewed By: #vdg, ndavis
Subscribers: rikmills, broulik, plasma-devel
Tags: #plasma
Maniphest Tasks: T12942
Differential Revision: https://phabricator.kde.org/D28710
M +20 -2containments/panel/contents/ui/ConfigOverlay.qml
M +19 -0
desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
M +15 -26
desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml
https://commits.kde.org/plasma-desktop/ba66d2eabe38bc357d799bff391cf5edbce139c0
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 419853] Panel and panel widgets are too easy to accidentally delete
https://bugs.kde.org/show_bug.cgi?id=419853 --- Comment #11 from gust...@angulosolido.pt --- I think Kubuntu 20.04 will be a reference release for KDE, and therefore preventing accidental misconfigurations is important. Furthermore the UI changes that removed Lock/Unlock widgets are not minor and were done so near the release date that I think the changes now introduced by your patch are quite justifiable. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 419853] Panel and panel widgets are too easy to accidentally delete
https://bugs.kde.org/show_bug.cgi?id=419853 --- Comment #10 from Nate Graham --- Currently that'll be up to whether the Kubuntu people decide to cherry-pick the change, as Kubuntu will ship with Plasma 5.18 and the patch is targeted for Plasma 5.19 because it changes the UI. It's possible that this could be considered a bugfix as it doesn't add any new strings, in which case it can land for a 5.18 bugfix release, which would get it into Kubuntu with no extra packaging necessary. I can see about that. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 419853] Panel and panel widgets are too easy to accidentally delete
https://bugs.kde.org/show_bug.cgi?id=419853 --- Comment #9 from gust...@angulosolido.pt --- Thanks again Nate. Any idea if this this be on time for Kubuntu 20.04? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 419853] Panel and panel widgets are too easy to accidentally delete
https://bugs.kde.org/show_bug.cgi?id=419853 --- Comment #8 from Nate Graham --- Changed in the patch. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 419853] Panel and panel widgets are too easy to accidentally delete
https://bugs.kde.org/show_bug.cgi?id=419853 --- Comment #7 from Nate Graham --- Oh duh, good point. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 419853] Panel and panel widgets are too easy to accidentally delete
https://bugs.kde.org/show_bug.cgi?id=419853 --- Comment #6 from gust...@angulosolido.pt --- @Nate, Great work on the submitted patch. I just want to note that inside the "More options" menu the "Remove panel" option is still the nearest one to the mouse cursor. Maybe it could be not the first? (just a suggestion). However it turns out, it is fore sure a great improvement over the current situation. Thanks again. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 419853] Panel and panel widgets are too easy to accidentally delete
https://bugs.kde.org/show_bug.cgi?id=419853 --- Comment #5 from Nate Graham --- Patch submitted: https://phabricator.kde.org/D28710 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 419853] Panel and panel widgets are too easy to accidentally delete
https://bugs.kde.org/show_bug.cgi?id=419853 Nate Graham changed: What|Removed |Added Assignee|plasma-b...@kde.org |n...@kde.org Status|CONFIRMED |ASSIGNED --- Comment #4 from Nate Graham --- Working on this. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 419853] Panel and panel widgets are too easy to accidentally delete
https://bugs.kde.org/show_bug.cgi?id=419853 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Keywords||usability Summary|panel too easy to |Panel and panel widgets are |misconfigure|too easy to accidentally ||delete Status|REPORTED|CONFIRMED CC||n...@kde.org --- Comment #3 from Nate Graham --- Those are very reasonable concerns and suggestions IMO. -- You are receiving this mail because: You are watching all bug changes.
