[plasmashell] [Bug 427122] Option to focus unfocused, un-grouped task on scroll

2021-04-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=427122

--- Comment #5 from Nate Graham  ---
Now that you've got a preliminary patch, I would recommend submitting it! It's
okay if it's not perfect, but it's much easier to do code review on GitLab than
here in the bug report. :) Here's the documentation:
https://community.kde.org/Infrastructure/GitLab

Make sure to add 

BUG 427122

to the commit message on its own line.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 427122] Option to focus unfocused, un-grouped task on scroll

2021-04-08 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=427122

--- Comment #4 from ircha...@airmail.cc ---
Created attachment 137444
  --> https://bugs.kde.org/attachment.cgi?id=137444&action=edit
patch to change the behavior

(In reply to Nate Graham from comment #3)
> Probably applets/taskmanager/package/contents/ui/code/tools.js in the
> plasma-desktop repo, but I'm not 100% sure.

It indeed was, I had a lot of trouble navigating the code, here's a pretty bad
hack that works for what I wanted. This should be taken into account:

-If you scroll on empty space that belongs to the applet, or on a pinned but
unopened program, it will still scroll to the next-previous program (I'd rather
it did nothing in those scenarios, but can't really be bothered).
-I think said scrolling might have been reverted compared to how it would
normally work.

If someone else wants to do something t hat isn't a complete hack, take into
account that: 
-"anchor" represents the program we're scrolling over.
-tasksModel.requestActivate(target) is what actually sets the focus.
-and target is an element of the array taskIndexList.

I couldn't find a better way to find the position of anchor in TaskIndexList so
I used "pushCounter".

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 427122] Option to focus unfocused, un-grouped task on scroll

2021-04-08 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=427122

--- Comment #3 from Nate Graham  ---
Probably applets/taskmanager/package/contents/ui/code/tools.js in the
plasma-desktop repo, but I'm not 100% sure.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 427122] Option to focus unfocused, un-grouped task on scroll

2021-04-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=427122

--- Comment #2 from ircha...@airmail.cc ---
Where is the relevant code for this? I downloaded plasma-desktop's code, and
checked icontasks, also checked tasksmanager but couldn't find something
directly related.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 427122] Option to focus unfocused, un-grouped task on scroll

2021-04-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=427122

Nate Graham  changed:

   What|Removed |Added

 CC||ga...@splitter.hu

--- Comment #1 from Nate Graham  ---
*** Bug 429525 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 427122] Option to focus unfocused, un-grouped task on scroll

2020-09-29 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=427122

Nate Graham  changed:

   What|Removed |Added

Summary|Have more consistent|Option to focus unfocused,
   |behavior for the|un-grouped task on scroll
   |scroll-wheel pm the |
   |icons-only task manager |
   Severity|minor   |wishlist
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.