[plasmashell] [Bug 437105] Whole system tray is highlighted with a blue line after enabling/disabling "Keep open" feature of active applet

2021-05-24 Thread Konrad Materka
https://bugs.kde.org/show_bug.cgi?id=437105

--- Comment #6 from Konrad Materka  ---
(In reply to Nate Graham from comment #5)
> Git commit 1ce09dcfcb78198c95a94bf4d6f75a49c2b77dc0 by Nate Graham, on
> behalf of Konrad Materka.
> Pushed by ngraham into branch 'Plasma/5.22'.

Thank you, Nate!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 437105] Whole system tray is highlighted with a blue line after enabling/disabling "Keep open" feature of active applet

2021-05-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=437105

Nate Graham  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/
   |07b3b10de7d09b8918bd237cf0e |1ce09dcfcb78198c95a94bf4d6f
   |ca9d3fe868c64   |75a49c2b77dc0

--- Comment #5 from Nate Graham  ---
Git commit 1ce09dcfcb78198c95a94bf4d6f75a49c2b77dc0 by Nate Graham, on behalf
of Konrad Materka.
Committed on 24/05/2021 at 16:23.
Pushed by ngraham into branch 'Plasma/5.22'.

[applets/systemtray] Fix highlight on applet pin

Sometimes parent component on the applet is not fully updated - for
example effectiveStatus is not yet read from the model. In such case it
will have default value leading to undesired effect.

Call all `updateHighlightedItem` in `Qt.callLater` so that it is called
in next event loop. As a bonus it is called only once, which can improve
performance.
FIXED-IN: 5.22.0


(cherry picked from commit 07b3b10de7d09b8918bd237cf0eca9d3fe868c64)

M  +6-6applets/systemtray/package/contents/ui/CurrentItemHighLight.qml

https://invent.kde.org/plasma/plasma-workspace/commit/1ce09dcfcb78198c95a94bf4d6f75a49c2b77dc0

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 437105] Whole system tray is highlighted with a blue line after enabling/disabling "Keep open" feature of active applet

2021-05-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=437105

Nate Graham  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.22.0
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/commit/
   ||07b3b10de7d09b8918bd237cf0e
   ||ca9d3fe868c64
 Resolution|--- |FIXED

--- Comment #4 from Nate Graham  ---
Git commit 07b3b10de7d09b8918bd237cf0eca9d3fe868c64 by Nate Graham, on behalf
of Konrad Materka.
Committed on 24/05/2021 at 16:06.
Pushed by ngraham into branch 'master'.

[applets/systemtray] Fix highlight on applet pin

Sometimes parent component on the applet is not fully updated - for
example effectiveStatus is not yet read from the model. In such case it
will have default value leading to undesired effect.

Call all `updateHighlightedItem` in `Qt.callLater` so that it is called
in next event loop. As a bonus it is called only once, which can improve
performance.
FIXED-IN: 5.22.0

M  +6-6applets/systemtray/package/contents/ui/CurrentItemHighLight.qml

https://invent.kde.org/plasma/plasma-workspace/commit/07b3b10de7d09b8918bd237cf0eca9d3fe868c64

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 437105] Whole system tray is highlighted with a blue line after enabling/disabling "Keep open" feature of active applet

2021-05-21 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=437105

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #3 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/876

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 437105] Whole system tray is highlighted with a blue line after enabling/disabling "Keep open" feature of active applet

2021-05-21 Thread Konrad Materka
https://bugs.kde.org/show_bug.cgi?id=437105

--- Comment #2 from Konrad Materka  ---
(In reply to Nate Graham from comment #1)
> Can reproduce, but maybe this is actually intentional? Konrad?

This is unintentional. It must be corner case in another corner case that was
fixed :/ I need to check it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 437105] Whole system tray is highlighted with a blue line after enabling/disabling "Keep open" feature of active applet

2021-05-18 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=437105

Nate Graham  changed:

   What|Removed |Added

Version|5.21.4  |5.21.90
 Ever confirmed|0   |1
 CC||n...@kde.org
 Status|REPORTED|CONFIRMED

--- Comment #1 from Nate Graham  ---
Can reproduce, but maybe this is actually intentional? Konrad?

-- 
You are receiving this mail because:
You are watching all bug changes.