[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-07-18 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438178

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In|5.24|5.26
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #23 from Nate Graham  ---
Also cannot reproduce. Likely it got fixed by the panel refactor, or Ivan's
widget popup work. Awesome!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-07-18 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=438178

--- Comment #22 from guimarcalsi...@gmail.com ---
I'm not seeing this glitch anymore as of the last few updates to Neon Unstable
(tested with X and Wayland). Can anyone with an updated Plasma confirm the bug
is solved?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-04-02 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=438178

--- Comment #21 from guimarcalsi...@gmail.com ---
I have an update on this bug. I know this is a very minor bug but small
glitches like these are really bad for first impressions, so I'm trying to find
clues as to what is happening.

I noticed that if you set a color scheme that doesn't set a header color, like
Breeze Classic, the bug goes away completely. The act of coloring the header
must be causing this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-03-27 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=438178

--- Comment #20 from guimarcalsi...@gmail.com ---
I noticed another thing about this bug. As commented earlier, if you make the
panel opaque it goes away, however, if you log in again the glitch still
happens even if the panel is still set to opaque. Somehow changing the
transparency fixes the bug temporarily but it's not the transparency itself
that causes the problem. I'm just speculating, but maybe changing the
transparency setting resets something until you start a new session.

I also noticed that in applets with a checkbox, like Bluetooth, Battery, and
Notifications, the glitch stays on screen until you interact with the applet,
while on the ones with an input field like Clipboard or Network it disappears
after a second. You can see that by making all applets visible and clicking on
them. This behavior is pretty consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-01-27 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438178

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED

--- Comment #19 from Nate Graham  ---
I can see now that you're right. I think my fix was not wrong, but not
sufficient. I'll have a closer look.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-01-27 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=438178

guimarcalsi...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #18 from guimarcalsi...@gmail.com ---
I'll be reopening this bug since it's not fixed yet.

I also noticed the glitch in the network applet doesn't disappear after a
second like before the patch. Since your patch made the behavior change I
believe it changed something important.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-01-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=438178

--- Comment #17 from guimarcalsi...@gmail.com ---
Created attachment 145759
  --> https://bugs.kde.org/attachment.cgi?id=145759=edit
I made a short video showing what it is like now.

I made a short video showing what it is like now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-01-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=438178

--- Comment #16 from guimarcalsi...@gmail.com ---
(In reply to Nate Graham from comment #15)
> Is it possible you're seeing a slightly different visual glitch from the one
> that was fixed here? There might be more things to fix beyond just the
> single narrowly targeted fix I implemented.

It's the same glitch. The only difference is that now the glitch disappears
after a second on the clipboard applet just like it did before on the network
one. Before your fix, it would linger there until hovering the mouse over the
clipboard applet.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-01-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438178

--- Comment #15 from Nate Graham  ---
Is it possible you're seeing a slightly different visual glitch from the one
that was fixed here? There might be more things to fix beyond just the single
narrowly targeted fix I implemented.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-01-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=438178

--- Comment #14 from guimarcalsi...@gmail.com ---
I see a fix was merged two days ago, but I can still see the bug on Neon
Unstable with the latest updates. The version of plasma-workspace I have is
4:5.23.5+p20.04+tunstable+git20220122.0442-0

I assume that's the latest version, no?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-01-19 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=438178

guimarcalsi...@gmail.com changed:

   What|Removed |Added

 CC||pos...@posteo.eu

--- Comment #13 from guimarcalsi...@gmail.com ---
*** Bug 445660 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-01-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438178

Nate Graham  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/
   |17a189405f5b19e1a8bf2499ff3 |4f6c096beebad435bcc9857e73b
   |34ce525503634   |de32755cf5de6

--- Comment #12 from Nate Graham  ---
Git commit 4f6c096beebad435bcc9857e73bde32755cf5de6 by Nate Graham.
Committed on 19/01/2022 at 18:29.
Pushed by ngraham into branch 'Plasma/5.24'.

applets/systemtray: fix glitch for some applets with headers

PlasmoidPopupsContainer.qml has special code to handle merging headers
from applets if those applets use a PlasmaComponents3.Page instance as
their FullRepresentation. However this breaks for any applets that use
PlasmaExtras.Representation, which is a subclass of it that we have been
porting applets to over time, because it offers more features in a
single location. This caused the detection to break, so such applets
woudl have their headers improperly merged.

Explicitly detecting the use of PlasmaExtras.Representation as well
fixes it.
FIXED-IN: 5.24


(cherry picked from commit 7221ffd1a9aeeae52467ac4b3bc3a5bfcde7a500)

M  +2-1   
applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

https://invent.kde.org/plasma/plasma-workspace/commit/4f6c096beebad435bcc9857e73bde32755cf5de6

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-01-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438178

Nate Graham  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/
   |7221ffd1a9aeeae52467ac4b3bc |17a189405f5b19e1a8bf2499ff3
   |3a5bfcde7a500   |34ce525503634

--- Comment #11 from Nate Graham  ---
Git commit 17a189405f5b19e1a8bf2499ff334ce525503634 by Nate Graham.
Committed on 19/01/2022 at 18:29.
Pushed by ngraham into branch 'cherry-pick-7221ffd1'.

applets/systemtray: fix glitch for some applets with headers

PlasmoidPopupsContainer.qml has special code to handle merging headers
from applets if those applets use a PlasmaComponents3.Page instance as
their FullRepresentation. However this breaks for any applets that use
PlasmaExtras.Representation, which is a subclass of it that we have been
porting applets to over time, because it offers more features in a
single location. This caused the detection to break, so such applets
woudl have their headers improperly merged.

Explicitly detecting the use of PlasmaExtras.Representation as well
fixes it.
FIXED-IN: 5.24


(cherry picked from commit 7221ffd1a9aeeae52467ac4b3bc3a5bfcde7a500)

M  +2-1   
applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

https://invent.kde.org/plasma/plasma-workspace/commit/17a189405f5b19e1a8bf2499ff334ce525503634

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-01-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438178

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/commit/
   ||7221ffd1a9aeeae52467ac4b3bc
   ||3a5bfcde7a500
 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.24

--- Comment #10 from Nate Graham  ---
Git commit 7221ffd1a9aeeae52467ac4b3bc3a5bfcde7a500 by Nate Graham.
Committed on 19/01/2022 at 18:06.
Pushed by ngraham into branch 'master'.

applets/systemtray: fix glitch for some applets with headers

PlasmoidPopupsContainer.qml has special code to handle merging headers
from applets if those applets use a PlasmaComponents3.Page instance as
their FullRepresentation. However this breaks for any applets that use
PlasmaExtras.Representation, which is a subclass of it that we have been
porting applets to over time, because it offers more features in a
single location. This caused the detection to break, so such applets
woudl have their headers improperly merged.

Explicitly detecting the use of PlasmaExtras.Representation as well
fixes it.
FIXED-IN: 5.24

M  +2-1   
applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

https://invent.kde.org/plasma/plasma-workspace/commit/7221ffd1a9aeeae52467ac4b3bc3a5bfcde7a500

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-01-19 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=438178

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #9 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1379

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-01-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438178

--- Comment #8 from Nate Graham  ---
Found the bug, submitting a fix shortly.

Behold, the power of a 100% reproducible issue. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-01-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438178

--- Comment #7 from Nate Graham  ---
Another interesting data point: the Networks applet suffers from it, but the
glitch goes away automatically as soon as the network list updates. Seems like
the initial state of something isn't set properly, but it has a binding that
makes it get reset properly when the applet refreshes or something.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438178] Visual glitch when pressing the back button in System Tray applets with a header when using a bottom panel in transparent mode

2022-01-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438178

Nate Graham  changed:

   What|Removed |Added

Summary|Visual glitch when pressing |Visual glitch when pressing
   |the back button in the  |the back button in System
   |System Tray when using a|Tray applets with a header
   |bottom panel in transparent |when using a bottom panel
   |mode|in transparent mode

-- 
You are receiving this mail because:
You are watching all bug changes.