[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-17 Thread Andrey
https://bugs.kde.org/show_bug.cgi?id=438648

--- Comment #15 from Andrey  ---
Could you check if you can center the label with this patch?
We can't test on HiDPI currently..
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/502

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-17 Thread ChronosX88
https://bugs.kde.org/show_bug.cgi?id=438648

--- Comment #14 from ChronosX88  ---
(In reply to Andrey from comment #5)
> We are about to revert this, but have alternative solution.  
> Still, the roots of the problem is not clear, so please help us reproduce it:
> is you display HiDPI, does it happen on new user with default settings,
> panel size etc.?
> Thanks.

Yes, I have HiDPI displays (both - laptop and external screen).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-17 Thread ChronosX88
https://bugs.kde.org/show_bug.cgi?id=438648

--- Comment #13 from ChronosX88  ---
(In reply to Andrey from comment #12)
> So can you make it look good somehow then?
> Maybe you have set another font or resized panel that is why it's always
> broken for you now.
> AFAIK, on our side it looks good with that tick set.

No, I tried everything, it is still doesn't look good.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-17 Thread Andrey
https://bugs.kde.org/show_bug.cgi?id=438648

--- Comment #12 from Andrey  ---
So can you make it look good somehow then?
Maybe you have set another font or resized panel that is why it's always broken
for you now.
AFAIK, on our side it looks good with that tick set.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-17 Thread ChronosX88
https://bugs.kde.org/show_bug.cgi?id=438648

--- Comment #11 from ChronosX88  ---
(In reply to ChronosX88 from comment #10)
> (In reply to Andrey from comment #9)
> > I suppose you didn't have "resize icons by panel height" tick set in systray
> > settings?
> 
> That setting is ticked in systray settings, but it doesn't have effect on
> keyboard layout switcher indicator.

By "doesn't  have effect" I mean indicator is still centered incorrectly.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-17 Thread ChronosX88
https://bugs.kde.org/show_bug.cgi?id=438648

--- Comment #10 from ChronosX88  ---
(In reply to Andrey from comment #9)
> I suppose you didn't have "resize icons by panel height" tick set in systray
> settings?

That setting is ticked in systray settings, but it doesn't have effect on
keyboard layout switcher indicator.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-17 Thread Andrey
https://bugs.kde.org/show_bug.cgi?id=438648

--- Comment #9 from Andrey  ---
I suppose you didn't have "resize icons by panel height" tick set in systray
settings?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-16 Thread Andrey
https://bugs.kde.org/show_bug.cgi?id=438648

Andrey  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-desktop/commit/36
   ||54bb5b875cd090f943bcf6bd7d4
   ||53ca25cd2df
 Status|ASSIGNED|RESOLVED

--- Comment #8 from Andrey  ---
Git commit 3654bb5b875cd090f943bcf6bd7d453ca25cd2df by Andrey Butirsky.
Committed on 16/06/2021 at 18:58.
Pushed by butirsky into branch 'master'.

Revert "[keyboard layout applet] Make keyboard layout label vertically
centered"

This reverts commit be6e36e548fba3d6dba426891a19e319107616e7

The patch didn't work when system tray icons are not scaled and on some
non-standard panel sizes.

M  +0-8applets/keyboardlayout/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/3654bb5b875cd090f943bcf6bd7d453ca25cd2df

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-16 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=438648

--- Comment #7 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/505

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-16 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=438648

Bug Janitor Service  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |ASSIGNED

--- Comment #6 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/504

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-16 Thread Andrey
https://bugs.kde.org/show_bug.cgi?id=438648

Andrey  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #5 from Andrey  ---
We are about to revert this, but have alternative solution.  
Still, the roots of the problem is not clear, so please help us reproduce it:
is you display HiDPI, does it happen on new user with default settings, panel
size etc.?
Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-15 Thread Yaroslav Sidlovsky
https://bugs.kde.org/show_bug.cgi?id=438648

Yaroslav Sidlovsky  changed:

   What|Removed |Added

 CC||zawer...@gmail.com

--- Comment #4 from Yaroslav Sidlovsky  ---
I think it will be better to revert this commit,
if it's causing such weird positioning on some systems.

Still using toUpperCase() for language code is good alternative, IMHO.
It won't have vertical positioning issues at all.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-15 Thread Andrey
https://bugs.kde.org/show_bug.cgi?id=438648

--- Comment #3 from Andrey  ---
We will check and revert in worst case.
Currently I have no idea what's wrong, but AFAIK we didn't test on HiDPI so my
wild guess it might be related.
Please confirm.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438648

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |VHI
 Status|REPORTED|CONFIRMED
   Keywords||regression
  Component|System Tray |Keyboard Layout
 CC||butir...@gmail.com,
   ||n...@kde.org
 Ever confirmed|0   |1

--- Comment #2 from Nate Graham  ---
Andrey, can you investigate and correct this?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 438648] Inconsistent looking of keyboard layout switcher icon in the tray

2021-06-14 Thread ChronosX88
https://bugs.kde.org/show_bug.cgi?id=438648

--- Comment #1 from ChronosX88  ---
Created attachment 139321
  --> https://bugs.kde.org/attachment.cgi?id=139321=edit
example of inconsistent looking of keyboard layout switcher icon (us layout)

-- 
You are receiving this mail because:
You are watching all bug changes.