[plasmashell] [Bug 453141] When changing display resolutions, desktop Widgets should try to keep the same position as much as possible

2023-03-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=453141

--- Comment #9 from tomash...@gmail.com ---
Ok, though if this functionality had been there all along, this should never
have been accepted as a bug:-).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 453141] When changing display resolutions, desktop Widgets should try to keep the same position as much as possible

2023-03-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=453141

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Nate Graham  ---
Please don't re-open bug reports based on conjecture. If you're experiencing an
issue, please submit a new bug report. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 453141] When changing display resolutions, desktop Widgets should try to keep the same position as much as possible

2023-03-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=453141

Nate Graham  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 453141] When changing display resolutions, desktop Widgets should try to keep the same position as much as possible

2023-03-04 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=453141

tomash...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #7 from tomash...@gmail.com ---
I am not sure this should have been closed as fixed by this merge request.

The commit message starts with: 'The layout manager has a functionality that
when the layout is resized, it tries to move all plasmoids to keep roughtly the
same proportional distance they had before the resize happened, to make screen
resolution change the least "suprising" possible.'

I think that is incorrect. I do not think such functionality exists. This bug
is about requesting such functionality - and I do not think this commit added
it. So I am reopening this. If I am mistaken, sorry for the noise.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 453141] When changing display resolutions, desktop Widgets should try to keep the same position as much as possible

2023-01-25 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=453141

Marco Martin  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/
   |39dd7bc3b75df58eb2d569df4f8 |c7fe9fc0d271a145c9025994673
   |9cbe65f1113b6   |599fb51872446

--- Comment #6 from Marco Martin  ---
Git commit c7fe9fc0d271a145c9025994673599fb51872446 by Marco Martin.
Committed on 25/01/2023 at 16:23.
Pushed by mart into branch 'Plasma/5.27'.

fix problems in plasmoid layout restore

The layout manager has a functionality that when the layout is resized,
it tries to move all plasmoids to keep roughtly the same proportional
distance they had before the resize happened, to make screen resolution
change the least "suprising" possible.

We actually need this in only one case:
The screen resoltion changed and there is not a saved plasmoid layout
for this resolution.

What was actually happening was that this heuristic was executed *only*
when the layout was resized due to panels being added/resized (and not
when it should have been).
When a panel gets added/resized we want the plasmoids layoput to change
*as little as possible* again, to not make surprises.
As a side effect , it casued a pretty serious bug:
plasmoids near to the vertical center of the screen migrated upwards of
few pixels at every plasma restart, because ever time it starts without
a panel which appears only later, causing that heuristic to execute and
break havoc.
Now the heuristic is executed only when the screen resolution changes,
which will cause a "config key change" event.
Execute this also when the containment migrates to a new screen, and as
soon this heuristic got executed, save the layout on the new key.
Related: bug 442919, bug 437538, bug 431432

M  +7-2components/containmentlayoutmanager/abstractlayoutmanager.h
M  +14   -4components/containmentlayoutmanager/appletslayout.cpp
M  +9-2components/containmentlayoutmanager/gridlayoutmanager.cpp
M  +1-1components/containmentlayoutmanager/gridlayoutmanager.h

https://invent.kde.org/plasma/plasma-workspace/commit/c7fe9fc0d271a145c9025994673599fb51872446

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 453141] When changing display resolutions, desktop Widgets should try to keep the same position as much as possible

2023-01-25 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=453141

Marco Martin  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/commit/
   ||39dd7bc3b75df58eb2d569df4f8
   ||9cbe65f1113b6
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Marco Martin  ---
Git commit 39dd7bc3b75df58eb2d569df4f89cbe65f1113b6 by Marco Martin.
Committed on 25/01/2023 at 16:07.
Pushed by mart into branch 'master'.

fix problems in plasmoid layout restore

The layout manager has a functionality that when the layout is resized,
it tries to move all plasmoids to keep roughtly the same proportional
distance they had before the resize happened, to make screen resolution
change the least "suprising" possible.

We actually need this in only one case:
The screen resoltion changed and there is not a saved plasmoid layout
for this resolution.

What was actually happening was that this heuristic was executed *only*
when the layout was resized due to panels being added/resized (and not
when it should have been).
When a panel gets added/resized we want the plasmoids layoput to change
*as little as possible* again, to not make surprises.
As a side effect , it casued a pretty serious bug:
plasmoids near to the vertical center of the screen migrated upwards of
few pixels at every plasma restart, because ever time it starts without
a panel which appears only later, causing that heuristic to execute and
break havoc.
Now the heuristic is executed only when the screen resolution changes,
which will cause a "config key change" event.
Execute this also when the containment migrates to a new screen, and as
soon this heuristic got executed, save the layout on the new key.
Related: bug 442919, bug 437538, bug 431432

M  +7-2components/containmentlayoutmanager/abstractlayoutmanager.h
M  +14   -4components/containmentlayoutmanager/appletslayout.cpp
M  +9-2components/containmentlayoutmanager/gridlayoutmanager.cpp
M  +1-1components/containmentlayoutmanager/gridlayoutmanager.h

https://invent.kde.org/plasma/plasma-workspace/commit/39dd7bc3b75df58eb2d569df4f89cbe65f1113b6

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 453141] When changing display resolutions, desktop Widgets should try to keep the same position as much as possible

2023-01-25 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=453141

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2535

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 453141] When changing display resolutions, desktop Widgets should try to keep the same position as much as possible

2022-07-02 Thread Cristóbal Veas
https://bugs.kde.org/show_bug.cgi?id=453141

Cristóbal Veas  changed:

   What|Removed |Added

 CC||cristobal.v...@pm.me

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 453141] When changing display resolutions, desktop Widgets should try to keep the same position as much as possible

2022-05-18 Thread DarkThoughts
https://bugs.kde.org/show_bug.cgi?id=453141

DarkThoughts  changed:

   What|Removed |Added

 CC||ihat...@gmail.com

--- Comment #3 from DarkThoughts  ---
This is still an issue if you use a non native monitor resolution (unlike
https://bugs.kde.org/show_bug.cgi?id=360478). I believe it is caused by the
login screen (SDDM) running in native and then applies the screen resolution of
the user profile after the login, which scrambles all my widgets around.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 453141] When changing display resolutions, desktop Widgets should try to keep the same position as much as possible

2022-05-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=453141

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=453314

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 453141] When changing display resolutions, desktop Widgets should try to keep the same position as much as possible

2022-05-02 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=453141

--- Comment #2 from tomash...@gmail.com ---
Done, here: https://bugs.kde.org/show_bug.cgi?id=453314

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 453141] When changing display resolutions, desktop Widgets should try to keep the same position as much as possible

2022-05-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=453141

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
Summary|When changing display   |When changing display
   |resolutions, icons and  |resolutions, desktop
   |widets should try to keep   |Widgets should try to keep
   |the same position as much   |the same position as much
   |as possible |as possible
   Severity|normal  |wishlist
 Status|REPORTED|CONFIRMED
 CC||n...@kde.org

--- Comment #1 from Nate Graham  ---
The implementation would be quite a can of worms, but it would be nice indeed.

It would also need to be separately implemented for desktop icons and widgets,
so let's use this for widgets, and can you please open a new bug report for
icons?

-- 
You are receiving this mail because:
You are watching all bug changes.