[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 lubimov.maxim+...@gmail.com changed: What|Removed |Added CC||lubimov.maxim+...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 Nate Graham changed: What|Removed |Added Version Fixed In|5.27|5.102 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 Nate Graham changed: What|Removed |Added Version Fixed In||5.27 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 David Redondo changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/fram ||eworks/kguiaddons/commit/39 ||84732e007e71632a525d89227fd ||fe94fa037ad --- Comment #26 from David Redondo --- Git commit 3984732e007e71632a525d89227fdfe94fa037ad by David Redondo. Committed on 08/12/2022 at 09:54. Pushed by davidre into branch 'master'. waylandclipboard: Update QClipboard when gaining focus A process that owns the clipboard via KSystemClipboard (wlr-data-control) and tries to read the clipboard via QClipboard will deadlock itself and eventually times out because the read is done blocking and the send event is only received afterwards by WaylandClipboard. When Qt knows it owns the keyboard it can get the data directly, so the idea is to set QClipboard if possible. However this can be done only when the Application has focus. Unfortunately inside Qt window system events are delieverd asnycronously while QClipboard uses signal to indicate changes, this makes QGuiApplication::focusWindowChanged not useable here because it happens to late - after the QClipboard signal. For this reason we bind to the wl_seat and track focus ourselves. QClipboard takes ownership of QMimeData that is passed into it and so does KSystemClipboard and ultimately DataControlSource which now uses unique_ptr to signify this and make it clear that ownership is transferred when the QClipboard is set. Related: bug 442521 M +5-0src/CMakeLists.txt M +106 -4src/systemclipboard/waylandclipboard.cpp M +3-0src/systemclipboard/waylandclipboard_p.h https://invent.kde.org/frameworks/kguiaddons/commit/3984732e007e71632a525d89227fdfe94fa037ad -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #25 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kguiaddons/-/merge_requests/80 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 David Redondo changed: What|Removed |Added CC||k...@david-redondo.de --- Comment #24 from David Redondo --- This will be a general problem whenever something is pasted from klipper DataControlSource to plasma itself (that is https://bugs.kde.org/show_bug.cgi?id=442521) In this specific instance it is a bit weird that opening kickoff triggers reading the clipboard content. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379
Fabian Vogt changed:
What|Removed |Added
CC||fab...@ritter-vogt.de
--- Comment #23 from Fabian Vogt ---
I had a quick look. Turns out I never hit this issue because the clipboard
history doesn't always work here, I had to restart plasmashell.
tl;dr: When dolphin quits, Plasma takes ownership of the selection. When it
gets focus it doesn't remember and asks itself (through wayland) about its
content -> deadlock.
Using WAYLAND_DEBUG=1, I the issue is visible:
When dolphin exits, the selection is cleared. plasmashell is notified about
that:
[2622585.375] zwlr_data_control_device_v1@116.selection(nil)
[2622585.384] -> zwlr_data_control_offer_v1@4278190091.destroy()
And subsequently takes ownership of the selection:
[2622585.434] -> zwlr_data_control_manager_v1@115.create_data_source(new id
zwlr_data_control_source_v1@207)
[2622585.447] -> zwlr_data_control_source_v1@207.offer("text/uri-list")
[2622585.453] ->
zwlr_data_control_source_v1@207.offer("application/x-kio-metadata")
[2622585.459] ->
zwlr_data_control_source_v1@207.offer("application/x-kde-cutselection")
[2622585.464] ->
zwlr_data_control_source_v1@207.offer("application/x-kde-onlyReplaceEmpty")
[2622585.472] ->
zwlr_data_control_source_v1@207.offer("text/plain;charset=utf-8")
[2622585.481] ->
zwlr_data_control_device_v1@116.set_selection(zwlr_data_control_source_v1@207)
[2622585.548] -> org_kde_plasma_window@157.destroy()
[2622586.048] -> org_kde_plasma_window@144.destroy()
[2622586.080] -> org_kde_plasma_window@211.destroy()
Plasmashell is then notified about its own change (which is a bit weird but so
far ok):
[2622586.111] zwlr_data_control_device_v1@116.data_offer(new id
zwlr_data_control_offer_v1@4278190091)
[2622586.121] zwlr_data_control_offer_v1@4278190091.offer("text/uri-list")
[2622586.128]
zwlr_data_control_offer_v1@4278190091.offer("application/x-kio-metadata")
[2622586.134]
zwlr_data_control_offer_v1@4278190091.offer("application/x-kde-cutselection")
[2622586.139]
zwlr_data_control_offer_v1@4278190091.offer("application/x-kde-onlyReplaceEmpty")
[2622586.144]
zwlr_data_control_offer_v1@4278190091.offer("text/plain;charset=utf-8")
[2622586.151]
zwlr_data_control_device_v1@116.selection(zwlr_data_control_offer_v1@4278190091)
[2622587.436] wl_display@1.delete_id(157)
[2622587.447] wl_display@1.delete_id(144)
[2622587.450] wl_display@1.delete_id(211)
[2622587.458] zwlr_data_control_source...@207.send("text/uri-list", fd 39)
The issue starts when plasmashell gains keyboard focus:
[2633917.635] wl_keyboard@3.enter(3533, wl_surface@211, array[0])
[2633917.652] -> wl_disp...@1.sync(new id wl_callback@160)
[2633917.659] wl_keyboard@3.modifiers(3528, 0, 0, 0, 0)
At that point the plain wayland selection protocol announces its contents
(currently held by plasmashell itself):
[2633917.669] wl_data_device@10.data_offer(new id wl_data_offer@4278190092)
[2633917.678] wl_data_offer@4278190092.offer("text/uri-list")
[2633917.685] wl_data_offer@4278190092.offer("application/x-kio-metadata")
[2633917.691] wl_data_offer@4278190092.offer("application/x-kde-cutselection")
[2633917.697]
wl_data_offer@4278190092.offer("application/x-kde-onlyReplaceEmpty")
[2633917.702] wl_data_offer@4278190092.offer("text/plain;charset=utf-8")
[2633917.708] wl_data_offer@4278190092.source_actions(0)
[2633917.713] wl_data_device@10.selection(wl_data_offer@4278190092)
Plasma is immediately interested in its "application/x-kde-cutselection"
content and asks for it:
#0 0x7511c470 in QtWayland::wl_data_offer::receive(QString const&,
int)@plt () at /lib64/libQt5WaylandClient.so.5
#1 0x7514d0b4 in () at /lib64/libQt5WaylandClient.so.5
#2 0x75f99584 in QInternalMimeData::retrieveData(QString const&,
QVariant::Type) const () at /lib64/libQt5Gui.so.5
#3 0x75b01520 in () at /lib64/libQt5Core.so.5
#4 0x75b024dd in QMimeData::data(QString const&) const () at
/lib64/libQt5Core.so.5
#5 0x74ea5ff1 in KIO::isClipboardDataCut(QMimeData const*)
(mimeData=mimeData@entry=0x59b865d0) at
/usr/src/debug/kio-5.100.0/src/widgets/paste.cpp:360
#6 0x7073b9bf in
KFilePreviewGeneratorPrivate::applyCutItemEffect(KFileItemList const&)
(this=this@entry=0x5641e8e0, items=...) at
/usr/src/debug/kio-5.100.0/src/filewidgets/kfilepreviewgenerator.cpp:871
#7 0x7073d327 in KFilePreviewGeneratorPrivate::updateCutItems()
(this=0x5641e8e0) at
/usr/src/debug/kio-5.100.0/src/filewidgets/kfilepreviewgenerator.cpp:684
[...]
#13 0x75f89b1d in QClipboard::emitChanged(QClipboard::Mode) () at
/lib64/libQt5Gui.so.5
[2633917.886] ->
wl_data_offer@4278190092.receive("application/x-kde-cutselection", fd 43)
This is a deadllock: Plasmashell is asking for its own selection content.
Timeout to the rescue!
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 --- Comment #22 from Akseli Lahtinen --- (In reply to Nate Graham from comment #15) > I could reproduce this issue last month, but I can't anymore with the > current state of git master. Can anyone else? It might have been fixed > recently. I can still reproduce the issue Operating System: Fedora Linux 37 KDE Plasma Version: 5.26.3 KDE Frameworks Version: 5.100.0 Qt Version: 5.15.7 Kernel Version: 6.0.9-300.fc37.x86_64 (64-bit) Graphics Platform: Wayland Processors: 12 × AMD Ryzen 5 3600 6-Core Processor Memory: 15,5 GiB of RAM Graphics Processor: AMD Radeon RX 6600 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 Yaroslav Sidlovsky changed: What|Removed |Added CC||zawer...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 Oleg changed: What|Removed |Added CC||o...@tsvetkov.dev Version|5.26.2 |5.26.3 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 Bacteria changed: What|Removed |Added Version|5.25.4 |5.26.2 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 Nate Graham changed: What|Removed |Added CC||filip.frge...@disroot.org --- Comment #21 from Nate Graham --- *** Bug 459296 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 rita...@fastmail.com changed: What|Removed |Added CC||rita...@fastmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 soredake changed: What|Removed |Added CC||ndrzj1...@relay.firefox.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 imagina...@mailbox.org changed: What|Removed |Added CC||imagina...@mailbox.org --- Comment #20 from imagina...@mailbox.org --- (In reply to Nate Graham from comment #15) > I could reproduce this issue last month, but I can't anymore with the > current state of git master. Can anyone else? It might have been fixed > recently. FWIW: I can't reproduce this. Neither with a ~400 MB .iso copied in Dolphin nor with a 10 MB raw-foto in Gwenview. System is snappy as it was before although both files are still in the clipboard. I have Xwayland installed, though. Could this matter here? -- Operating System: Linux KDE Plasma Version: 5.24.4 KDE Frameworks Version: 5.91.0 Qt Version: 5.15.2 Kernel Version: 5.19.12 (64-bit) Graphics Platform: Wayland Processors: 12 × AMD Ryzen 5 5600G with Radeon Graphics -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 Pawel changed: What|Removed |Added CC||bednarczyk.pa...@outlook.co ||m -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=459528 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 454379] After any file is copied from Dolphin and Dolphin is closed, Plasma panel widgets have a delay before closing
https://bugs.kde.org/show_bug.cgi?id=454379 Nate Graham changed: What|Removed |Added Summary|plasmashell starts lagging |After any file is copied |after any file is copied|from Dolphin and Dolphin is |from dolphin and dolphin is |closed, Plasma panel |closed |widgets have a delay before ||closing --- Comment #19 from Nate Graham --- Never mind I can still reproduce it with Dolphin. I was trying to Gwenview steps, which are working for me. -- You are receiving this mail because: You are watching all bug changes.
