[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 Nate Graham changed: What|Removed |Added Version Fixed In||5.26.2 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-desktop/commit/e8 |ma/plasma-desktop/commit/18 |78272bc8866328c2b4170190e8e |870d13d8eed284d50efaaf8 |b702700b71b |a728d6226e7 --- Comment #19 from Nate Graham --- Git commit 18870d13d8eed284d50efaaf8a728d6226e7 by Nate Graham, on behalf of Jin Liu. Committed on 20/10/2022 at 15:46. Pushed by ngraham into branch 'Plasma/5.26'. [applets/digitalclock] Fix font size change when migrating from 5.25 When migrating from 5.25, if custom font is set, the migration script sets fontSize=10, which causes the look of digitalclock to change from 5.25 (where the font autosizes). And the default value of 10 can be too small for some users. So now this settings migration script sets fontSize=72 if custom font is set in 5.25. For panels thinner than 72pt, this should retain 5.25's autosize behavior. cons: 1) Too late for users already upgraded to 5.26 2) The config dialog looks a bit strange with a very large sample text. (cherry picked from commit e878272bc8866328c2b4170190e8eb702700b71b) M +7-0 desktoppackage/contents/updates/digitalclock_migrate_font_settings.js https://invent.kde.org/plasma/plasma-desktop/commit/18870d13d8eed284d50efaaf8a728d6226e7 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 Fushan Wen changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/plasma-desktop/commit/e8 ||78272bc8866328c2b4170190e8e ||b702700b71b Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #18 from Fushan Wen --- Git commit e878272bc8866328c2b4170190e8eb702700b71b by Fushan Wen, on behalf of Jin Liu. Committed on 20/10/2022 at 04:21. Pushed by ngraham into branch 'master'. [applets/digitalclock] Fix font size change when migrating from 5.25 When migrating from 5.25, if custom font is set, the migration script sets fontSize=10, which causes the look of digitalclock to change from 5.25 (where the font autosizes). And the default value of 10 can be too small for some users. So now this settings migration script sets fontSize=72 if custom font is set in 5.25. For panels thinner than 72pt, this should retain 5.25's autosize behavior. cons: 1) Too late for users already upgraded to 5.26 2) The config dialog looks a bit strange with a very large sample text. M +7-0 desktoppackage/contents/updates/digitalclock_migrate_font_settings.js https://invent.kde.org/plasma/plasma-desktop/commit/e878272bc8866328c2b4170190e8eb702700b71b -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 Bug Janitor Service changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED --- Comment #17 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1213 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 --- Comment #16 from Jin Liu --- (In reply to Jin Liu from comment #14) > (In reply to Nate Graham from comment #12) > > Sounds like something in our settings migration script went wrong, > > unfortunately. > > I think it's not in the settings migration script, but because of the > fontSize's default value 10 can be too small in some screens. > > If we want to keep digital clock's look unchanged from 5.25 to 5.26, with > custom font set in 5.25, then I think there're 3 options: > > 1. When migrated from 5.25, has fontSize set to a secret value (e.g. -1), so > that the QML code will use custom font and auto size, exactly as in 5.25. > This is bad, because we can't configure this in 5.26. It'll be only > available for widgets migrated from 5.25, but not for newly created widgets. > > 2. When migrated from 5.25, the migration script calculates a suitable > fontSize according to the panel height in config file. > This is too difficult due to the complexity in digital clock's layout code. > > 3. When migrated from 5.25, has fontSize set to a secret value (e.g. -1). > Then the QML code, when first run in 5.26, do layout in autosize mode, and > write the calculated font size back to config file (can I write config in > QML?). > The custom font still won't resize with the panel, but at least widgets > migrated from 5.25 should look unchanged (until the user resizes the panel). > This is the most feasible. However, it has no effect for those users already > upgraded to 5.26. And it adds more to the already complicated QML code. So > I'm unsure if it shall be done... Oh I just realized there's another, very simple option: 4. When migrating from 5.25, the migration script sets the font size not to the default 10, but to a very large value (or at least larger than the panel height). Then the font will autofit to the panel, similar to 5.25. cons: 1) Too late for users already upgraded. 2) The config dialog looks a bit strange with a very large sample text. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 --- Comment #15 from Jin Liu --- (In reply to rb from comment #10) > I have found the exact cause of the issue. The > /home/$user/.config/plasma-org.kde.plasma.desktop-appletsrc file > contained this under Appearance [ ] section for the digital clock applet: > > [Containments][2][Applets][21][Configuration][Appearance] > autoFontAndSize=false ( <<< issue with small fonts) > customDateFormat=MMM d > dateFormat=custom > fontFamily= > showDate=true > use24hFormat=0 > > Removing the first line (autoFontAndSize=false) fixes the issue. I did > not at any time edit this file explicitly. It must have been added > there by KDE when I set up the panel in a previous version of Plasma. > Just FYI in case the issue affects any other users. Hi Rob, You don't need to edit the config file or logout. You can set "Text Display" to "Automatic" in the Config - Appearance, and it has the same effect as removing the autoFontAndSize=false line. 5.26 allows the user to set custom font size, but lost the ability to have both a custom font and autosize. So now if you use a custom font, you'll need to manually set a font size too. (But there's a trick: you can set a very large font size, then the font will autosize when the panel height is less than that size) -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 --- Comment #14 from Jin Liu --- (In reply to Nate Graham from comment #12) > Sounds like something in our settings migration script went wrong, > unfortunately. I think it's not in the settings migration script, but because of the fontSize's default value 10 can be too small in some screens. If we want to keep digital clock's look unchanged from 5.25 to 5.26, with custom font set in 5.25, then I think there're 3 options: 1. When migrated from 5.25, has fontSize set to a secret value (e.g. -1), so that the QML code will use custom font and auto size, exactly as in 5.25. This is bad, because we can't configure this in 5.26. It'll be only available for widgets migrated from 5.25, but not for newly created widgets. 2. When migrated from 5.25, the migration script calculates a suitable fontSize according to the panel height in config file. This is too difficult due to the complexity in digital clock's layout code. 3. When migrated from 5.25, has fontSize set to a secret value (e.g. -1). Then the QML code, when first run in 5.26, do layout in autosize mode, and write the calculated font size back to config file (can I write config in QML?). The custom font still won't resize with the panel, but at least widgets migrated from 5.25 should look unchanged (until the user resizes the panel). This is the most feasible. However, it has no effect for those users already upgraded to 5.26. And it adds more to the already complicated QML code. So I'm unsure if it shall be done... -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 --- Comment #13 from rb --- The autoFontAndSize being set to false left the setting in configure digital clock in the plasmoid to manual. Defaulting autoFontAndSize = true changes the setting to automatic, clearing both the custom font AND default size set in systemsettings>appearance>fonts. That should have probably been the default, leaving users with the automatic default (scalable with panel height + or -) font setting and forcing them to reset the custom font , where they would then see the new font size options in the menu. So if the user had italic fonts in 5.25, after the upgrade to 5.26 they would notice the font was no longer italic. When resetting it in the options they would also notice the font size is now available. Otherwise, they are just left with their old custom font selection and whatever small font size is selected in system settings, with no idea there is a new setting to set the font size available to them. Changing font sizes in system settings did not seem to have any immediate effect either and also I did not know which font would need to be changed to affect the clock font, i.e. fixed-width, small, toolbar etc. Maybe the user would have to try them all and log out and log back in again for them to take effect? No worries, it is fixed now! On 10/17/22 3:12 PM, Nate Graham wrote: > https://bugs.kde.org/show_bug.cgi?id=460415 > > Nate Graham changed: > > What|Removed |Added > > CC||ad.liu@gmail.com > Status|NEEDSINFO |REPORTED > Resolution|WAITINGFORINFO |--- > > --- Comment #12 from Nate Graham --- > Sounds like something in our settings migration script went wrong, > unfortunately. > -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 Nate Graham changed: What|Removed |Added CC||ad.liu@gmail.com Status|NEEDSINFO |REPORTED Resolution|WAITINGFORINFO |--- --- Comment #12 from Nate Graham --- Sounds like something in our settings migration script went wrong, unfortunately. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 --- Comment #11 from rb --- Correction: I see that autoFontAndSize was introduced into 5.26 digitalclock and set to true by default. I previously in 5.25 had Sego ui custom font but no size was able to be selected if I recall correctly, just the font type. I guess because of that, autoFontAndSize was set to false by the system after upgrading to 5.26 in the appletsrc file . The size can now be set in the settings of the clock with a particular font implicitly selected. The decision to change this to false as detailed below and have the font size selection option not be readily visible can lead the user with very small font with no idea they can now increase the font size. "Plasma 5.26 introduced a new config entry autoFontAndSize which defaults to true. This means if the user customized font before (fontFamily, boldText, italicText), in 5.26 these settings are ignored. So we need to set autoFontAndSize=false if: 1. Any of these 3 old entries above is set. 2. No new entries introduced in 5.26 (autoFontAndSize, fontSize, fontWeight, fontStyleName) are set, so this is a config from 5.25. And fontWeight should be set to 75 (Font.Bold) if boldText==true." On 10/14/22 3:40 PM, Nate Graham wrote: > https://bugs.kde.org/show_bug.cgi?id=460415 > > Nate Graham changed: > > What|Removed |Added > > Keywords||regression > Version|unspecified |5.26.0 >Component|general |Digital Clock > Assignee|unassigned-b...@kde.org |plasma-b...@kde.org > CC||n...@kde.org > Product|kde |plasmashell > Target Milestone|--- |1.0 > Resolution|--- |WAITINGFORINFO > Status|REPORTED|NEEDSINFO > > --- Comment #2 from Nate Graham --- > I'm going to have to ask you to upgrade again so we can debug a bit. After > you've done that, please attach screenshots of: > 1. How it looks when it's not readable > 2. The "Appearance" page of the settings window for the Digital Clock that's > got too-small text > > Also, what is your panel's thickness set to? > -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 --- Comment #10 from rb --- Hey nate, On a final note: I have found the exact cause of the issue. The /home/$user/.config/plasma-org.kde.plasma.desktop-appletsrc file contained this under Appearance [ ] section for the digital clock applet: [Containments][2][Applets][21][Configuration][Appearance] autoFontAndSize=false ( <<< https://bugs.kde.org/show_bug.cgi?id=460415 > > Nate Graham changed: > > What|Removed |Added > > Keywords||regression > Version|unspecified |5.26.0 >Component|general |Digital Clock > Assignee|unassigned-b...@kde.org |plasma-b...@kde.org > CC||n...@kde.org > Product|kde |plasmashell > Target Milestone|--- |1.0 > Resolution|--- |WAITINGFORINFO > Status|REPORTED|NEEDSINFO > > --- Comment #2 from Nate Graham --- > I'm going to have to ask you to upgrade again so we can debug a bit. After > you've done that, please attach screenshots of: > 1. How it looks when it's not readable > 2. The "Appearance" page of the settings window for the Digital Clock that's > got too-small text > > Also, what is your panel's thickness set to? > -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 --- Comment #8 from rb --- Hi nate, Just FYI the solution was simple. (with Arch back on the machine with the 5.26 upgrade), I simply removed the digital clock in the panel and replaced it and then reconfigured the custom date format. The font now scales when the panel height is deceased/increased. The panel configuration files in my home directory must have caused the issue but in all fairness, this has never happened any Plasma ugrades with versions 5.18 thru 5.25. It seems like breakage to me even though the solution was simple. The user does not expect that the previous digital clock in the panel should be broken after an upgrade and logging back in again. No other elements on the desktop configuration was not affected. Thanks again, Rob. On 10/14/22 3:40 PM, Nate Graham wrote: > https://bugs.kde.org/show_bug.cgi?id=460415 > > Nate Graham changed: > > What|Removed |Added > > Keywords||regression > Version|unspecified |5.26.0 >Component|general |Digital Clock > Assignee|unassigned-b...@kde.org |plasma-b...@kde.org > CC||n...@kde.org > Product|kde |plasmashell > Target Milestone|--- |1.0 > Resolution|--- |WAITINGFORINFO > Status|REPORTED|NEEDSINFO > > --- Comment #2 from Nate Graham --- > I'm going to have to ask you to upgrade again so we can debug a bit. After > you've done that, please attach screenshots of: > 1. How it looks when it's not readable > 2. The "Appearance" page of the settings window for the Digital Clock that's > got too-small text > > Also, what is your panel's thickness set to? > -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 --- Comment #9 from rb --- Created attachment 152918 --> https://bugs.kde.org/attachment.cgi?id=152918=edit fixed.png -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 --- Comment #6 from rb --- Hi nate, here is a pic of the full screen with host panel on top (pre plasma 5.26) and guest panel in scaled mode full screen underneath with 5.26. Again, both panels are 34 height. I have a projector with a 92" screen about 10-12 feet away. With 5.26 I cannot see date/time. It was not a problem before as you can see below. Again, clock font does not scale at all in 5.26 when changing panel height + or -. Thanks again and sorry for HUGE pic, but wanted you to get the full picture. Rob BTW I know it looks like Gnome (gasp) but that is how I like it set up. They are indeed both KDE Plasma 5. On 10/14/22 3:40 PM, Nate Graham wrote: > https://bugs.kde.org/show_bug.cgi?id=460415 > > Nate Graham changed: > > What|Removed |Added > > Keywords||regression > Version|unspecified |5.26.0 >Component|general |Digital Clock > Assignee|unassigned-b...@kde.org |plasma-b...@kde.org > CC||n...@kde.org > Product|kde |plasmashell > Target Milestone|--- |1.0 > Resolution|--- |WAITINGFORINFO > Status|REPORTED|NEEDSINFO > > --- Comment #2 from Nate Graham --- > I'm going to have to ask you to upgrade again so we can debug a bit. After > you've done that, please attach screenshots of: > 1. How it looks when it's not readable > 2. The "Appearance" page of the settings window for the Digital Clock that's > got too-small text > > Also, what is your panel's thickness set to? > -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 --- Comment #3 from rb --- Hi thanks for the reply. Yesterday,I migrated my machine to debian stable from arch. Too many changes too quick that I do not have time to always adjust for. BUT, I did copy all of my home directory from the arch backups to a virtual machine with endeavour installed (same as arch with plasma 5.26). The issue is the same: 1. The top panel is in my host machine, the bottom panel is in the VM. Both panels are set to height 34. The host machine running plasma 5.20, when panel height is increased or decreased, the font also increases or decreases accordingly (scales relative to the panel height size). In the vm, running plasma 5.26, increasing or decreasing the panel height does not change the clock size. while it may not look that small in this pic, I am about 10 feet from the screen most often and the font size is very small with no way to adjust even with panel height increase. 2. Changing themes or styles in appearance in Plasma system settings has no effect, I will follow up with separate email with full screen pic to show how start the difference is in 5.26 and 5.25 and earlier. (As a reminder: i mentioned in the bug report, copying the org.kde.plasma.digital clock folder into the system from 5.25 to 5.26 installation made it behave as before/expected) Thank you for your time and let me know if I can provide any more info that may be of help to you. Rob On 10/14/22 3:40 PM, Nate Graham wrote: > https://bugs.kde.org/show_bug.cgi?id=460415 > > Nate Graham changed: > > What|Removed |Added > > Keywords||regression > Version|unspecified |5.26.0 >Component|general |Digital Clock > Assignee|unassigned-b...@kde.org |plasma-b...@kde.org > CC||n...@kde.org > Product|kde |plasmashell > Target Milestone|--- |1.0 > Resolution|--- |WAITINGFORINFO > Status|REPORTED|NEEDSINFO > > --- Comment #2 from Nate Graham --- > I'm going to have to ask you to upgrade again so we can debug a bit. After > you've done that, please attach screenshots of: > 1. How it looks when it's not readable > 2. The "Appearance" page of the settings window for the Digital Clock that's > got too-small text > > Also, what is your panel's thickness set to? > -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 460415] Digital Clock 5.26: font too tiny to read
https://bugs.kde.org/show_bug.cgi?id=460415 Nate Graham changed: What|Removed |Added Keywords||regression Version|unspecified |5.26.0 Component|general |Digital Clock Assignee|unassigned-b...@kde.org |plasma-b...@kde.org CC||n...@kde.org Product|kde |plasmashell Target Milestone|--- |1.0 Resolution|--- |WAITINGFORINFO Status|REPORTED|NEEDSINFO --- Comment #2 from Nate Graham --- I'm going to have to ask you to upgrade again so we can debug a bit. After you've done that, please attach screenshots of: 1. How it looks when it's not readable 2. The "Appearance" page of the settings window for the Digital Clock that's got too-small text Also, what is your panel's thickness set to? -- You are receiving this mail because: You are watching all bug changes.
