[plasmashell] [Bug 465326] While handling an image in klipper history, Plasma freezes for a some time with 100% CPU usage then crashes

2023-02-13 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465326

--- Comment #23 from Fushan Wen  ---
Git commit 365bd94bc6b4de910249f566b01a22bacfb55353 by Fushan Wen.
Committed on 13/02/2023 at 16:34.
Pushed by fusionfuture into branch 'master'.

klipper: lock mutex before `indexOf` in `insert`
Related: bug 465225

M  +2-1klipper/historymodel.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/365bd94bc6b4de910249f566b01a22bacfb55353

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465326] While handling an image in klipper history, Plasma freezes for a some time with 100% CPU usage then crashes

2023-02-13 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465326

Fushan Wen  changed:

   What|Removed |Added

 Resolution|FIXED   |DUPLICATE

--- Comment #22 from Fushan Wen  ---


*** This bug has been marked as a duplicate of bug 465225 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465326] While handling an image in klipper history, Plasma freezes for a some time with 100% CPU usage then crashes

2023-02-12 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465326

Fushan Wen  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/
   |41ac399c39a653cac1d63b3f191 |89d1f0e07955427a083cbc5af34
   |3ed4eb2f0d2c3   |e0ae9fdcdaad4

--- Comment #21 from Fushan Wen  ---
Git commit 89d1f0e07955427a083cbc5af34e0ae9fdcdaad4 by Fushan Wen.
Committed on 13/02/2023 at 00:46.
Pushed by fusionfuture into branch 'Plasma/5.27'.

klipper: store QImage and construct QPixmap only when necessary

The mime data from Wayland clipboard is not the exact same image, so two
image items are listed (first time restarting plasmashell). But after
images are saved to local, they have the same uuid again. So klipper
starts to become confused after the second time restarting plasmashell.

This is caused by QPixmap::from(QImage).toImage() erasing metadata in the
image, and Wayland clipboard is async, so another identical image is added
to clipboard.
Related: bug 465225, bug 464828, bug 465603
FIXED-IN: 5.27


(cherry picked from commit 4649594aa95d601ac6449c9e8baf8201b28602c5)

M  +5-5klipper/historyimageitem.cpp
M  +2-2klipper/historyimageitem.h
M  +3-4klipper/historyitem.h

https://invent.kde.org/plasma/plasma-workspace/commit/89d1f0e07955427a083cbc5af34e0ae9fdcdaad4

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465326] While handling an image in klipper history, Plasma freezes for a some time with 100% CPU usage then crashes

2023-02-12 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465326

Fushan Wen  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/
   |4649594aa95d601ac6449c9e8ba |41ac399c39a653cac1d63b3f191
   |f8201b28602c5   |3ed4eb2f0d2c3

--- Comment #20 from Fushan Wen  ---
Git commit 41ac399c39a653cac1d63b3f1913ed4eb2f0d2c3 by Fushan Wen.
Committed on 13/02/2023 at 00:29.
Pushed by fusionfuture into branch 'cherry-pick-4649594a'.

klipper: store QImage and construct QPixmap only when necessary

The mime data from Wayland clipboard is not the exact same image, so two
image items are listed (first time restarting plasmashell). But after
images are saved to local, they have the same uuid again. So klipper
starts to become confused after the second time restarting plasmashell.

This is caused by QPixmap::from(QImage).toImage() erasing metadata in the
image, and KSystemClipboard will emit changed signal on Wayland, so
another identical image is added to clipboard.
Related: bug 465225, bug 464828, bug 465603
FIXED-IN: 5.27


(cherry picked from commit 4649594aa95d601ac6449c9e8baf8201b28602c5)

M  +5-5klipper/historyimageitem.cpp
M  +2-2klipper/historyimageitem.h
M  +3-4klipper/historyitem.h

https://invent.kde.org/plasma/plasma-workspace/commit/41ac399c39a653cac1d63b3f1913ed4eb2f0d2c3

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465326] While handling an image in klipper history, Plasma freezes for a some time with 100% CPU usage then crashes

2023-02-12 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465326

Fushan Wen  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/commit/
   ||4649594aa95d601ac6449c9e8ba
   ||f8201b28602c5
 Resolution|--- |FIXED
   Version Fixed In||5.27

--- Comment #19 from Fushan Wen  ---
Git commit 4649594aa95d601ac6449c9e8baf8201b28602c5 by Fushan Wen.
Committed on 12/02/2023 at 15:38.
Pushed by fusionfuture into branch 'master'.

klipper: store QImage and construct QPixmap only when necessary

The mime data from Wayland clipboard is not the exact same image, so two
image items are listed (first time restarting plasmashell). But after
images are saved to local, they have the same uuid again. So klipper
starts to become confused after the second time restarting plasmashell.

This is caused by QPixmap::from(QImage).toImage() erasing metadata in the
image, and KSystemClipboard will emit changed signal on Wayland, so
another identical image is added to clipboard.
Related: bug 465225, bug 464828, bug 465603
FIXED-IN: 5.27

M  +5-5klipper/historyimageitem.cpp
M  +2-2klipper/historyimageitem.h
M  +3-4klipper/historyitem.h

https://invent.kde.org/plasma/plasma-workspace/commit/4649594aa95d601ac6449c9e8baf8201b28602c5

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465326] While handling an image in klipper history, Plasma freezes for a some time with 100% CPU usage then crashes

2023-02-12 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=465326

--- Comment #18 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2612

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465326] While handling an image in klipper history, Plasma freezes for a some time with 100% CPU usage then crashes

2023-02-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=465326

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |VHI

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465326] While handling an image in klipper history, Plasma freezes for a some time with 100% CPU usage then crashes

2023-02-12 Thread Oded Arbel
https://bugs.kde.org/show_bug.cgi?id=465326

Oded Arbel  changed:

   What|Removed |Added

Summary|Plasma crashes when opening |While handling an image in
   |kickoff, after freezing for |klipper history, Plasma
   |a bit   |freezes for a some time
   ||with 100% CPU usage then
   ||crashes

-- 
You are receiving this mail because:
You are watching all bug changes.