[plasmashell] [Bug 467909] Connecting external monitor and attempting to extend desktop caused plasma to crash in PlasmaQuick::ContainmentView::setContainment()

2023-04-21 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=467909

Fushan Wen  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
  Latest Commit||https://invent.kde.org/qt/q
   ||t/qtdeclarative/-/commit/d1
   ||b9a4cacfb966cf0a37983d8f804
   ||4f3aedf5de3
 Status|REPORTED|RESOLVED
   Version Fixed In||Qt 6.5.0

--- Comment #8 from Fushan Wen  ---
Mark as resolved for now

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 467909] Connecting external monitor and attempting to extend desktop caused plasma to crash in PlasmaQuick::ContainmentView::setContainment()

2023-04-17 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=467909

--- Comment #7 from Albert Astals Cid  ---
Git commit 45c22a0221937682f4496801a495458a00f76d3a by Albert Astals Cid, on
behalf of Volker Hilsheimer.
Committed on 17/04/2023 at 21:40.
Pushed by aacid into branch 'kde/5.15'.

QQuickItem: Fix effective visibility for items without parent

Items are visible if they are children of a visible parent, and not
explicitly hidden. The effectiveVisible member stores the state and is
updated when conditions that impact the item visibility changes.

The old code returned true for items outside a visual hierarchy, which
broke signal emission when items were removed from a parent, e.g.
because the parent got destroyed. With this change, items removed from
a visual hierarchy will emit the visibleChanged signal.

Note: QQuickItem initializes the effectiveVisible member to true, even
if the item was created without parent item. Visual items are required
to be added to a visual hierarchy via setParentItem. For this reason,
newly created items never emit visibleChanged when they are added to
a parent.

Adjust the QQuickItem::visible test - it creates an item hierarchy
without window. Such items are never visible, so add a window and
parent the test item hierarchy to the window's content item.

This fixes the expected failures in the tests. It does introduce an
incompatibility with QGraphicsView and QGraphicsItem, which continue
to return true from QGraphicsItem::isVisible for items that are not
in an item hierarchy.

[ChangeLog][Qt Quick][QQuickItem] The visible property of Items without
a parent now always returns false, and the visibleChanged signal gets
emitted when the parent item of a visible item becomes null.

Fixes: QTBUG-108213
Change-Id: If4b2947cefd1407853f0f29e6c3fdbd49fc9af65
Reviewed-by: Fabian Kosmale 
Reviewed-by: Shawn Rutledge 
(cherry picked from commit d1b9a4cacfb966cf0a37983d8f8044f3aedf5de3)
Related: bug 396359

M  +2-4src/quick/items/qquickitem.cpp
M  +2-0tests/auto/quick/qquickitem/tst_qquickitem.cpp

https://invent.kde.org/qt/qt/qtdeclarative/commit/45c22a0221937682f4496801a495458a00f76d3a

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 467909] Connecting external monitor and attempting to extend desktop caused plasma to crash in PlasmaQuick::ContainmentView::setContainment()

2023-04-05 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=467909

Fushan Wen  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=396359

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 467909] Connecting external monitor and attempting to extend desktop caused plasma to crash in PlasmaQuick::ContainmentView::setContainment()

2023-04-04 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=467909

Fushan Wen  changed:

   What|Removed |Added

 CC||qydwhotm...@gmail.com

--- Comment #6 from Fushan Wen  ---
If the bug is reproducible, can you test
https://invent.kde.org/qt/qt/qtdeclarative/-/merge_requests/40 if you can patch
Qt provided by your distro?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 467909] Connecting external monitor and attempting to extend desktop caused plasma to crash in PlasmaQuick::ContainmentView::setContainment()

2023-04-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=467909

Nate Graham  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #5 from Nate Graham  ---
The infamous USB-C dock strikes again. :( Can't reproduce with my own USB-C
dock with an HDMI screen plugged into it. Of course, every USB-C dock is broken
in an excitingly different way.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 467909] Connecting external monitor and attempting to extend desktop caused plasma to crash in PlasmaQuick::ContainmentView::setContainment()

2023-04-03 Thread Michael Magyar
https://bugs.kde.org/show_bug.cgi?id=467909

Michael Magyar  changed:

   What|Removed |Added

 CC||michael.mag...@live.ca

--- Comment #4 from Michael Magyar  ---
Created attachment 157838
  --> https://bugs.kde.org/attachment.cgi?id=157838=edit
crash information from issue reproduction

KDE Crash Handler Automatic Crash Information

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 467909] Connecting external monitor and attempting to extend desktop caused plasma to crash in PlasmaQuick::ContainmentView::setContainment()

2023-04-03 Thread Michael Magyar
https://bugs.kde.org/show_bug.cgi?id=467909

--- Comment #3 from Michael Magyar  ---
(In reply to Nate Graham from comment #2)
> Is this 100% reproducible every time you do it? Or did it only happen once
> and you can't make it happen again?

It is not reproducible every time. The pattern to reproduce seems to be that
this issue can be reproduced when I explicitly set my machine to only use the
internal display when undocked, and then attempt to extend my display after
docking. Just connecting my USB-C dock this evening I was able to reproduce the
issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 467909] Connecting external monitor and attempting to extend desktop caused plasma to crash in PlasmaQuick::ContainmentView::setContainment()

2023-04-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=467909

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Nate Graham  ---
Is this 100% reproducible every time you do it? Or did it only happen once and
you can't make it happen again?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 467909] Connecting external monitor and attempting to extend desktop caused plasma to crash in PlasmaQuick::ContainmentView::setContainment()

2023-04-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=467909

Nate Graham  changed:

   What|Removed |Added

 CC||aleix...@kde.org,
   ||n...@kde.org,
   ||notm...@gmail.com
  Component|general |Multi-screen support
Summary|Connecting external monitor |Connecting external monitor
   |and attempting to extend|and attempting to extend
   |desktop caused plasma crash |desktop caused plasma to
   ||crash in
   ||PlasmaQuick::ContainmentVie
   ||w::setContainment()

-- 
You are receiving this mail because:
You are watching all bug changes.