[plasmashell] [Bug 481379] Sometimes Panel continuously floats and defloats when window is in the wrong spot (or the right spot?!)
https://bugs.kde.org/show_bug.cgi?id=481379 fanzhuyi...@gmail.com changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-desktop/-/commit/ |ma/plasma-desktop/-/commit/ |9309df10945cf092a5a855b8d34 |e3a270ef18ecc85624e2c835d2e |c6b024060b77b |49f6b1cca382b --- Comment #11 from fanzhuyi...@gmail.com --- Git commit e3a270ef18ecc85624e2c835d2e49f6b1cca382b by Yifan Zhu. Committed on 16/02/2024 at 21:37. Pushed by fanzhuyifan into branch 'Plasma/6.0'. Panel: use new API to calculate regionGeometry Previously the compensation for floatingness was done in qml, which had rounding errors that caused the panel to continuously float/defloat. Use new api that calculates regionGeometry independent of floatingness. This also simplifies the code. FIXED-IN: 6.0 (cherry picked from commit 9309df10945cf092a5a855b8d34c6b024060b77b) M +2-4desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/e3a270ef18ecc85624e2c835d2e49f6b1cca382b -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481379] Sometimes Panel continuously floats and defloats when window is in the wrong spot (or the right spot?!)
https://bugs.kde.org/show_bug.cgi?id=481379 --- Comment #10 from fanzhuyi...@gmail.com --- Git commit 711ebf79e784fb1440a037dfec73b0b706d41556 by Yifan Zhu. Committed on 16/02/2024 at 21:03. Pushed by fanzhuyifan into branch 'Plasma/6.0'. shell/panelview: calculate dodge geometry independent of floatingness The dodge/defloat geometry should be the same no matter the panel is floating or not. In addition, constrain it to the geometry of the current screen, so that content from other screens have no impact. Previously, the compensation for floatingness was done in Panel.qml, which made the code more complicated, and had rounding errors that caused the panel to continuously cycle between float and defloat. FIXED-IN: 6.0 (cherry picked from commit ab9de16b11a714684ae689d04c43520ff04194bb) M +18 -4shell/panelview.cpp M +6-0shell/panelview.h https://invent.kde.org/plasma/plasma-workspace/-/commit/711ebf79e784fb1440a037dfec73b0b706d41556 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481379] Sometimes Panel continuously floats and defloats when window is in the wrong spot (or the right spot?!)
https://bugs.kde.org/show_bug.cgi?id=481379 fanzhuyi...@gmail.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/plas ||ma/plasma-desktop/-/commit/ ||9309df10945cf092a5a855b8d34 ||c6b024060b77b Version Fixed In||6.0 --- Comment #9 from fanzhuyi...@gmail.com --- Git commit 9309df10945cf092a5a855b8d34c6b024060b77b by Yifan Zhu. Committed on 16/02/2024 at 21:04. Pushed by fanzhuyifan into branch 'master'. Panel: use new API to calculate regionGeometry Previously the compensation for floatingness was done in qml, which had rounding errors that caused the panel to continuously float/defloat. Use new api that calculates regionGeometry independent of floatingness. This also simplifies the code. FIXED-IN: 6.0 M +2-4desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/9309df10945cf092a5a855b8d34c6b024060b77b -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481379] Sometimes Panel continuously floats and defloats when window is in the wrong spot (or the right spot?!)
https://bugs.kde.org/show_bug.cgi?id=481379 --- Comment #8 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3913 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481379] Sometimes Panel continuously floats and defloats when window is in the wrong spot (or the right spot?!)
https://bugs.kde.org/show_bug.cgi?id=481379 --- Comment #7 from fanzhuyi...@gmail.com --- Git commit ab9de16b11a714684ae689d04c43520ff04194bb by Yifan Zhu. Committed on 16/02/2024 at 20:42. Pushed by fanzhuyifan into branch 'master'. shell/panelview: calculate dodge geometry independent of floatingness The dodge/defloat geometry should be the same no matter the panel is floating or not. In addition, constrain it to the geometry of the current screen, so that content from other screens have no impact. Previously, the compensation for floatingness was done in Panel.qml, which made the code more complicated, and had rounding errors that caused the panel to continuously cycle between float and defloat. FIXED-IN: 6.0 M +18 -4shell/panelview.cpp M +6-0shell/panelview.h https://invent.kde.org/plasma/plasma-workspace/-/commit/ab9de16b11a714684ae689d04c43520ff04194bb -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481379] Sometimes Panel continuously floats and defloats when window is in the wrong spot (or the right spot?!)
https://bugs.kde.org/show_bug.cgi?id=481379 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #6 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2040 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481379] Sometimes Panel continuously floats and defloats when window is in the wrong spot (or the right spot?!)
https://bugs.kde.org/show_bug.cgi?id=481379 --- Comment #5 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3907 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481379] Sometimes Panel continuously floats and defloats when window is in the wrong spot (or the right spot?!)
https://bugs.kde.org/show_bug.cgi?id=481379 --- Comment #4 from fanzhuyi...@gmail.com --- Oh this has nothing to do with fractional geometry -- this is because we change the geometry of the panel upon float/defloat, and the defloating zone is always calculated with respect to the actual geometry of the panel -- when the panel moves left, the defloating zone also moves left, thus making the panel float again... -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481379] Sometimes Panel continuously floats and defloats when window is in the wrong spot (or the right spot?!)
https://bugs.kde.org/show_bug.cgi?id=481379 Nate Graham changed: What|Removed |Added Summary|Panel continuously |Sometimes Panel |floats/defloats when window |continuously floats and |is in the wrong spot|defloats when window is in ||the wrong spot (or the ||right spot?!) CC||n...@kde.org --- Comment #3 from Nate Graham --- Haha wow! FWIW I can't reproduce it with a right screen edge panel myself at 225% scale. -- You are receiving this mail because: You are watching all bug changes.
