[plasmashell] [Bug 482908] Missing fallback icon for desktop-less MPRIS2 clients
https://bugs.kde.org/show_bug.cgi?id=482908
Fushan Wen changed:
What|Removed |Added
Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
|ma/plasma-workspace/-/commi |ma/plasma-workspace/-/commi
|t/9d92011d6022b57058ef8b02b |t/afa9e3406ba23a87cf4773f84
|5384f42e3e3f687 |f917d6466a33fa3
--- Comment #3 from Fushan Wen ---
Git commit afa9e3406ba23a87cf4773f84f917d6466a33fa3 by Fushan Wen, on behalf of
Guilherme Silva.
Committed on 09/03/2024 at 06:03.
Pushed by fusionfuture into branch 'Plasma/6.0'.
libkmpris: prevent an empty icon from being used
The previous logic would only use the fallback icon
("emblem-music-symbolic"), if the client had the "DesktopEntry"
property[1] set.
But since clients are allowed to omit that property completely
(mpd-mpris[2] does that), m_iconName would stay an empty string, and
clients would be left icon-less.
This change ensures that m_iconName is never an empty string.
[1]
https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry
[2] https://github.com/natsukagami/mpd-mpris/
(cherry picked from commit 9d92011d6022b57058ef8b02b5384f42e3e3f687)
M +3-3libkmpris/playercontainer.cpp
M +1-1libkmpris/playercontainer.h
https://invent.kde.org/plasma/plasma-workspace/-/commit/afa9e3406ba23a87cf4773f84f917d6466a33fa3
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 482908] Missing fallback icon for desktop-less MPRIS2 clients
https://bugs.kde.org/show_bug.cgi?id=482908
Guilherme Silva changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Latest Commit||https://invent.kde.org/plas
||ma/plasma-workspace/-/commi
||t/9d92011d6022b57058ef8b02b
||5384f42e3e3f687
Resolution|--- |FIXED
--- Comment #2 from Guilherme Silva ---
Git commit 9d92011d6022b57058ef8b02b5384f42e3e3f687 by Guilherme Silva.
Committed on 09/03/2024 at 05:30.
Pushed by fusionfuture into branch 'master'.
libkmpris: prevent an empty icon from being used
The previous logic would only use the fallback icon
("emblem-music-symbolic"), if the client had the "DesktopEntry"
property[1] set.
But since clients are allowed to omit that property completely
(mpd-mpris[2] does that), m_iconName would stay an empty string, and
clients would be left icon-less.
This change ensures that m_iconName is never an empty string.
[1]
https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry
[2] https://github.com/natsukagami/mpd-mpris/
M +3-3libkmpris/playercontainer.cpp
M +1-1libkmpris/playercontainer.h
https://invent.kde.org/plasma/plasma-workspace/-/commit/9d92011d6022b57058ef8b02b5384f42e3e3f687
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 482908] Missing fallback icon for desktop-less MPRIS2 clients
https://bugs.kde.org/show_bug.cgi?id=482908 Bug Janitor Service changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #1 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4022 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 482908] Missing fallback icon for desktop-less MPRIS2 clients
https://bugs.kde.org/show_bug.cgi?id=482908 Bug Janitor Service changed: What|Removed |Added Keywords||qt6 -- You are receiving this mail because: You are watching all bug changes.
