[plasmashell] [Bug 483066] logout no longer works after disabling systemd boot
https://bugs.kde.org/show_bug.cgi?id=483066 Nate Graham changed: What|Removed |Added Version Fixed In||6.0.3 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483066] logout no longer works after disabling systemd boot
https://bugs.kde.org/show_bug.cgi?id=483066 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-workspace/-/commi |ma/plasma-workspace/-/commi |t/41629e86035e341bb4dea6622 |t/b0c3c66fc04a7743c6c61d54e |36aefdc274e7c30 |1d825349de5d8b6 --- Comment #5 from Nate Graham --- Git commit b0c3c66fc04a7743c6c61d54e1d825349de5d8b6 by Nate Graham, on behalf of David Edmundson. Committed on 25/03/2024 at 21:25. Pushed by ngraham into branch 'Plasma/6.0'. plasma-shutdown: Correclty detect if we're using the legacy session We need different shutdown paths for the systemd and legacy boot. The current code worked by making the systemd call to end the session and checking the return status. This worked for handling the situation where systemd is not installed. It does not capture the case where the systemd boot is explicitly disabled. The call successfully does nothing. Instead replace with an explicit check that our target is activated. Also change to end the plasma-workspace.target as that's semantically more correct given it's the one we started. This is bound to the graphical-session so it ends up being the same thing. (cherry picked from commit 41629e86035e341bb4dea662236aefdc274e7c30) M +29 -6startkde/plasma-shutdown/shutdown.cpp M +1-0startkde/plasma-shutdown/shutdown.h https://invent.kde.org/plasma/plasma-workspace/-/commit/b0c3c66fc04a7743c6c61d54e1d825349de5d8b6 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483066] logout no longer works after disabling systemd boot
https://bugs.kde.org/show_bug.cgi?id=483066 David Edmundson changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/plasma-workspace/-/commi ||t/41629e86035e341bb4dea6622 ||36aefdc274e7c30 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #4 from David Edmundson --- Git commit 41629e86035e341bb4dea662236aefdc274e7c30 by David Edmundson. Committed on 22/03/2024 at 13:49. Pushed by davidedmundson into branch 'master'. plasma-shutdown: Correclty detect if we're using the legacy session We need different shutdown paths for the systemd and legacy boot. The current code worked by making the systemd call to end the session and checking the return status. This worked for handling the situation where systemd is not installed. It does not capture the case where the systemd boot is explicitly disabled. The call successfully does nothing. Instead replace with an explicit check that our target is activated. Also change to end the plasma-workspace.target as that's semantically more correct given it's the one we started. This is bound to the graphical-session so it ends up being the same thing. M +29 -6startkde/plasma-shutdown/shutdown.cpp M +1-0startkde/plasma-shutdown/shutdown.h https://invent.kde.org/plasma/plasma-workspace/-/commit/41629e86035e341bb4dea662236aefdc274e7c30 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483066] logout no longer works after disabling systemd boot
https://bugs.kde.org/show_bug.cgi?id=483066 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4095 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483066] logout no longer works after disabling systemd boot
https://bugs.kde.org/show_bug.cgi?id=483066
David Edmundson changed:
What|Removed |Added
CC||k...@davidedmundson.co.uk
--- Comment #2 from David Edmundson ---
Found it:
```
auto msg =
QDBusMessage::createMethodCall(QStringLiteral("org.freedesktop.systemd1"),
QStringLiteral("/org/freedesktop/systemd1"),
QStringLiteral("org.freedesktop.systemd1.Manager"),
QStringLiteral("StopUnit"));
msg << QStringLiteral("graphical-session.target") <<
QStringLiteral("fail");
QDBusReply reply =
QDBusConnection::sessionBus().call(msg);
if (!reply.isValid()) {
do the legacy path
```
If systemd is available, but we're not using the systemd boot, that DBus call
is perfectly legit so it doesn't fail. It just does nothing. So we never enter
the legacy path.
We'll need to find a way to distinguish those two
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 483066] logout no longer works after disabling systemd boot
https://bugs.kde.org/show_bug.cgi?id=483066 Nate Graham changed: What|Removed |Added Status|REPORTED|CONFIRMED CC||n...@kde.org Ever confirmed|0 |1 Severity|normal |major Priority|NOR |HI --- Comment #1 from Nate Graham --- Can reproduce all of those issues on Wayland, Did not test X11. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483066] logout no longer works after disabling systemd boot
https://bugs.kde.org/show_bug.cgi?id=483066 Bug Janitor Service changed: What|Removed |Added Keywords||qt6 -- You are receiving this mail because: You are watching all bug changes.
