[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-23 Thread Nick
https://bugs.kde.org/show_bug.cgi?id=483614

Nick  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|NEEDSINFO   |CONFIRMED
 Resolution|WAITINGFORINFO  |---

--- Comment #19 from Nick  ---
OK - I'll mark this one as confirmed in case a dev can take a look. I am able
to duplicate the symptoms as per the original bug description and there is a
sample theme to test with.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=483614

--- Comment #18 from obno...@gmail.com ---
Yes, your screenshot shows the problem, which is that some buttons pick their
foreground color from one value in the colors file while other buttons pick
theirs from another value.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-23 Thread Nick
https://bugs.kde.org/show_bug.cgi?id=483614

--- Comment #17 from Nick  ---
Created attachment 167639
  --> https://bugs.kde.org/attachment.cgi?id=167639&action=edit
Test with updated theme

Hi - no problem. I've just installed your update theme and here's a screenshot
of what I'm seeing. I'm still a little unclear as to the issue we are trying to
duplicate here (that's down to my understanding of themes!) so based on my
screenshot does this mean I have duplicated the symptoms you are seeing?
Thanks, Nick.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=483614

obno...@gmail.com changed:

   What|Removed |Added

 Attachment #167575|0   |1
is obsolete||

--- Comment #16 from obno...@gmail.com ---
Created attachment 167626
  --> https://bugs.kde.org/attachment.cgi?id=167626&action=edit
Fixed test theme

Oops, I had reverted the change to the colors file before creating the archive.
Here is the version with the magenta icons. Sorry for having wasted your time.

Regarding my theme, yes, I have been using it continually since Plasma 4 and
through Plasma 5 and I have now upgraded to Plasma 6 on the same system.
I have noticed that in Plasma 6, themes now have a metadata.json file rather
than metadata.desktop, and a new plasmarc file which my theme does not have.
This might be why it does not show up in the installer, I don't know; though
store.kde.org does not currently have a separate section for Plasma 6 themes so
who knows.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-22 Thread Nick
https://bugs.kde.org/show_bug.cgi?id=483614

--- Comment #15 from Nick  ---
Created attachment 167593
  --> https://bugs.kde.org/attachment.cgi?id=167593&action=edit
Aha!

Hang-on, I've found it in Plasma Style. So, I have now switched to breeze dark
theme and then selected your test style. See attached screenshot. No magenta
icons in the system tray. Can you confirm I am testing this correctly, in which
case I'll do some more tests to try to get your symptoms. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-22 Thread Nick
https://bugs.kde.org/show_bug.cgi?id=483614

--- Comment #14 from Nick  ---
Created attachment 167592
  --> https://bugs.kde.org/attachment.cgi?id=167592&action=edit
Cannot get test theme to install either

Hi - I think I'm at my knowledge limit here. I have installed your test theme
into the correct folder (see screenshot) and logged out and in again but it
still does not appear in the Plasma theme selector. I do wonder whether this is
related (i.e. is Plasma somehow spotting an error in the theme format and
blocking it)? Hoping someone else reading this bug might have some ideas.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-22 Thread Nick
https://bugs.kde.org/show_bug.cgi?id=483614

--- Comment #13 from Nick  ---
Created attachment 167591
  --> https://bugs.kde.org/attachment.cgi?id=167591&action=edit
Cannot install Velours on Plasma 6

Hi - I'm still unable to install Velours on my Neon Plasma 6 system. I have
tried the git method and the theme does not appear in the them selector after
installation. Also, as you can see in this screenshot, it is not appearing in
the "Download New Themes" selector. Did you install this theme on Plasma 5 and
then upgrade? Perhaps there is some king of compatibility check happening on my
fresh install Plasma 6 which is causing this to not install? Meanwhile let me
try the test theme you have attached...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-21 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=483614

--- Comment #12 from obno...@gmail.com ---
Created attachment 167577
  --> https://bugs.kde.org/attachment.cgi?id=167577&action=edit
System tray window : notice magenta icons

Added another screenshot with the same theme but in another view: notice how
the icons are now magenta

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-21 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=483614

--- Comment #11 from obno...@gmail.com ---
Created attachment 167576
  --> https://bugs.kde.org/attachment.cgi?id=167576&action=edit
Calendar view with plasma-test theme : notice white icons

Added a screenshot of the calendar view when using the modified plasma-test
theme

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-21 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=483614

--- Comment #10 from obno...@gmail.com ---
Created attachment 167575
  --> https://bugs.kde.org/attachment.cgi?id=167575&action=edit
Test theme based on Breeze (Dark) to reproduce the issue

Added a test theme based on Breeze with minimal modifications to reproduce the
issue.
Extract it into ~/.local/share/plasma/desktoptheme/ and enable it in system
settings.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-21 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=483614

--- Comment #9 from obno...@gmail.com ---
Hi Nick,
It should be as simple as
cd ~/.local/share/plasma/desktoptheme
git clone https://codeberg.org/obnosim/velours.git velours

Or you could download the latest release here: https://store.kde.org/p/998798
or search "velours" in system settings GetNewTheme window.

It tried some other third-party themes but I couldn't find any except mine that
uses an inverted scheme for buttons with backgrounds, so the issue is not
apparent in any of them because buttons with or without backgrounds have the
same foreground color.

Here is another way to debug the issue without needing a third-party theme.
# Create a local fork of Breeze:
cp /usr/share/plasma/desktoptheme/default
~/.local/share/plasma/desktoptheme/plasma-test
# Copy the colors file from Breeze Dark (since Breeze does not have one as it
uses the application colorscheme)
cp /usr/share/plasma/desktoptheme/breeze-dark/colors
~/.local/share/plasma/desktoptheme/plasma-test/colors
# Now edit in ~/.local/share/plasma/desktoptheme/plasma-test/colors the value
ForegroundNormal under the [Colors:Button] section to something easy to pick up
visually, like magenta:
ForegroundNormal=252,0,252
# Now edit ~/.local/share/plasma/desktoptheme/plasma-test/metadata.json to give
it a distinct name, then go enable the theme in system settings

Then you can do the following tests:
- open a calendar and notice that the buttons in the top-right corner, Settings
and Keep Open, which have no background by design, still have white icons
- switch to any system tray widget (for example: the volume control, or
klipper) and notice that the same buttons with no background now have magenta
icons
- open the logout prompt and notice that the "Ok" and "Cancel" buttons, which
do have a background, still have white text

Conclusion: some buttons use the color from "[Colors:Button] ForegroundNormal",
some don't, and it's not consistent: buttons without backgrounds don't all use
the same foreground color. I could not find an example of a button with a
background that does use "[Colors:Button] ForegroundNormal".

I'll upload an archive with that test project to make it more convenient and
screenshots so it's clearer.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-21 Thread Nick
https://bugs.kde.org/show_bug.cgi?id=483614

Nick  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 CC||mobile.har...@outlook.com
 Resolution|--- |WAITINGFORINFO

--- Comment #8 from Nick  ---
Hi - I've tried to duplicate this but I am not able to work out how to install
the theme you have used as an example. Are you able to confirm precisely which
folders it is installed in? Meanwhile I have tried installing a couple of
random themes via the Plasma Themes settings (Relax-Light-Global-6 and Ocean)
and my quick testing suggests they are OK. Could you try one of these too and
confirm if they work for you? Thanks, Nick.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=483614

--- Comment #7 from obno...@gmail.com ---
Created attachment 167219
  --> https://bugs.kde.org/attachment.cgi?id=167219&action=edit
Notification popup with colors file fix - not ok

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=483614

--- Comment #6 from obno...@gmail.com ---
Editing the theme's `colors` file to replace

[Colors:Button]
ForegroundNormal=0,0,0

with

[Colors:Button]
ForegroundNormal=255,255,255

fixes all the previous cases, however it creates new issues with other buttons
(the ones that are always visible and not just on hover) that are now white on
white where they were previously black on white.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=483614

--- Comment #5 from obno...@gmail.com ---
I renamed the issue after finding more places where it applies.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483614] Wrong colors throughout Plasma when using third-party themes

2024-03-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=483614

obno...@gmail.com changed:

   What|Removed |Added

Summary|Icons in tray windows and   |Wrong colors throughout
   |krunner use wrong   |Plasma when using
   |colorscheme |third-party themes

-- 
You are receiving this mail because:
You are watching all bug changes.