[systemsettings] [Bug 261344] "Adjust All Fonts" should make "Small" smaller than size of "Menu"
https://bugs.kde.org/show_bug.cgi?id=261344 --- Comment #12 from Nate Graham --- The fix implemented exactly what was requested: the small font value gets adjusted too, but it becomes smaller than the general font rather than using the same size. This whole UI needs to be re-visited IMO. For example perhaps we could have plus and minus buttons on the main page that simply increase or decrease all fonts from their current values. But until we do something like that, the fix for this *very old) but is appropriate IMO. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 261344] "Adjust All Fonts" should make "Small" smaller than size of "Menu"
https://bugs.kde.org/show_bug.cgi?id=261344 Wyatt Childers changed: What|Removed |Added CC||dark...@nearce.com --- Comment #11 from Wyatt Childers --- Hey Nate, I saw this in your blog post. I'm not sure this is the right fix. You can similarly adjust the monospace font to be non monospace. If I adjust all fonts, and one doesn't change with it, that's weird. I think there's a big difference between weirdness the user can go "oh I screwed up" and "why didn't it do what I told it to?". We've moved from the former here, to the later, and without any additional indication, or explanation, I really think this is going to surprise a lot of people. I'd probably have filed a bug had I changed my fonts, and noticed this without the explanation in your blog. IMO if this needs fixed it probably needs to be a multiselectable list or a table based UI where you can pick and choose what you're adjusting, one, or many, then adjust a selection at a time. This to me feels like, if I checked a "select all" on that tabular interface, and it unchecked the small font for me. It's just too strange even if at some level it makes sense. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 261344] "Adjust All Fonts" should make "Small" smaller than size of "Menu"
https://bugs.kde.org/show_bug.cgi?id=261344
Nate Graham changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/pla
||sma-desktop/24e4e15b7b043a0
||2dd6b7ea14b31b5737b76a79c
Version Fixed In||5.19.0
--- Comment #10 from Nate Graham ---
Git commit 24e4e15b7b043a02dd6b7ea14b31b5737b76a79c by Nate Graham.
Committed on 29/04/2020 at 15:12.
Pushed by ngraham into branch 'master'.
[kcms/fonts] When adjusting all fonts, keep Small font size smaller
Summary:
By default, the "Small" font is 2 points smaller than the "Normal" one. However
when you
adjust the size of all fonts, this 2-pts-smaller relationship is not preserved,
so the
Small font is set to the same size of the Normal font, defeating its reason for
existence.
This patch preserves the "2px smaller" relationship between the Small and
Normal fonts
when adjusting all of them at once.
FIXED-IN: 5.19.0
Test Plan: {F8258008}
Reviewers: #plasma, ahmadsamir, bport, cblack
Reviewed By: ahmadsamir, bport, cblack
Subscribers: cblack, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29156
M +11 -1kcms/fonts/fonts.cpp
https://commits.kde.org/plasma-desktop/24e4e15b7b043a02dd6b7ea14b31b5737b76a79c
--
You are receiving this mail because:
You are watching all bug changes.
[systemsettings] [Bug 261344] "Adjust All Fonts" should make "Small" smaller than size of "Menu"
https://bugs.kde.org/show_bug.cgi?id=261344 Nate Graham changed: What|Removed |Added Status|CONFIRMED |ASSIGNED Assignee|r...@kde.org |n...@kde.org --- Comment #9 from Nate Graham --- https://phabricator.kde.org/D29156 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 261344] "Adjust All Fonts" should make "Small" smaller than size of "Menu"
https://bugs.kde.org/show_bug.cgi?id=261344 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Keywords||usability Status|UNCONFIRMED |CONFIRMED CC||n...@kde.org --- Comment #8 from Nate Graham --- There is definitely a real bug here. The "Small" size is smaller than the other ones by default, and that distinction should be respected when changing all fonts. VDG members are currently discussing how to resolve this issue as part of a visual overhaul of the Fonts KCM. -- You are receiving this mail because: You are watching all bug changes.
