[systemsettings] [Bug 365363] Changing icons from System Settings is broken

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #5 from Wolfgang Bauer  ---
(In reply to Wolfgang Bauer from comment #3)
> Maybe that's related to the fact that running applications don't notice icon
> theme changes, this only affects newly started apps, i.e. maybe kcm_icons
> doesn't actually read the config file but rather asks kiconthemes what the
> current theme is (just guessing though, haven't looked at the code).

Indeed that's what it does:
- to "load" the settings it just calls KIconTheme::current()
- when saving, it writes it to kdeglobals, then deletes the icon cache, calls
KIconTheme::reconfigure() and emits changed signals.

I suspect this is a problem in kiconthemes then, e.g. that it doesn't correctly
reload the settings.

(In reply to Pulfer from comment #4)
> You will see that System Settings keeps
> inserting icons from the theme it was started with even after icon theme was
> changed (and back button was pressed).

I suppose that kiconthemes does that because it doesn't notice the settings
change...

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 365363] Changing icons from System Settings is broken

[Pulfer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #4 from Pulfer  ---
Created attachment 100052
  --> https://bugs.kde.org/attachment.cgi?id=100052=edit
Debug output for KIconLoaderPrivate::insertCachedPixmapWithPath

(In reply to Wolfgang Bauer from comment #3)
> I don't see "messed up icons" or a "damaged" icon cache though.

You can apply the attached debug patch to kiconthemes and then start
systemsettings from terminal. You will see that System Settings keeps inserting
icons from the theme it was started with even after icon theme was changed (and
back button was pressed).

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 365363] Changing icons from System Settings is broken

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365363

Wolfgang Bauer  changed:

   What|Removed |Added

 CC||wba...@tmo.at

--- Comment #3 from Wolfgang Bauer  ---
(In reply to Wolfgang Bauer from comment #2)
> I cannot reproduce this here on openSUSE with Plasma 5.7.0/Frameworks
> 5.24.0/Qt 5.6.1

Hm, actually I can.

It seems that the icon module isn't correctly loading the setting then if you
just re-enter it without quitting systemsettings5 completely.
Maybe that's related to the fact that running applications don't notice icon
theme changes, this only affects newly started apps, i.e. maybe kcm_icons
doesn't actually read the config file but rather asks kiconthemes what the
current theme is (just guessing though, haven't looked at the code).

I don't see "messed up icons" or a "damaged" icon cache though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 365363] Changing icons from System Settings is broken

[Pulfer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365363

Pulfer  changed:

   What|Removed |Added

 CC||wba...@tmo.at

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 365363] Changing icons from System Settings is broken

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365363

Wolfgang Bauer  changed:

   What|Removed |Added

 CC|wba...@tmo.at   |

--- Comment #2 from Wolfgang Bauer  ---
(In reply to Pulfer from comment #1)
> In fact, it saves the selected icon theme to ~/.config/kdeglobals properly
> right after applying it from SS -> Icons KCM. It's very easy to check...

I cannot reproduce this here on openSUSE with Plasma 5.7.0/Frameworks 5.24.0/Qt
5.6.1, and I have no idea how to debug this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 365363] Changing icons from System Settings is broken

[Pulfer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #1 from Pulfer  ---
(In reply to Wolfgang Bauer from comment #18)
> Rather sounds like a problem with actually saving the selected icon theme to
> kdeglobals to me...

In fact, it saves the selected icon theme to ~/.config/kdeglobals properly
right after applying it from SS -> Icons KCM. It's very easy to check...

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 365363] Changing icons from System Settings is broken

[Pulfer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365363

Pulfer  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 365363] Changing icons from System Settings is broken

[Pulfer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365363

Pulfer  changed:

   What|Removed |Added

 CC||j...@jriddell.org

-- 
You are receiving this mail because:
You are watching all bug changes.