[systemsettings] [Bug 386566] Use Anti-Aliasing Language Change

[Bhushan Shah]

https://bugs.kde.org/show_bug.cgi?id=386566

--- Comment #8 from Bhushan Shah  ---
Git commit 39c6facc51a807acc418a2e0dad6fda37d53071f by Bhushan Shah, on behalf
of Julian Wolff.
Committed on 27/05/2019 at 09:06.
Pushed by bshah into branch 'master'.

Parse global config files. Remove 'Vendor default' option. Fix changes not
recognized.

The fonts kcm did only parse a local config file. Global and default settings
were not recognized.
With this patch, all global config files are parsed before the local file is
parsed.
This allows us to drop the "Vendor default" option.

This patch also fixes some changes not recognized (apply button disabled).

Test Plan:

Delete `~/.config/fontconfig/fonts.conf` and `~/.config/kcmfonts` .
Run `kcmshell5 fonts`. The default/global settings should be displayed.
Change some settings. The apply button should be enabled.
Save. A new config file should be created.

Follow up of the D12925

M  +146  -81   kcms/fonts/fonts.cpp
M  +28   -16   kcms/fonts/fonts.h
M  +209  -95   kcms/fonts/kxftconfig.cpp
M  +11   -0kcms/fonts/kxftconfig.h
M  +13   -19   kcms/fonts/package/contents/ui/main.qml
M  +9-6kcms/fonts/previewimageprovider.cpp

https://commits.kde.org/plasma-desktop/39c6facc51a807acc418a2e0dad6fda37d53071f

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 386566] Use Anti-Aliasing Language Change

[Bhushan Shah]

https://bugs.kde.org/show_bug.cgi?id=386566

--- Comment #7 from Bhushan Shah  ---
Git commit 0dfeb1d61bddde7b721b1bb188692715f7c630fa by Bhushan Shah, on behalf
of Julian Wolff.
Committed on 23/05/2019 at 08:40.
Pushed by bshah into branch 'bshah/fixup-fonts'.

Parse global config files. Remove 'Vendor default' option. Fix changes not
recognized.

The fonts kcm did only parse a local config file. Global and default settings
were not recognized.
With this patch, all global config files are parsed before the local file is
parsed.
This allows us to drop the "Vendor default" option.

This patch also fixes some changes not recognized (apply button disabled).

Test Plan:

Delete `~/.config/fontconfig/fonts.conf` and `~/.config/kcmfonts` .
Run `kcmshell5 fonts`. The default/global settings should be displayed.
Change some settings. The apply button should be enabled.
Save. A new config file should be created.

Follow up of the D12925

M  +147  -82   kcms/fonts/fonts.cpp
M  +28   -16   kcms/fonts/fonts.h
M  +218  -102  kcms/fonts/kxftconfig.cpp
M  +11   -0kcms/fonts/kxftconfig.h
M  +13   -19   kcms/fonts/package/contents/ui/main.qml
M  +9-6kcms/fonts/previewimageprovider.cpp

https://commits.kde.org/plasma-desktop/0dfeb1d61bddde7b721b1bb188692715f7c630fa

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 386566] Use Anti-Aliasing Language Change

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=386566

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |INTENTIONAL

--- Comment #6 from Nate Graham  ---
https://phabricator.kde.org/D13593 was rejected; closing this.

As an alternative way forward, I would advocate for returning to an "advanced
settings" dialog or sub-page to hold these settings, and then we wouldn't have
to be so shy about presenting technical terms.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 386566] Use Anti-Aliasing Language Change

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=386566

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #5 from Nate Graham  ---
Patch submitted: https://phabricator.kde.org/D13593

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 386566] Use Anti-Aliasing Language Change

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=386566

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 386566] Use Anti-Aliasing Language Change

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=386566

--- Comment #4 from Nate Graham  ---
Oh, I actually don't like toggles either. I should have just said Radio
Buttons. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 386566] Use Anti-Aliasing Language Change

[Andres Betts]

https://bugs.kde.org/show_bug.cgi?id=386566

--- Comment #3 from Andres Betts  ---
The only thing is that there are others who don’t like toggles. Or switches.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 386566] Use Anti-Aliasing Language Change

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=386566

--- Comment #2 from Nate Graham  ---
I think we need to do some serious design work in #VDG and hopefully condense
this all a lot. My preference would be to get rid of the cryptic "System
Settings/Vendor Default" options and just have a Yes/No toggle here, which
would facilitate using radio buttons. And then we could turn it on by default.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 386566] Use Anti-Aliasing Language Change

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=386566

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

--- Comment #1 from Nate Graham  ---
The issue with this is that the pop-up menu has three options, not two. So we
can't cleanly replace it with a checkbox that expresses two states. We could do
it if we got rid of the "System Settings" option, which would turn it into a
straight-up enabled/disabled setting, and when we could use a checkbox.

I rather like this approach, since it's never been very clear what the "system
Settings" option did anyway.

Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.