[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED Version Fixed In|5.15.4 |5.15.5 Latest Commit|https://cgit.kde.org/system |https://commits.kde.org/sys |settings.git/commit/?h=Plas |temsettings/8b2e8d7eb61a82b |ma/5.15&id=8996c9bb8b248c23 |61df40489eb09ce297a21c3eb |b4b96c633e5baefedffb6e15| Resolution|--- |FIXED --- Comment #22 from Nate Graham --- Git commit 8b2e8d7eb61a82b61df40489eb09ce297a21c3eb by Nate Graham. Committed on 03/04/2019 at 15:33. Pushed by ngraham into branch 'Plasma/5.15'. Fix invisible monochrome icons in Icon View tooltips too This is a straight port of 8996c9bb8b248c23b4b96c633e5baefedffb6e15 FIXED-IN: 5.15.5 M +20 -1app/ToolTips/tooltipmanager.cpp https://commits.kde.org/systemsettings/8b2e8d7eb61a82b61df40489eb09ce297a21c3eb -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 Nate Graham changed: What|Removed |Added Status|REOPENED|CONFIRMED --- Comment #21 from Nate Graham --- Oh jeez, icon view has its own tooltip code. :/ Fixing that too. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #20 from Patrick Silva --- Created attachment 119217 --> https://bugs.kde.org/attachment.cgi?id=119217&action=edit icon view, plasma 5.15.4 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #19 from Nate Graham --- New screenshot please. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 Patrick Silva changed: What|Removed |Added Version|5.15.3 |5.15.4 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 Patrick Silva changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #18 from Patrick Silva --- bug persists when icon view is used. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 Nate Graham changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In||5.15.4 Status|CONFIRMED |RESOLVED Latest Commit||https://cgit.kde.org/system ||settings.git/commit/?h=Plas ||ma/5.15&id=8996c9bb8b248c23 ||b4b96c633e5baefedffb6e15 --- Comment #17 from Nate Graham --- Fixed in https://phabricator.kde.org/D19834 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #16 from Nate Graham --- I'll give it a try tomorrow or the next day if I can rustle up the time... -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #15 from Nate Graham --- This can be fixed with code similar to https://cgit.kde.org/kinfocenter.git/commit/?id=23fa369831709f43a3100476b00ced10a1123f7f -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 Patrick Silva changed: What|Removed |Added Version|5.14.4 |5.15.3 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748
--- Comment #14 from Nate Graham ---
Git commit a7141be3091f46a2cfac3b1a6cfc6c78b2d684ed by Nate Graham.
Committed on 06/02/2019 at 22:46.
Pushed by ngraham into branch 'master'.
Use colorful icon in KCM
Summary:
Use a nice new colorful icon.
Master only since this icon is provided by a symlink created in Frameworks
5.56.
Test Plan:
Before: {F6592327, size=full}
After: {F6592328, size=full}
Reviewers: #vdg, ndavis
Reviewed By: #vdg, ndavis
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18800
M +1-1src/user_manager.desktop
https://commits.kde.org/user-manager/a7141be3091f46a2cfac3b1a6cfc6c78b2d684ed
--
You are receiving this mail because:
You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #13 from Nate Graham --- Or alternatively we could just hardcode a 24px size, which bypasses these problems entirely, which is what the equivalent tooltip in KInfoCenter does. Patch: https://phabricator.kde.org/D18797 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #12 from Nate Graham --- For subcategories, the tooltip uses 22px icons. When there is no 22px version of the icon, it downscales the 32px color version, so there is no problem. But for icons with a 22px monochrome version that, that's shown instead. So this is caused by a combination of inter-related issues: 1. The tooltip's background is dark and the icons are not hinted to reverse their color scheme, so when using Breeze light, any monochrome icons will be the same color as the tooltip and be invisible. 2. Some of the icons here have no 32px color version, only a 22px monochrome version. 3. Some of the icons have both 32px color versions and 22px monochrome versions. --- #1 is fixable with code changes to make monochrome icons be color-scheme-aware in the tooltip, but this will still result in some color icons and some monochrome icons, which is not the visual effect we're looking for. So I think the real fix here is to make sure that all icons are colorized, not monochrome. This will involve creating color versions of the icons that are currently monochrome (fixing #2), and removing the monochrome versions of the icons that have 32px color versions (fixing #3) Adding as an action item for https://phabricator.kde.org/T10273. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 Nate Graham changed: What|Removed |Added CC||n...@kde.org Ever confirmed|0 |1 Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=386040 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 Patrick Silva changed: What|Removed |Added Version|5.14.0 |5.14.4 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 Patrick Silva changed: What|Removed |Added Version|5.13.0 |5.14.0 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 Dr. Chapatin changed: What|Removed |Added Version|5.12.4 |5.13.0 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 Dr. Chapatin changed: What|Removed |Added Version|5.12.0 |5.12.4 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 Dr. Chapatin changed: What|Removed |Added Version|unspecified |5.12.0 Platform|Other |Archlinux Packages --- Comment #11 from Dr. Chapatin --- Same thing in plasma 5.12, Arch Linux. Breeze dark is not affected. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #10 from Dr. Chapatin --- Created attachment 108795 --> https://bugs.kde.org/attachment.cgi?id=108795&action=edit removable devices -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #9 from Dr. Chapatin --- Created attachment 108794 --> https://bugs.kde.org/attachment.cgi?id=108794&action=edit power management -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #8 from Dr. Chapatin --- Created attachment 108793 --> https://bugs.kde.org/attachment.cgi?id=108793&action=edit multimedia -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #7 from Dr. Chapatin --- Created attachment 108792 --> https://bugs.kde.org/attachment.cgi?id=108792&action=edit input devices -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #6 from Dr. Chapatin --- Created attachment 108791 --> https://bugs.kde.org/attachment.cgi?id=108791&action=edit bluetooth -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #5 from Dr. Chapatin --- Created attachment 108790 --> https://bugs.kde.org/attachment.cgi?id=108790&action=edit account details -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #4 from Dr. Chapatin --- Created attachment 108789 --> https://bugs.kde.org/attachment.cgi?id=108789&action=edit startup and shutdown -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #3 from Dr. Chapatin --- Created attachment 108788 --> https://bugs.kde.org/attachment.cgi?id=108788&action=edit window management -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #2 from Dr. Chapatin --- Created attachment 108787 --> https://bugs.kde.org/attachment.cgi?id=108787&action=edit desktop behavior -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 386748] Some icons are missing in tooltips
https://bugs.kde.org/show_bug.cgi?id=386748 --- Comment #1 from Dr. Chapatin --- Created attachment 108786 --> https://bugs.kde.org/attachment.cgi?id=108786&action=edit fonts -- You are receiving this mail because: You are watching all bug changes.
