[systemsettings] [Bug 403366] No apply/discard prompt shows up when I leave sddm_kcm after uncheck "Auto-login" without apply the change

2019-03-25 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=403366

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/sdd |https://commits.kde.org/sdd
   |m-kcm/ed3decc06e387217bc131 |m-kcm/0c76098e80c8ee61c7da9
   |8597ba1e97183d3b9b3 |d85313461fc8a040651

--- Comment #3 from Albert Astals Cid  ---
Git commit 0c76098e80c8ee61c7da9d85313461fc8a040651 by Albert Astals Cid, on
behalf of Laurent Montel.
Committed on 25/03/2019 at 22:58.
Pushed by aacid into branch 'Plasma/5.15'.

Fixed issue causing changed signal to be called with false argument

Summary:
 AdvanceConfig::changed signal is called with changed=false arguement when
QGroupBox::clicked is called with checked=false causing the Apply button to
remain disabled.

Test Plan:
1. Open SDDM settings
2. Enable auto-login, save and close.
3. Open SDDM settings again
4. Uncheck auto-login

Apply button should now be enabled.
Same steps for Relogin after quit checkbox.

Reviewers: mlaurent

Reviewed By: mlaurent

Subscribers: mlaurent, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19959

(cherry picked from commit ed3decc06e387217bc1318597ba1e97183d3b9b3)

M  +4-2src/advanceconfig.cpp

https://commits.kde.org/sddm-kcm/0c76098e80c8ee61c7da9d85313461fc8a040651

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 403366] No apply/discard prompt shows up when I leave sddm_kcm after uncheck "Auto-login" without apply the change

2019-03-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=403366

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.16.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 403366] No apply/discard prompt shows up when I leave sddm_kcm after uncheck "Auto-login" without apply the change

2019-03-23 Thread Laurent Montel
https://bugs.kde.org/show_bug.cgi?id=403366

Laurent Montel  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/sdd
   ||m-kcm/ed3decc06e387217bc131
   ||8597ba1e97183d3b9b3
 Status|REPORTED|RESOLVED

--- Comment #2 from Laurent Montel  ---
Git commit ed3decc06e387217bc1318597ba1e97183d3b9b3 by Laurent Montel.
Committed on 23/03/2019 at 08:00.
Pushed by mlaurent into branch 'master'.

Fixed issue causing changed signal to be called with false argument

Summary:
 AdvanceConfig::changed signal is called with changed=false arguement when
QGroupBox::clicked is called with checked=false causing the Apply button to
remain disabled.

Test Plan:
1. Open SDDM settings
2. Enable auto-login, save and close.
3. Open SDDM settings again
4. Uncheck auto-login

Apply button should now be enabled.
Same steps for Relogin after quit checkbox.

Reviewers: mlaurent

Reviewed By: mlaurent

Subscribers: mlaurent, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19959

M  +4-2src/advanceconfig.cpp

https://commits.kde.org/sddm-kcm/ed3decc06e387217bc1318597ba1e97183d3b9b3

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 403366] No apply/discard prompt shows up when I leave sddm_kcm after uncheck "Auto-login" without apply the change

2019-03-16 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=403366

Patrick Silva  changed:

   What|Removed |Added

Summary|No apply/discard prompt |No apply/discard prompt
   |shows up when I leave   |shows up when I leave
   |sddm_kcm after uncheck  |sddm_kcm after uncheck
   |"Auto-login" without apply  |"Auto-login" without apply
   |the setting |the change
Version|5.15.0  |5.15.3

-- 
You are receiving this mail because:
You are watching all bug changes.