[systemsettings] [Bug 405030] Start search with CTRL+F
https://bugs.kde.org/show_bug.cgi?id=405030
Nate Graham changed:
What|Removed |Added
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/sys
||temsettings/4a82adba76df92d
||19337e7c87b3c1121433cf6f8
Version Fixed In||5.18
Status|CONFIRMED |RESOLVED
--- Comment #4 from Nate Graham ---
Git commit 4a82adba76df92d19337e7c87b3c1121433cf6f8 by Nate Graham.
Committed on 04/01/2020 at 17:34.
Pushed by ngraham into branch 'master'.
Fix Ctrl+F shortcut conflict
Summary:
The base app was always setting Ctrl+F as a search shortcut, even when the
toolbar upon
which the search field lives was not visible. This caused the dreaded
"ambiguous shortcut"
dialog to appear. The patch fixes the issue by setting the shortcut only when
the toolbar
contains a search field, and unsetting it when the toolbar is hidden.
FIXED-IN: 5.18
Test Plan:
Hit {key Ctrl F} in both sidebar and icons view. In both cases, it focuses the
search
field.
Reviewers: #plasma, GB_2, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26305
M +7-1app/SettingsBase.cpp
https://commits.kde.org/systemsettings/4a82adba76df92d19337e7c87b3c1121433cf6f8
--
You are receiving this mail because:
You are watching all bug changes.
[systemsettings] [Bug 405030] Start search with CTRL+F
https://bugs.kde.org/show_bug.cgi?id=405030 --- Comment #3 from Nate Graham --- Took another look and figured out how to fix this: https://phabricator.kde.org/D26305 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 405030] Start search with CTRL+F
https://bugs.kde.org/show_bug.cgi?id=405030 Thiago Sueto changed: What|Removed |Added CC||herzensch...@gmail.com --- Comment #2 from Thiago Sueto --- As an addendum, currently pressing Ctrl+F on System Settings will show: >Ambiguous shortcut detected >The key sequence 'Ctrl+F' is ambiguous. Use 'Configure Shortcuts' >from the 'Settings' menu to solve the ambiguity. >No action will be triggered. I'm using Operating System: Kubuntu 19.04 KDE Plasma Version: 5.16.90 KDE Frameworks Version: 5.62.0 Qt Version: 5.12.2 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 405030] Start search with CTRL+F
https://bugs.kde.org/show_bug.cgi?id=405030 Alexander Potashev changed: What|Removed |Added CC||aspotas...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 405030] Start search with CTRL+F
https://bugs.kde.org/show_bug.cgi?id=405030 --- Comment #1 from Nate Graham --- This is still broken, because there's a Kirigami search field that has built-in logic to intercept Ctrl+F, but the base app re-implements this itself (for the non-sidebar views), so the two conflict. We can't just remove the QWidgets searchfield logic because some people still using icon view are using it. Also, even if you do that, then for reasons I have not discovered, the Kirigami searchfield receives focus when you hit Ctrl+F, but does not actually accept text input until you manually click in it. It's odd. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 405030] Start search with CTRL+F
https://bugs.kde.org/show_bug.cgi?id=405030 Nate Graham changed: What|Removed |Added CC||n...@kde.org Status|REPORTED|CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 405030] Start search with CTRL+F
https://bugs.kde.org/show_bug.cgi?id=405030 Nate Graham changed: What|Removed |Added Assignee|plasma-b...@kde.org |notm...@gmail.com Component|general |sidebarview -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 405030] Start search with CTRL+F
https://bugs.kde.org/show_bug.cgi?id=405030 dagobert...@mailbox.org changed: What|Removed |Added Platform|Other |Neon Packages -- You are receiving this mail because: You are watching all bug changes.
