[systemsettings] [Bug 417747] Size of standalone User Feedback kcm is too small if slider is set to rightmost position

2020-02-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417747

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In|5.18.1  |5.18.2
  Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-workspace/285155fad1f30 |sma-workspace/be4a0ae13a52a
   |c35476c074d470cde6f253d3e9b |361cb413a35fe9b08d326240f9f
 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #12 from Nate Graham  ---
Git commit be4a0ae13a52a361cb413a35fe9b08d326240f9f by Nate Graham.
Committed on 19/02/2020 at 21:38.
Pushed by ngraham into branch 'Plasma/5.18'.

[kcms/feedback] Increase default window height a bit more
FIXED-IN: 5.18.2

M  +1-1kcms/feedback/package/contents/ui/main.qml

https://commits.kde.org/plasma-workspace/be4a0ae13a52a361cb413a35fe9b08d326240f9f

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417747] Size of standalone User Feedback kcm is too small if slider is set to rightmost position

2020-02-19 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=417747

Christoph Feck  changed:

   What|Removed |Added

 CC||cf...@kde.org

--- Comment #11 from Christoph Feck  ---
Btw, the same issue is with users that have a 1366x786 screen, but need to use
a large font size due to eyesight. You won't be able to cramp much lines in
such a screen, but scrollbars to the rescue! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417747] Size of standalone User Feedback kcm is too small if slider is set to rightmost position

2020-02-19 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=417747

--- Comment #10 from Christoph Feck  ---
Nate, you are free to make the window larger than 600 pix on initial open. What
we usually reject is creating user interfaces that have a minimumSize that
demands a larger size. We have scrollbars to handle small screens, and if the
window needs more room, it will automatically use these.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417747] Size of standalone User Feedback kcm is too small if slider is set to rightmost position

2020-02-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417747

--- Comment #9 from Nate Graham  ---
Argh you guys are killing me lol!

I could go up to `implicitHeight: Kirigami.Units.gridUnit * 34` (up from 33),
but then the default height would be taller then 600px which would make the
bottom button row cut off on some old crappy netbook screens. But maybe we
could ignore those?

Or maybe we could just give up on kcmshell and fix this whole dang class of bug
once and for all by just opening System Settings itself (Bug 402790).

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417747] Size of standalone User Feedback kcm is too small if slider is set to rightmost position

2020-02-19 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=417747

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #8 from Kai Uwe Broulik  ---
Same for me. I have so much crap in there it would hardly fit on screen at any
size :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417747] Size of standalone User Feedback kcm is too small if slider is set to rightmost position

2020-02-19 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=417747

--- Comment #7 from Patrick Silva  ---
(In reply to Nate Graham from comment #6)
> 1080p?

yes

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417747] Size of standalone User Feedback kcm is too small if slider is set to rightmost position

2020-02-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417747

--- Comment #6 from Nate Graham  ---
1080p?

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417747] Size of standalone User Feedback kcm is too small if slider is set to rightmost position

2020-02-19 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=417747

--- Comment #5 from Patrick Silva  ---
(In reply to Nate Graham from comment #4)
> Works for me. What's your screen size?

23 inches

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417747] Size of standalone User Feedback kcm is too small if slider is set to rightmost position

2020-02-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417747

--- Comment #4 from Nate Graham  ---
Works for me. What's your screen size?

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417747] Size of standalone User Feedback kcm is too small if slider is set to rightmost position

2020-02-19 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=417747

Patrick Silva  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED
   Platform|Other   |Archlinux Packages
Version|5.18.0  |5.18.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417747] Size of standalone User Feedback kcm is too small if slider is set to rightmost position

2020-02-19 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=417747

--- Comment #3 from Patrick Silva  ---
Created attachment 126160
  --> https://bugs.kde.org/attachment.cgi?id=126160=edit
screen recording on Plasma 5.18.1

Not completely fixed on Plasma 5.18.1.

Operating System: Arch Linux 
KDE Plasma Version: 5.18.1
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417747] Size of standalone User Feedback kcm is too small if slider is set to rightmost position

2020-02-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417747

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||5.18.1
  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/285155fad1f30
   ||c35476c074d470cde6f253d3e9b

--- Comment #2 from Nate Graham  ---
Git commit 285155fad1f30c35476c074d470cde6f253d3e9b by Nate Graham.
Committed on 17/02/2020 at 00:34.
Pushed by ngraham into branch 'Plasma/5.18'.

[kcms/feedback] Improve default kcmshell window size

Summary:
FIXED-IN: 5.18.1

Test Plan:
Better default size when showing the most info: {F8107763}

However window is too now big when showing the least amount of info: {F8107762}

...But that seems kind of unavoidable unless we want to dynamically resize the
window,
which people seem to hate.

Reviewers: #plasma, #vdg, apol

Reviewed By: apol

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27448

M  +2-1kcms/feedback/package/contents/ui/main.qml

https://commits.kde.org/plasma-workspace/285155fad1f30c35476c074d470cde6f253d3e9b

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417747] Size of standalone User Feedback kcm is too small if slider is set to rightmost position

2020-02-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417747

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
  Component|general |kcm_feedback
   Assignee|plasma-b...@kde.org |aleix...@gmail.com
 Ever confirmed|0   |1
   Severity|normal  |minor
 CC||n...@kde.org,
   ||plasma-b...@kde.org

--- Comment #1 from Nate Graham  ---
Patch: https://phabricator.kde.org/D27448

-- 
You are receiving this mail because:
You are watching all bug changes.