[systemsettings] [Bug 436816] If a shortcut component is deleted while being viewed, its name sometimes becomes unreadable

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=436816

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||5.23
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-desktop/commit/16
   ||98d42f525049e2bfc402b52c0e4
   ||642060ba5b4
 Status|ASSIGNED|RESOLVED

--- Comment #4 from Nate Graham  ---
Git commit 1698d42f525049e2bfc402b52c0e4642060ba5b4 by Nate Graham.
Committed on 13/05/2021 at 13:28.
Pushed by ngraham into branch 'master'.

[kcms/keys] Port sidebar list item to Kirigami.BasicListItem

This commit ports the Shortcuts KCM's sidebar list items to use
Kirigami.BasicListItem, which fixes a binding loops and some bugs
related to incorrect colors caused by the custom content item, and
gets rid of another bespoke list item implementation.  The embedded
hover ToolButtons are changed to regular Buttons to avoid losing their
hover appearance entirely due to differences in BasicListItem's
coloration semantics.

The result has minor visual differences but is functionally the same.
FIXED-IN: 5.23

M  +25   -35   kcms/keys/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/1698d42f525049e2bfc402b52c0e4642060ba5b4

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 436816] If a shortcut component is deleted while being viewed, its name sometimes becomes unreadable

2021-05-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=436816

--- Comment #3 from Nate Graham  ---
Git commit a73ce76190d2ba08bf3c0f492e9f06a67beeceac by Nate Graham.
Committed on 11/05/2021 at 22:56.
Pushed by ngraham into branch 'master'.

Add new fadeContent property to BasicListItem

This new property can be used to make the main content of a
BasicListitem have a disabled or de-emphasized look while preserving
full opacity for any leading or trailing items.

M  +15   -3src/controls/BasicListItem.qml

https://invent.kde.org/frameworks/kirigami/commit/a73ce76190d2ba08bf3c0f492e9f06a67beeceac

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 436816] If a shortcut component is deleted while being viewed, its name sometimes becomes unreadable

2021-05-10 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=436816

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #2 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/460

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 436816] If a shortcut component is deleted while being viewed, its name sometimes becomes unreadable

2021-05-10 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=436816

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Nate Graham  ---
Can confirm. This is because this list uses totally custom list items with
coloration heuristics copied from elsewhere which are not quite in sync with
the general stuff. It needs to be ported to use Kirigami.BasicListItem. I tried
a few weeks ago but got stuck on the inability to keep the undo icon at full
opacity in this state without it feeling hacky. Maybe I'll try again.

-- 
You are receiving this mail because:
You are watching all bug changes.