[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 Nate Graham changed: What|Removed |Added Version Fixed In||5.24.7 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-thunderbolt/commi |ma/plasma-thunderbolt/commi |t/ad691a62fbb3f4d05ef7d273e |t/6ea3f5393e84ce9122f081c9b |b4f7dcebbfad33d |5c5ae47ee81f752 --- Comment #18 from Nate Graham --- Git commit 6ea3f5393e84ce9122f081c9b5c5ae47ee81f752 by Nate Graham, on behalf of David Edmundson. Committed on 28/09/2022 at 15:55. Pushed by ngraham into branch 'Plasma/5.24'. Avoid combining smart pointers and qobject parent ownership Devices are stored as QSharedPointer mDevices. If something has the memory managed explicitly we don't want QObject parents to also try and do the same job. (cherry picked from commit 09c37c1c312991d08c10c7af94a83902150cb3ad) M +2-2src/lib/device.cpp M +1-1src/lib/device.h M +2-2src/lib/manager.cpp https://invent.kde.org/plasma/plasma-thunderbolt/commit/6ea3f5393e84ce9122f081c9b5c5ae47ee81f752 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-thunderbolt/commi |ma/plasma-thunderbolt/commi |t/09c37c1c312991d08c10c7af9 |t/ad691a62fbb3f4d05ef7d273e |4a83902150cb3ad |b4f7dcebbfad33d --- Comment #17 from Nate Graham --- Git commit ad691a62fbb3f4d05ef7d273eb4f7dcebbfad33d by Nate Graham, on behalf of David Edmundson. Committed on 28/09/2022 at 15:54. Pushed by ngraham into branch 'Plasma/5.26'. Avoid combining smart pointers and qobject parent ownership Devices are stored as QSharedPointer mDevices. If something has the memory managed explicitly we don't want QObject parents to also try and do the same job. (cherry picked from commit 09c37c1c312991d08c10c7af94a83902150cb3ad) M +2-2src/lib/device.cpp M +1-1src/lib/device.h M +2-2src/lib/manager.cpp https://invent.kde.org/plasma/plasma-thunderbolt/commit/ad691a62fbb3f4d05ef7d273eb4f7dcebbfad33d -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 Nate Graham changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/plas ||ma/plasma-thunderbolt/commi ||t/09c37c1c312991d08c10c7af9 ||4a83902150cb3ad Resolution|--- |FIXED --- Comment #16 from Nate Graham --- Git commit 09c37c1c312991d08c10c7af94a83902150cb3ad by Nate Graham, on behalf of David Edmundson. Committed on 28/09/2022 at 15:44. Pushed by ngraham into branch 'master'. Avoid combining smart pointers and qobject parent ownership Devices are stored as QSharedPointer mDevices. If something has the memory managed explicitly we don't want QObject parents to also try and do the same job. M +2-2src/lib/device.cpp M +1-1src/lib/device.h M +2-2src/lib/manager.cpp https://invent.kde.org/plasma/plasma-thunderbolt/commit/09c37c1c312991d08c10c7af94a83902150cb3ad -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 fw.smi...@gmail.com changed: What|Removed |Added CC||fw.smi...@gmail.com --- Comment #15 from fw.smi...@gmail.com --- *** Bug 459779 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 David Edmundson changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #13 from David Edmundson --- Code path (presumably) is: - Someone else owns a reference to the device - Manager::~Manager runs. The list clears - QObject::~QObject of the manager runs - We delete a child object owning a reference to the device - We then delete the Device which is a child In any case it's an easy fix. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #14 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-thunderbolt/-/merge_requests/11 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 Nate Graham changed: What|Removed |Added CC||aleix...@kde.org --- Comment #12 from Nate Graham --- *** Bug 427516 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 Nate Graham changed: What|Removed |Added Severity|normal |crash -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=426047 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 --- Comment #11 from Jonathan Wakely --- Created attachment 150185 --> https://bugs.kde.org/attachment.cgi?id=150185=edit valgrind log of 'kcmshell5 bolt' Valgrind shows the destruction of the bold module is riddled with bugs, but possibly all caused by one double free. Fixing that might make all the later errors go away. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192
--- Comment #10 from Jonathan Wakely ---
The crash is an abort in glibc caused by double free on line 2104 of
qt5-qtbase-5.15.3-3.fc36.x86_64/src/corelib/kernel/qobject.cpp
2099// don't use qDeleteAll as the destructor of the child might
2100// delete siblings
2101for (int i = 0; i < children.count(); ++i) {
2102currentChildBeingDeleted = children.at(i);
2103children[i] = 0;
2104delete currentChildBeingDeleted;
2105}
2106children.clear();
The comment suggests that when a child deletes a sibling it fails to set that
entry in the vector to a null pointer, so that the parent subsequently tries to
delete that pointer again.
--
You are receiving this mail because:
You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 Jonathan Wakely changed: What|Removed |Added CC||zi...@kayari.org --- Comment #9 from Jonathan Wakely --- Created attachment 150184 --> https://bugs.kde.org/attachment.cgi?id=150184=edit GDB backtrace of crash 100% reproducible with Fedora RPMs too, using kde-cli-tools-5.24.5-1.fc36.x86_64 in an X11 plasma session. Running kcmshell5 bolt and just clicking the "Close" button shows: Previously registered enum will be overwritten due to name clash: Bolt.Secure Possible conflicting items: Bolt.Auth.Secure from scope Bolt injected by Bolt Bolt.Security.Secure from scope Bolt injected by Bolt file:///usr/lib64/qt5/qml/org/kde/kirigami.2/PlaceholderMessage.qml:235:5: QML Heading: Binding loop detected for property "verticalAlignment" kf.kirigami: The Theme singleton is deprecated (since 5.39). Import Kirigami 2.2 or higher and use the attached property instead. file:///usr/share/kpackage/kcms/kcm_bolt/contents/ui/DeviceList.qml:24:13: QML RowLayout: Cannot anchor to an item that isn't a parent or sibling. double free or corruption (out) KCrash: Application 'kcmshell5' crashing... KCrash: Attempting to start /usr/libexec/drkonqi Alarm clock -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 - changed: What|Removed |Added CC||just4privacythings@posteo.m ||e -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 --- Comment #8 from Sebastian --- Created attachment 145755 --> https://bugs.kde.org/attachment.cgi?id=145755=edit valgrind output valgrind output of the crash -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 --- Comment #7 from Sebastian --- Created attachment 145754 --> https://bugs.kde.org/attachment.cgi?id=145754=edit gdb backtrace GDB backtrace of the crash -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 Sebastian changed: What|Removed |Added CC||bugreports.nm...@aleeas.com --- Comment #6 from Sebastian --- Happens for me too on: SOFTWARE/OS VERSIONS KDE Neon 5.23 as of 2022-01-22 KDE Plasma Version: 5.23.5 KDE Frameworks Version: 5.90.0 Qt Version: 5.15.3 using X11 I'll add gdb and valgrind output as required by the guidelines. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439192] System settings crashes in Bolt::Manager::~Manager() after navigating away from thunderbolt page
https://bugs.kde.org/show_bug.cgi?id=439192 Nate Graham changed: What|Removed |Added CC||n...@kde.org Assignee|plasma-b...@kde.org |dvra...@kde.org Summary|System settings window |System settings crashes in |closes after navigating |Bolt::Manager::~Manager() |away from thunderbolt page |after navigating away from ||thunderbolt page Component|general |kcm_thunderbolt --- Comment #5 from Nate Graham --- Looks like it's crashing in teardown. -- You are receiving this mail because: You are watching all bug changes.
