[systemsettings] [Bug 443656] KDE Settings crash when adding custom shortcut *after* removing one
https://bugs.kde.org/show_bug.cgi?id=443656 Nate Graham changed: What|Removed |Added Version Fixed In|5.23.5 |5.23.4 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 443656] KDE Settings crash when adding custom shortcut *after* removing one
https://bugs.kde.org/show_bug.cgi?id=443656 Nate Graham changed: What|Removed |Added Component|generic-crash |kcm_khotkeys Assignee|plasma-b...@kde.org |k...@michael-jansen.biz CC||plasma-b...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 443656] KDE Settings crash when adding custom shortcut *after* removing one
https://bugs.kde.org/show_bug.cgi?id=443656 Harald Sitter changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/khotkeys/commit/97f9339f |ma/khotkeys/commit/a4137ac8 |d96d97e012347f8f7fca987bbe4 |f7b18824568fbee0f3e2dce7551 |fca0d |841b7 --- Comment #3 from Harald Sitter --- Git commit a4137ac8f7b18824568fbee0f3e2dce7551841b7 by Harald Sitter. Committed on 15/11/2021 at 07:02. Pushed by sitter into branch 'Plasma/5.23'. when deleting an entry, also delete the widgets previously what would happen is that KCMHotkeys::currentChanged would run, find the new index (-1,-1) now invalid and show the global settings instead. this however left the simple_action's underlying widgets still sitting around referring to the previous index AND holding a dangling trigger point that would eventually crash when the simple_action would be poked by anything instead force unset the internal state of the simple_action when showing the global settings. FIXED-IN: 5.23.5 (cherry picked from commit 97f9339fd96d97e012347f8f7fca987bbe4fca0d) M +3-0kcm_hotkeys/kcm_hotkeys.cpp M +11 -7kcm_hotkeys/simple_action_data_widget.cpp M +3-0kcm_hotkeys/simple_action_data_widget.h M +8-0kcm_hotkeys/triggers/trigger_widget_base.cpp https://invent.kde.org/plasma/khotkeys/commit/a4137ac8f7b18824568fbee0f3e2dce7551841b7 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 443656] KDE Settings crash when adding custom shortcut *after* removing one
https://bugs.kde.org/show_bug.cgi?id=443656 Harald Sitter changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/khotkeys/commit/97f9339f ||d96d97e012347f8f7fca987bbe4 ||fca0d Version Fixed In||5.23.5 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #2 from Harald Sitter --- Git commit 97f9339fd96d97e012347f8f7fca987bbe4fca0d by Harald Sitter. Committed on 15/11/2021 at 06:59. Pushed by sitter into branch 'master'. when deleting an entry, also delete the widgets previously what would happen is that KCMHotkeys::currentChanged would run, find the new index (-1,-1) now invalid and show the global settings instead. this however left the simple_action's underlying widgets still sitting around referring to the previous index AND holding a dangling trigger point that would eventually crash when the simple_action would be poked by anything instead force unset the internal state of the simple_action when showing the global settings. FIXED-IN: 5.23.5 M +3-0kcm_hotkeys/kcm_hotkeys.cpp M +11 -7kcm_hotkeys/simple_action_data_widget.cpp M +3-0kcm_hotkeys/simple_action_data_widget.h M +8-0kcm_hotkeys/triggers/trigger_widget_base.cpp https://invent.kde.org/plasma/khotkeys/commit/97f9339fd96d97e012347f8f7fca987bbe4fca0d -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 443656] KDE Settings crash when adding custom shortcut *after* removing one
https://bugs.kde.org/show_bug.cgi?id=443656 Nate Graham changed: What|Removed |Added Component|general |generic-crash CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 443656] KDE Settings crash when adding custom shortcut *after* removing one
https://bugs.kde.org/show_bug.cgi?id=443656 Bug Janitor Service changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED --- Comment #1 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/khotkeys/-/merge_requests/17 -- You are receiving this mail because: You are watching all bug changes.
