[systemsettings] [Bug 458572] Add toggle to show all KWin scripts regardless of X-KWin-Exclude-Listing state

2023-07-18 Thread Alexander Lohnau
https://bugs.kde.org/show_bug.cgi?id=458572

Alexander Lohnau  changed:

   What|Removed |Added

   Version Fixed In||6.0
  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/-/commit/33e32f293b
   ||c8c77fe06089e99ade6b0b20705
   ||de4
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Alexander Lohnau  ---
Git commit 33e32f293bc8c77fe06089e99ade6b0b20705de4 by Alexander Lohnau.
Committed on 18/07/2023 at 08:51.
Pushed by alex into branch 'master'.

Remove X-KWin-Exclude-Listing metadata flag

We only have one KWin script making use of this and that one is shown
regardless. The issue with this flag is that it will hide scripts from
the user without a possibility to see them.

For effects, we have quite a few internal ones and a possibility to show
even hidden ones. But we can not reuse this logic for the scripts.
FIXED-IN: 6.0

M  +1-5src/kcms/scripts/kwinscriptsdata.cpp
M  +0-4src/kcms/tabbox/main.cpp
M  +0-1src/plugins/desktopchangeosd/package/metadata.json

https://invent.kde.org/plasma/kwin/-/commit/33e32f293bc8c77fe06089e99ade6b0b20705de4

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 458572] Add toggle to show all KWin scripts regardless of X-KWin-Exclude-Listing state

2023-07-17 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=458572

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #6 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/4253

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 458572] Add toggle to show all KWin scripts regardless of X-KWin-Exclude-Listing state

2023-06-23 Thread Alexander Lohnau
https://bugs.kde.org/show_bug.cgi?id=458572

--- Comment #5 from Alexander Lohnau  ---
I don't quite get the point, one KWin plugin uses the exclude listing flag
(though it did not work), but nobody seemed bothered by it.
If we offer the internal flag for effects, can't third parties just set the
flag themselves?

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 458572] Add toggle to show all KWin scripts regardless of X-KWin-Exclude-Listing state

2023-06-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=458572

--- Comment #4 from Nate Graham  ---
For desktop effects, there's the ability to mark them as "internal" and then
they get hidden by default, but adventurous people can show them with a simple
UI in the KCM itself. Maybe it would make sense to do something like that here
too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 458572] Add toggle to show all KWin scripts regardless of X-KWin-Exclude-Listing state

2023-06-15 Thread Alexander Lohnau
https://bugs.kde.org/show_bug.cgi?id=458572

Alexander Lohnau  changed:

   What|Removed |Added

   Assignee|kwin-bugs-n...@kde.org  |alexander.loh...@gmx.de

--- Comment #3 from Alexander Lohnau  ---
Maybe we can reconsider this for KF6. I have reached out to the Bismuth people
with the suggestion of only hiding the KCM of the script and not the entire
script.

@Nate, then the "Desktop Change OSD" entry will show in the KCM (though it
appears to do so now anyway?). Maybe we can interpret this as a "it is broken
now, but nobody seemed to care, so we could keep it as it is".

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 458572] Add toggle to show all KWin scripts regardless of X-KWin-Exclude-Listing state

2022-09-01 Thread Alexander Lohnau
https://bugs.kde.org/show_bug.cgi?id=458572

--- Comment #2 from Alexander Lohnau  ---
See
https://invent.kde.org/plasma/kwin/-/commit/95ac5fa2cef607809189ca73cf05ef8903c19291
for the rationale.
Also, please see https://github.com/Bismuth-Forge/bismuth/issues/191.

>This could potentially be used by malware. 

If one were to have a malicious KWin script, one could just enable it by
default and override another KWin script in ~/.local/share when executed and
pretend to be that script. While hiding certain scripts is not ideal from a
security POV, I do not think it is that big of an issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 458572] Add toggle to show all KWin scripts regardless of X-KWin-Exclude-Listing state

2022-08-31 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=458572

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Ever confirmed|0   |1
   Severity|normal  |wishlist
 Status|REPORTED|CONFIRMED

--- Comment #1 from Nate Graham  ---
I'd be in favor of just removing the functionality to hide scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.