[systemsettings] [Bug 459325] Keyboard shortcut change should be effective only after clicking the 'Apply' button

2023-01-12 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=459325

Vlad Zahorodnii  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/commit/76ac4be31632
   ||b436ea78611f07490c352a88b19
   ||2
   Version Fixed In||5.27
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Vlad Zahorodnii  ---
Git commit 76ac4be31632b436ea78611f07490c352a88b192 by Vlad Zahorodnii, on
behalf of Ismael Asensio.
Committed on 12/01/2023 at 12:15.
Pushed by vladz into branch 'master'.

kcms/tabbox: Make shortcuts config save on apply

Currently, tabbox shortcuts are directly saved to KGlobalAccel
when they change, which is inconsistent with the rest of the
KCM and leads to confusion regarding Defaults and isSaveNeeded
status.

Let's instead manage the changes internally and just save them
to KGlobalAccel on Apply/Save.

m_actionsCollection is only used as a helpful way to store this
internal configuration, and doesn't really needs saving to
or restoring from config.
FIXED-IN: 5.27

M  +62   -42   src/kcms/tabbox/kwintabboxconfigform.cpp
M  +5-2src/kcms/tabbox/kwintabboxconfigform.h
M  +6-0src/kcms/tabbox/main.cpp

https://invent.kde.org/plasma/kwin/commit/76ac4be31632b436ea78611f07490c352a88b192

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 459325] Keyboard shortcut change should be effective only after clicking the 'Apply' button

2023-01-10 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=459325

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #2 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/3417

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 459325] Keyboard shortcut change should be effective only after clicking the 'Apply' button

2023-01-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=459325

Nate Graham  changed:

   What|Removed |Added

 CC||sban...@protonmail.com

--- Comment #1 from Nate Graham  ---
*** Bug 463846 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 459325] Keyboard shortcut change should be effective only after clicking the 'Apply' button

2022-09-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=459325

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 CC||n...@kde.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.