[systemsettings] [Bug 471942] If the Touchpad KCM is open via Kickoff or Krunner, the "Apply" button remains greyed out after a change
https://bugs.kde.org/show_bug.cgi?id=471942
Nate Graham changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Latest Commit||https://invent.kde.org/plas
||ma/plasma-desktop/-/commit/
||8671deb12554b659cae119d7d6f
||069682dcd6221
Resolution|--- |FIXED
--- Comment #7 from Nate Graham ---
Git commit 8671deb12554b659cae119d7d6f069682dcd6221 by Nate Graham, on behalf
of Jakob Petsovits.
Committed on 26/07/2023 at 19:10.
Pushed by ngraham into branch 'master'.
kcms/{mouse,touchpad}: Make "Apply" button work all the time
The (more or less identical) instantiations of QQuickWidget in the
libinput backends of Mouse and Touchpad KCMs are connecting the
QML file's changeSignal() to the C++ class's onChange() slot.
However, this does not work when the QQuickWidget hasn't yet
completed loading of the QML file. The signal doesn't yet exist.
As a result, when System Settings is started with kcm_mouse or
kcm_touchpad explicitly (e.g. via KRunner or CLI), onChange() is
never called and the "Apply" button remains greyed out, even if
changes are made in the UI.
The fix is to connect QQuickWidget::rootObject() only once the
QQuickWidget itself has signaled its readiness, via statusChanged().
Connecting statusChanged() is done before setSource() is called,
to eliminate any concerns about when readiness is reached.
(It could be ready immediately if the resource was already loaded!)
M +6-1kcms/mouse/kcm/libinput/libinput_config.cpp
M +6-1kcms/touchpad/kcm/libinput/touchpadconfiglibinput.cpp
https://invent.kde.org/plasma/plasma-desktop/-/commit/8671deb12554b659cae119d7d6f069682dcd6221
--
You are receiving this mail because:
You are watching all bug changes.
[systemsettings] [Bug 471942] If the Touchpad KCM is open via Kickoff or Krunner, the "Apply" button remains greyed out after a change
https://bugs.kde.org/show_bug.cgi?id=471942 --- Comment #6 from Jakob Petsovits --- Found the problem :) See the linked MR for more details! -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 471942] If the Touchpad KCM is open via Kickoff or Krunner, the "Apply" button remains greyed out after a change
https://bugs.kde.org/show_bug.cgi?id=471942 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #5 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1623 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 471942] If the Touchpad KCM is open via Kickoff or Krunner, the "Apply" button remains greyed out after a change
https://bugs.kde.org/show_bug.cgi?id=471942
--- Comment #4 from Jakob Petsovits ---
(In reply to Jakob Petsovits from comment #3)
> Possibly related, the header caption ("Touchpad" in the toolbar area) also
> doesn't show when opened with KRunner. Switching to another KCM and back
> makes everything work.
I found a fix for the header caption, but unfortunately it's not the same root
cause as the "Apply" button failure. Sorry! Will have to keep looking.
--
You are receiving this mail because:
You are watching all bug changes.
[systemsettings] [Bug 471942] If the Touchpad KCM is open via Kickoff or Krunner, the "Apply" button remains greyed out after a change
https://bugs.kde.org/show_bug.cgi?id=471942
Jakob Petsovits changed:
What|Removed |Added
CC||j.acco...@petsovits.com
--- Comment #3 from Jakob Petsovits ---
Possibly related, the header caption ("Touchpad" in the toolbar area) also
doesn't show when opened with KRunner. Switching to another KCM and back makes
everything work.
--
You are receiving this mail because:
You are watching all bug changes.
[systemsettings] [Bug 471942] If the Touchpad KCM is open via Kickoff or Krunner, the "Apply" button remains greyed out after a change
https://bugs.kde.org/show_bug.cgi?id=471942 Nate Graham changed: What|Removed |Added CC||justin.zo...@gmail.com --- Comment #2 from Nate Graham --- *** Bug 472349 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 471942] If the Touchpad KCM is open via Kickoff or Krunner, the "Apply" button remains greyed out after a change
https://bugs.kde.org/show_bug.cgi?id=471942 Nate Graham changed: What|Removed |Added Status|REPORTED|CONFIRMED CC||n...@kde.org Ever confirmed|0 |1 --- Comment #1 from Nate Graham --- Can confirm. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 471942] If the Touchpad KCM is open via Kickoff or Krunner, the "Apply" button remains greyed out after a change
https://bugs.kde.org/show_bug.cgi?id=471942 Patrick Silva changed: What|Removed |Added Keywords||qt6 -- You are receiving this mail because: You are watching all bug changes.
