[systemsettings] [Bug 478091] Does not remove previous KCM header when switching to certain QtWidgets KCMs (KDE Connect KCM, Digital Camera)
https://bugs.kde.org/show_bug.cgi?id=478091 --- Comment #11 from Nicolas Fella --- Git commit c61c6fda7748681068e8f47e1caaedbb73794b1d by Nicolas Fella. Committed on 07/03/2024 at 18:48. Pushed by nicolasfella into branch 'release/24.02'. [kcm] Pass metadata to KCModule constructor (cherry picked from commit 33e37cf929223c328b3dbaa6bbba7a05db3612cc) M +1-1kcontrol/kamera.cpp https://invent.kde.org/graphics/kamera/-/commit/c61c6fda7748681068e8f47e1caaedbb73794b1d -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 478091] Does not remove previous KCM header when switching to certain QtWidgets KCMs (KDE Connect KCM, Digital Camera)
https://bugs.kde.org/show_bug.cgi?id=478091 --- Comment #10 from Nicolas Fella --- Git commit 33e37cf929223c328b3dbaa6bbba7a05db3612cc by Nicolas Fella. Committed on 05/03/2024 at 19:54. Pushed by nicolasfella into branch 'master'. [kcm] Pass metadata to KCModule constructor M +1-1kcontrol/kamera.cpp https://invent.kde.org/graphics/kamera/-/commit/33e37cf929223c328b3dbaa6bbba7a05db3612cc -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 478091] Does not remove previous KCM header when switching to certain QtWidgets KCMs (KDE Connect KCM, Digital Camera)
https://bugs.kde.org/show_bug.cgi?id=478091 --- Comment #9 from Nicolas Fella --- Git commit c5934e3d9b0b7c5b56eb69b28c2ba9e5d0c35c52 by Nicolas Fella. Committed on 07/03/2024 at 14:37. Pushed by nicolasfella into branch 'release/24.02'. [kcm] Use correct KCModule constructor Related: bug 482199 (cherry picked from commit 1785160049b29f3be6c729e344774afab2f26928) M +2-2kcm/kcm.cpp M +1-1kcm/kcm.h https://invent.kde.org/network/kdeconnect-kde/-/commit/c5934e3d9b0b7c5b56eb69b28c2ba9e5d0c35c52 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 478091] Does not remove previous KCM header when switching to certain QtWidgets KCMs (KDE Connect KCM, Digital Camera)
https://bugs.kde.org/show_bug.cgi?id=478091 --- Comment #8 from Albert Vaca Cintora --- Git commit 1785160049b29f3be6c729e344774afab2f26928 by Albert Vaca Cintora, on behalf of Nicolas Fella. Committed on 06/03/2024 at 22:03. Pushed by albertvaka into branch 'master'. [kcm] Use correct KCModule constructor Related: bug 482199 M +2-2kcm/kcm.cpp M +1-1kcm/kcm.h https://invent.kde.org/network/kdeconnect-kde/-/commit/1785160049b29f3be6c729e344774afab2f26928 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 478091] Does not remove previous KCM header when switching to certain QtWidgets KCMs (KDE Connect KCM, Digital Camera)
https://bugs.kde.org/show_bug.cgi?id=478091 --- Comment #7 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/kamera/-/merge_requests/16 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 478091] Does not remove previous KCM header when switching to certain QtWidgets KCMs (KDE Connect KCM, Digital Camera)
https://bugs.kde.org/show_bug.cgi?id=478091 Jakob Petsovits changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/systemsettings/-/commit/ ||b6354ba698dc237a0814bc57f2b ||f286552a23b79 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #6 from Jakob Petsovits --- Git commit b6354ba698dc237a0814bc57f2bf286552a23b79 by Jakob Petsovits. Committed on 20/12/2023 at 01:07. Pushed by jpetso into branch 'master'. Hide the custom page header for KCM plugins without metadata If we have to return early, we shouldn't just leave whatever was shown or hidden for the last KCM page. M +15 -5core/ModuleView.cpp https://invent.kde.org/plasma/systemsettings/-/commit/b6354ba698dc237a0814bc57f2bf286552a23b79 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 478091] Does not remove previous KCM header when switching to certain QtWidgets KCMs (KDE Connect KCM, Digital Camera)
https://bugs.kde.org/show_bug.cgi?id=478091 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #5 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/278 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 478091] Does not remove previous KCM header when switching to certain QtWidgets KCMs (KDE Connect KCM, Digital Camera)
https://bugs.kde.org/show_bug.cgi?id=478091
--- Comment #4 from Jakob Petsovits ---
KCModuleLoader::loadModule() has the correct metadata available when it returns
it to System Settings' ModuleView, but the instantiated KCModule object does
not carry that same metadata.
KdeConnectKcm (which powers kcm_kdeconnect.so) is using the older constructor
signature (QObject *parent, const QVariantList &args) and from what I can tell,
KPluginFactory is forgiving enough to call that instead of requiring the plugin
to support the newer version that also contains the metadata.
The KdeConnectKcm constructor then initializes its parent as simply
KCModule(qobject_cast(parent)). As a subclass of KCModule, it's
allowed to do this, however KCModule also warns:
/**
* Utility constructor for creating a KCModule that is embedded, for
example in a KPluginWidget
* This constructor should not be used for KCMs that are part launched in
systemsettings!
* (...)
*/
explicit KCModule(QObject *parent)
: KCModule(qobject_cast(parent), KPluginMetaData{})
{
}
So it seems the solution is for KdeConnectKcm to use the more modern
constructor signature and hand down the KPluginMetaData object to KCModule, as
it's supposed to do. I'm sure it's the same issue with the Digital Camera KCM.
I don't quite understand the KPluginWidget use case that apparently allows
plugins to use the wrong constructor, but presumably it's required for
something. It would have been nice if the KCM developers had been loudly warned
about using the wrong constructor.
--
You are receiving this mail because:
You are watching all bug changes.
[systemsettings] [Bug 478091] Does not remove previous KCM header when switching to certain QtWidgets KCMs (KDE Connect KCM, Digital Camera)
https://bugs.kde.org/show_bug.cgi?id=478091
--- Comment #3 from Jakob Petsovits ---
Immediate cause: ModuleView::updatePageIconHeader() in
systemsettings/core/ModuleView.cpp is making an early return via this
condition:
KCModule *kcm = d->mPages.value(page);
if (!kcm || !kcm->metaData().isValid()) {
// Seems like we have some form of a race condition going on here...
return;
}
This prevents the header-updating code further down in the same function to
execute.
Root cause: will need some more analysis, I figure.
--
You are receiving this mail because:
You are watching all bug changes.
[systemsettings] [Bug 478091] Does not remove previous KCM header when switching to certain QtWidgets KCMs (KDE Connect KCM, Digital Camera)
https://bugs.kde.org/show_bug.cgi?id=478091 Nate Graham changed: What|Removed |Added Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 478091] Does not remove previous KCM header when switching to certain QtWidgets KCMs (KDE Connect KCM, Digital Camera)
https://bugs.kde.org/show_bug.cgi?id=478091 Nate Graham changed: What|Removed |Added CC||bugsefor...@gmx.com --- Comment #2 from Nate Graham --- *** Bug 477244 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 478091] Does not remove previous KCM header when switching to certain QtWidgets KCMs (KDE Connect KCM, Digital Camera)
https://bugs.kde.org/show_bug.cgi?id=478091 Nate Graham changed: What|Removed |Added CC||n...@kde.org Ever confirmed|0 |1 Summary|Does not remove previous|Does not remove previous |KCM header when switching |KCM header when switching |to KDE Connect KCM |to certain QtWidgets KCMs ||(KDE Connect KCM, Digital ||Camera) Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
