[systemsettings] [Bug 480881] When going back to Devices or Graphics categories already viewed - they become blank.

2024-02-07 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=480881

David Edmundson  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/kinfocenter/-/commit/2de |ma/kinfocenter/-/commit/69d
   |76c72b888ebfd853cd8f96ee2d7 |3e9c9825886a8f5f07169f94d41
   |5730ea45e9  |1e9a46f9b8

--- Comment #5 from David Edmundson  ---
Git commit 69d3e9c9825886a8f5f07169f94d411e9a46f9b8 by David Edmundson.
Committed on 07/02/2024 at 15:57.
Pushed by davidedmundson into branch 'Plasma/6.0'.

Avoid QML singletons to work with shared QML engines

KCM's were registering singleton instances. This has the lifespan of the
QMLEngine, and we were using objects with the lifespan of the loaded
KCM. Recent changes share the QML engine used between modules.

We have an existing mechanism to link the C++ container to the loaded UI
which is used in all other system settings. Port everything to using the
attached kcm object and adding a getter there.
(cherry picked from commit 2de76c72b888ebfd853cd8f96ee2d75730ea45e9)

M  +9-2Modules/cpu/main.cpp
M  +1-2Modules/cpu/ui/main.qml
M  +9-2Modules/egl/main.cpp
M  +1-2Modules/egl/ui/main.qml
M  +9-2Modules/firmware_security/main.cpp
M  +1-2Modules/firmware_security/ui/main.qml
M  +9-2Modules/glx/main.cpp
M  +1-2Modules/glx/ui/main.qml
M  +10   -3Modules/interrupts/main.cpp
M  +1-2Modules/interrupts/ui/main.qml
M  +11   -4Modules/kwinsupportinfo/main.cpp
M  +1-2Modules/kwinsupportinfo/ui/main.qml
M  +9-2Modules/opencl/main.cpp
M  +1-2Modules/opencl/ui/main.qml
M  +10   -2Modules/pci/main.cpp
M  +1-3Modules/pci/ui/main.qml
M  +9-2Modules/vulkan/main.cpp
M  +1-2Modules/vulkan/ui/main.qml
M  +9-2Modules/wayland/main.cpp
M  +1-2Modules/wayland/ui/main.qml
M  +9-2Modules/xserver/main.cpp
M  +1-2Modules/xserver/ui/main.qml

https://invent.kde.org/plasma/kinfocenter/-/commit/69d3e9c9825886a8f5f07169f94d411e9a46f9b8

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 480881] When going back to Devices or Graphics categories already viewed - they become blank.

2024-02-07 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=480881

David Edmundson  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/kinfocenter/-/commit/2de
   ||76c72b888ebfd853cd8f96ee2d7
   ||5730ea45e9
 Resolution|--- |FIXED

--- Comment #4 from David Edmundson  ---
Git commit 2de76c72b888ebfd853cd8f96ee2d75730ea45e9 by David Edmundson.
Committed on 07/02/2024 at 13:07.
Pushed by davidedmundson into branch 'master'.

Avoid QML singletons to work with shared QML engines

KCM's were registering singleton instances. This has the lifespan of the
QMLEngine, and we were using objects with the lifespan of the loaded
KCM. Recent changes share the QML engine used between modules.

We have an existing mechanism to link the C++ container to the loaded UI
which is used in all other system settings. Port everything to using the
attached kcm object and adding a getter there.

M  +9-2Modules/block_devices/main.cpp
M  +1-2Modules/block_devices/ui/main.qml
M  +9-2Modules/cpu/main.cpp
M  +1-2Modules/cpu/ui/main.qml
M  +9-2Modules/egl/main.cpp
M  +1-2Modules/egl/ui/main.qml
M  +9-2Modules/firmware_security/main.cpp
M  +1-2Modules/firmware_security/ui/main.qml
M  +9-2Modules/glx/main.cpp
M  +1-2Modules/glx/ui/main.qml
M  +10   -3Modules/interrupts/main.cpp
M  +1-2Modules/interrupts/ui/main.qml
M  +11   -4Modules/kwinsupportinfo/main.cpp
M  +1-2Modules/kwinsupportinfo/ui/main.qml
M  +9-2Modules/opencl/main.cpp
M  +1-2Modules/opencl/ui/main.qml
M  +10   -2Modules/pci/main.cpp
M  +1-3Modules/pci/ui/main.qml
M  +9-2Modules/vulkan/main.cpp
M  +1-2Modules/vulkan/ui/main.qml
M  +9-2Modules/wayland/main.cpp
M  +1-2Modules/wayland/ui/main.qml
M  +9-2Modules/xserver/main.cpp
M  +1-2Modules/xserver/ui/main.qml

https://invent.kde.org/plasma/kinfocenter/-/commit/2de76c72b888ebfd853cd8f96ee2d75730ea45e9

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 480881] When going back to Devices or Graphics categories already viewed - they become blank.

2024-02-07 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=480881

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #3 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kinfocenter/-/merge_requests/189

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 480881] When going back to Devices or Graphics categories already viewed - they become blank.

2024-02-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=480881

Nate Graham  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 480881] When going back to Devices or Graphics categories already viewed - they become blank.

2024-02-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=480881

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

--- Comment #2 from Nate Graham  ---
Can also reproduce.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 480881] When going back to Devices or Graphics categories already viewed - they become blank.

2024-02-05 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=480881

Harald Sitter  changed:

   What|Removed |Added

  Component|general |general
 CC||k...@davidedmundson.co.uk,
   ||qydwhotm...@gmail.com
Product|kinfocenter |systemsettings

--- Comment #1 from Harald Sitter  ---
https://invent.kde.org/plasma/systemsettings/-/commit/6d4b0f68225f18030bc4050ce1d4331a02e362d8

-- 
You are receiving this mail because:
You are watching all bug changes.