[systemsettings] [Bug 485408] 4ad6a5d8bc0a60c14e7d76d148c1c3db786db706 loses Ctrl+Q quit action and window size/position memory

2024-04-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=485408

--- Comment #6 from Nate Graham  ---
Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 485408] 4ad6a5d8bc0a60c14e7d76d148c1c3db786db706 loses Ctrl+Q quit action and window size/position memory

2024-04-12 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=485408

Nicolas Fella  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 485408] 4ad6a5d8bc0a60c14e7d76d148c1c3db786db706 loses Ctrl+Q quit action and window size/position memory

2024-04-12 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=485408

--- Comment #5 from Nicolas Fella  ---
Git commit 185aa54a73a182cbe4692402c3fbd1dbb97764c0 by Nicolas Fella.
Committed on 12/04/2024 at 10:45.
Pushed by nicolasfella into branch 'master'.

Enable saving window state

KXmlGuiWindow did that automatically, with KMainWindow we need to opt into it

M  +2-0app/SettingsBase.cpp

https://invent.kde.org/plasma/systemsettings/-/commit/185aa54a73a182cbe4692402c3fbd1dbb97764c0

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 485408] 4ad6a5d8bc0a60c14e7d76d148c1c3db786db706 loses Ctrl+Q quit action and window size/position memory

2024-04-12 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=485408

--- Comment #4 from Nicolas Fella  ---
Git commit dc730a7e504b3fdeeaf5261c32934e2bd07b4de2 by Nicolas Fella.
Committed on 12/04/2024 at 10:38.
Pushed by nicolasfella into branch 'master'.

Associate window with actioncollection

This is needed for the action shortcuts to work

This was done implicitly by KXmlGuiWindow before

M  +2-0app/SettingsBase.cpp

https://invent.kde.org/plasma/systemsettings/-/commit/dc730a7e504b3fdeeaf5261c32934e2bd07b4de2

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 485408] 4ad6a5d8bc0a60c14e7d76d148c1c3db786db706 loses Ctrl+Q quit action and window size/position memory

2024-04-12 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=485408

--- Comment #3 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/systemsettings/-/merge_requests/311

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 485408] 4ad6a5d8bc0a60c14e7d76d148c1c3db786db706 loses Ctrl+Q quit action and window size/position memory

2024-04-12 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=485408

--- Comment #2 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/systemsettings/-/merge_requests/310

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 485408] 4ad6a5d8bc0a60c14e7d76d148c1c3db786db706 loses Ctrl+Q quit action and window size/position memory

2024-04-12 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=485408

--- Comment #1 from Nicolas Fella  ---
The quit action is still there:
https://invent.kde.org/plasma/systemsettings/-/blob/master/app/SettingsBase.cpp?ref_type=heads#L124

There is indeed a problem with shortcuts for the actions.

Size/position is done by KMainWindow, which is still used, so it _should_ work

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 485408] 4ad6a5d8bc0a60c14e7d76d148c1c3db786db706 loses Ctrl+Q quit action and window size/position memory

2024-04-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=485408

Nate Graham  changed:

   What|Removed |Added

Version|5.93.0  |master
 CC||nicolas.fe...@gmx.de

-- 
You are receiving this mail because:
You are watching all bug changes.