[umbrello] [Bug 406574] Can't load from *.xmi file (possibly error with temporary file)

2019-07-07 Thread Rex Dieter
https://bugs.kde.org/show_bug.cgi?id=406574

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 406574] Can't load from *.xmi file (possibly error with temporary file)

2019-07-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=406574

federand...@gmail.com changed:

   What|Removed |Added

 CC||kgame...@hotmail.com

--- Comment #12 from federand...@gmail.com ---
*** Bug 408050 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 406574] Can't load from *.xmi file (possibly error with temporary file)

2019-07-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=406574

federand...@gmail.com changed:

   What|Removed |Added

 CC||kitt...@gmail.com

--- Comment #11 from federand...@gmail.com ---
*** Bug 409573 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 406574] Can't load from *.xmi file (possibly error with temporary file)

2019-04-29 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=406574

federand...@gmail.com changed:

   What|Removed |Added

 CC||joseph.a...@outlook.fr

--- Comment #10 from federand...@gmail.com ---
*** Bug 407052 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 406574] Can't load from *.xmi file (possibly error with temporary file)

2019-04-28 Thread Ralf Habacker
https://bugs.kde.org/show_bug.cgi?id=406574

--- Comment #9 from Ralf Habacker  ---
(In reply to tobijk from comment #8)
> This is a minor fix, yet i'm upset you plagiarize my work, using your name
> as author. Especially in an OS community like KDE this should not happen at
> all!
I applied the patch as all other patches before with the phabricator command
line tool 'arc'. You should contact the maintainers of phabricator.kde.org and
report this issue to them.

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 406574] Can't load from *.xmi file (possibly error with temporary file)

2019-04-27 Thread tobijk
https://bugs.kde.org/show_bug.cgi?id=406574

--- Comment #8 from tobijk  ---
Well i'm glad this is upstream now.

This is a minor fix, yet i'm upset you plagiarize my work, using your name as
author. Especially in an OS community like KDE this should not happen at all!

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 406574] Can't load from *.xmi file (possibly error with temporary file)

2019-04-26 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=406574

Christoph Feck  changed:

   What|Removed |Added

   Version Fixed In|2.28.0 (KDE Applications|2.28.1 (KDE Applications
   |19.04.0)|19.04.1)

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 406574] Can't load from *.xmi file (possibly error with temporary file)

2019-04-26 Thread Ralf Habacker
https://bugs.kde.org/show_bug.cgi?id=406574

Ralf Habacker  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/umb
   ||rello/04580cac31b1f1a1491a1
   ||fc54cfc4c724ce50cd9
   Version Fixed In||2.28.0 (KDE Applications
   ||19.04.0)

--- Comment #7 from Ralf Habacker  ---
Git commit 04580cac31b1f1a1491a1fc54cfc4c724ce50cd9 by Ralf Habacker.
Committed on 27/04/2019 at 01:26.
Pushed by habacker into branch 'Applications/19.04'.

file import: do not use overwritten temporary file

We checked if the temporary file we created still exists after its creation,
yet in the meantime we have already copied to it (which overwrites it):
KIO::FileCopyJob *job = KIO::file_copy(url, dest, -1, KIO::Overwrite);

Instead of the temporary file, check if the regular file we use later on
exists.

This bug is a result of fixing bug 125102.
Related: bug 125102
FIXED-IN:2.28.0 (KDE Applications 19.04.0)

Reviewed By: habacker
Differential Revision: https://phabricator.kde.org/D20775

M  +4-4umbrello/umldoc.cpp

https://commits.kde.org/umbrello/04580cac31b1f1a1491a1fc54cfc4c724ce50cd9

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 406574] Can't load from *.xmi file (possibly error with temporary file)

2019-04-26 Thread Ralf Habacker
https://bugs.kde.org/show_bug.cgi?id=406574

Ralf Habacker  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #6 from Ralf Habacker  ---
I can confirm this issue with kf5 version 5.57.

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 406574] Can't load from *.xmi file (possibly error with temporary file)

2019-04-26 Thread tobijk
https://bugs.kde.org/show_bug.cgi?id=406574

--- Comment #5 from tobijk  ---
Thanks! 
Btw: I looked at the root cause of this, but forgot to post: With 5.57 there is
only one changelog entry that jumped into my eyes: "Make file overwrite a bit
safer (bug 125102)". When looking into the commit that fixed bug #125102, it
states:
"Instead of truncating the existing file, a separate copy of the source file in
the
destination folder is created. If the copy was successfully created, the
existing
destination file is replaced with it. ..."

With the replace the root cause is found!

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 406574] Can't load from *.xmi file (possibly error with temporary file)

2019-04-26 Thread Ralf Habacker
https://bugs.kde.org/show_bug.cgi?id=406574

Ralf Habacker  changed:

   What|Removed |Added

 CC||ralf.habac...@freenet.de

--- Comment #4 from Ralf Habacker  ---
I'm currently in the update process to KF5 5.57.0 to be able to reproduce this
issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 406574] Can't load from *.xmi file (possibly error with temporary file)

2019-04-26 Thread tobijk
https://bugs.kde.org/show_bug.cgi?id=406574

--- Comment #3 from tobijk  ---
It seems it does not get attention anyway. So this is a "ping". Maybe somebody
can review this:

https://phabricator.kde.org/D20775

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 406574] Can't load from *.xmi file (possibly error with temporary file)

2019-04-22 Thread Luca Beltrame
https://bugs.kde.org/show_bug.cgi?id=406574

--- Comment #2 from Luca Beltrame  ---
Please submit your patch through Phabricator (https://phabricator.kde.org) or
chances are it will not get the attention it deserves.

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 406574] Can't load from *.xmi file (possibly error with temporary file)

2019-04-22 Thread tobijk
https://bugs.kde.org/show_bug.cgi?id=406574

tobijk  changed:

   What|Removed |Added

 CC||tobias.johannes.klausmann@m
   ||ni.thm.de

--- Comment #1 from tobijk  ---
Created attachment 119574
  --> https://bugs.kde.org/attachment.cgi?id=119574&action=edit
Fix

Hi,
i hit the same bug unexpectedly while opening my files as well. This started to
happen after an update to KDE Frameworks Version 5.57.0.

While checking the code i found it to assume a file still exists after it is
overwritten. Which may have worked but with 5.57.0 Kio file copies seem to
honor the used "KIO::Overwrite" flag. As a conclusion: Just do not use the
overwritten file instance for error checks, instead use the file instance we
created after the copy.

-- 
You are receiving this mail because:
You are watching all bug changes.