[umbrello] [Bug 414759] Sequence diagram - on reload file - app crash when conditions are added

2019-12-03 Thread Mario P.
https://bugs.kde.org/show_bug.cgi?id=414759

--- Comment #8 from Mario P.  ---
great - appreciate your work!
Could get the cloned repo compiled - and now it simply does.
Thanks for the quick solution!

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 414759] Sequence diagram - on reload file - app crash when conditions are added

2019-12-03 Thread Ralf Habacker
https://bugs.kde.org/show_bug.cgi?id=414759

Ralf Habacker  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/kde/
   ||umbrello/commit/ab3dd081385
   ||29eb9fe068463141bf02b1b3d5d
   ||d9
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||2.30.0 (KDE Applications
   ||19.12.0)

--- Comment #7 from Ralf Habacker  ---
Git commit b1e0cea4d27c0cd62e784dc00090e5b028711ff2 by Ralf Habacker.
Committed on 03/12/2019 at 11:03.
Pushed by habacker into branch 'release/19.12'.

Add save/load unit test for class PreConditionWidget

M  +10   -0umbrello/umlwidgets/preconditionwidget.cpp
M  +2-1umbrello/umlwidgets/preconditionwidget.h
M  +7-0unittests/CMakeLists.txt
M  +44   -0unittests/testbase.h
A  +49   -0unittests/testpreconditionwidget.cpp [License: GPL (v2/3)]
A  +33   -0unittests/testpreconditionwidget.h [License: GPL (v2/3)]

https://invent.kde.org/kde/umbrello/commit/b1e0cea4d27c0cd62e784dc00090e5b028711ff2

--- Comment #6 from Ralf Habacker  ---
Git commit ab3dd08138529eb9fe068463141bf02b1b3d5dd9 by Ralf Habacker.
Committed on 03/12/2019 at 10:33.
Pushed by habacker into branch 'release/19.12'.

Fix 'Sequence diagram - on reload file - app crash when conditions are added'

Cleanup activating of widget loaded from xmi file.
FIXED-IN:2.30.0 (KDE Applications 19.12.0)

M  +15   -33   umbrello/umlwidgets/preconditionwidget.cpp
M  +0-1umbrello/umlwidgets/preconditionwidget.h

https://invent.kde.org/kde/umbrello/commit/ab3dd08138529eb9fe068463141bf02b1b3d5dd9

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 414759] Sequence diagram - on reload file - app crash when conditions are added

2019-12-03 Thread Ralf Habacker
https://bugs.kde.org/show_bug.cgi?id=414759

Ralf Habacker  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/kde/
   ||umbrello/commit/ab3dd081385
   ||29eb9fe068463141bf02b1b3d5d
   ||d9
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||2.30.0 (KDE Applications
   ||19.12.0)

--- Comment #6 from Ralf Habacker  ---
Git commit ab3dd08138529eb9fe068463141bf02b1b3d5dd9 by Ralf Habacker.
Committed on 03/12/2019 at 10:33.
Pushed by habacker into branch 'release/19.12'.

Fix 'Sequence diagram - on reload file - app crash when conditions are added'

Cleanup activating of widget loaded from xmi file.
FIXED-IN:2.30.0 (KDE Applications 19.12.0)

M  +15   -33   umbrello/umlwidgets/preconditionwidget.cpp
M  +0-1umbrello/umlwidgets/preconditionwidget.h

https://invent.kde.org/kde/umbrello/commit/ab3dd08138529eb9fe068463141bf02b1b3d5dd9

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 414759] Sequence diagram - on reload file - app crash when conditions are added

2019-12-03 Thread Ralf Habacker
https://bugs.kde.org/show_bug.cgi?id=414759

Ralf Habacker  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #5 from Ralf Habacker  ---
(In reply to Mario P. from comment #3)
> Created attachment 124288 [details]
> extented testcase for reproducing behaviour
> 
> took a while in editing until the fault occurred again

Thanks for providing this information, which helped to develop a quick fix. You
may clone the umbrello git repo to build a binary including the fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 414759] Sequence diagram - on reload file - app crash when conditions are added

2019-12-03 Thread Ralf Habacker
https://bugs.kde.org/show_bug.cgi?id=414759

--- Comment #4 from Ralf Habacker  ---
Git commit 80a545dc20473065998746d64e07e79b3c45346e by Ralf Habacker.
Committed on 03/12/2019 at 10:10.
Pushed by habacker into branch 'release/19.12'.

Apply quick fix to prevent crashing on loading extented testcase for
reproducing behaviour

Make sure that access to the object widget instance is always protected.
The reason why the linked object widget could not be found when loading
is unknown so far.

M  +22   -21   umbrello/umlwidgets/preconditionwidget.cpp

https://invent.kde.org/kde/umbrello/commit/80a545dc20473065998746d64e07e79b3c45346e

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 414759] Sequence diagram - on reload file - app crash when conditions are added

2019-12-02 Thread Mario P.
https://bugs.kde.org/show_bug.cgi?id=414759

--- Comment #3 from Mario P.  ---
Created attachment 124288
  --> https://bugs.kde.org/attachment.cgi?id=124288=edit
extented testcase for reproducing behaviour

took a while in editing until the fault occurred again

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 414759] Sequence diagram - on reload file - app crash when conditions are added

2019-12-02 Thread Ralf Habacker
https://bugs.kde.org/show_bug.cgi?id=414759

Ralf Habacker  changed:

   What|Removed |Added

 CC||ralf.habac...@freenet.de

--- Comment #2 from Ralf Habacker  ---
Created attachment 124283
  --> https://bugs.kde.org/attachment.cgi?id=124283=edit
test case

Thanks for your bug report. With the attached test case I cannot reproduce this
error, which leads me to assume that this error depends on the diagram content
in the corresponding xmi file. 
It would be helpful to extend the test case to reproduce the error or get the
original file that caused the crash.

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 414759] Sequence diagram - on reload file - app crash when conditions are added

2019-12-02 Thread Mario P.
https://bugs.kde.org/show_bug.cgi?id=414759

--- Comment #1 from Mario P.  ---
Created attachment 124275
  --> https://bugs.kde.org/attachment.cgi?id=124275=edit
detailed debug screenshot

-- 
You are receiving this mail because:
You are watching all bug changes.