[umbrello] [Bug 442134] "const" correctness in Umbrello sources
https://bugs.kde.org/show_bug.cgi?id=442134
--- Comment #9 from Oliver Kellogg ---
Git commit 33d00b623636603280059f6ba429fae688c6d3cb by Oliver Kellogg.
Committed on 04/12/2021 at 18:09.
Pushed by okellogg into branch 'master'.
Followup to commit 54a3659 - start using the const overloads of the
UMLObject::asUMLActor() to asUMLUseCase() functions.
Accessory changes:
umbrello/codegenerators/ada/adawriter.{h,cpp}
umbrello/codegenerators/pascal/pascalwriter.{h,cpp}
- At function isOOClass() declare UMLClassifier* argument `const'.
umbrello/uml1model/instanceattribute.{h,cpp}
- At function toString() add `const' qualifier.
umbrello/umlwidgets/entitywidget.cpp
- In functions calculateSize() and paint() rename local variable
`casted' to `umlEA' (short for UMLEntityAttribute).
M +2-2umbrello/codegenerators/ada/adawriter.cpp
M +1-1umbrello/codegenerators/ada/adawriter.h
M +9-9umbrello/codegenerators/codeclassfield.cpp
M +2-2umbrello/codegenerators/codeclassfielddeclarationblock.cpp
M +3-3umbrello/codegenerators/codeparameter.cpp
M +2-2umbrello/codegenerators/cpp/cppcodeclassfield.cpp
M +2-2umbrello/codegenerators/cpp/cppheadercodedocument.cpp
M +1-1umbrello/codegenerators/cpp/cppwriter.cpp
M +2-2umbrello/codegenerators/d/dcodeclassfield.cpp
M +2-2umbrello/codegenerators/d/dcodeclassfielddeclarationblock.cpp
M +1-1umbrello/codegenerators/java/javaantcodedocument.cpp
M +2-2umbrello/codegenerators/java/javacodeclassfield.cpp
M +2-2
umbrello/codegenerators/java/javacodeclassfielddeclarationblock.cpp
M +3-3umbrello/codegenerators/ownedcodeblock.cpp
M +2-2umbrello/codegenerators/ownedhierarchicalcodeblock.cpp
M +4-4umbrello/codegenerators/pascal/pascalwriter.cpp
M +1-1umbrello/codegenerators/pascal/pascalwriter.h
M +2-2umbrello/codegenerators/ruby/rubycodeclassfield.cpp
M +2-2
umbrello/codegenerators/ruby/rubycodeclassfielddeclarationblock.cpp
M +4-4umbrello/codegenerators/sql/sqlwriter.cpp
M +1-1umbrello/codeimport/sqlimport.cpp
M +4-4umbrello/dialogs/codeeditor.cpp
M +2-2umbrello/dialogs/pages/classgeneralpage.cpp
M +4-4umbrello/dialogs/pages/classifierlistpage.cpp
M +2-2umbrello/dialogs/umlattributedialog.cpp
M +2-2umbrello/dialogs/umlentityattributedialog.cpp
M +2-2umbrello/dialogs/umlenumliteraldialog.cpp
M +3-3umbrello/dialogs/umlforeignkeyconstraintdialog.cpp
M +2-2umbrello/dialogs/umltemplatedialog.cpp
M +2-2umbrello/dialogs/umluniqueconstraintdialog.cpp
M +2-2umbrello/dialogs/widgets/defaultvaluewidget.cpp
M +2-2umbrello/dialogs/widgets/documentationwidget.cpp
M +3-3umbrello/dialogs/widgets/umldatatypewidget.cpp
M +1-1umbrello/docwindow.cpp
M +1-1umbrello/menus/umllistviewpopupmenu.cpp
M +4-4umbrello/model_utils.cpp
M +4-4umbrello/models/objectsmodel.cpp
M +2-2umbrello/uml1model/attribute.cpp
M +1-1umbrello/uml1model/foreignkeyconstraint.cpp
M +1-1umbrello/uml1model/instanceattribute.cpp
M +1-1umbrello/uml1model/instanceattribute.h
M +3-3umbrello/uml1model/operation.cpp
M +4-4umbrello/uml1model/uniqueconstraint.cpp
M +5-5umbrello/umllistview.cpp
M +5-5umbrello/umllistviewitem.cpp
M +10 -10 umbrello/umlscene.cpp
M +3-3umbrello/umlwidgets/artifactwidget.cpp
M +5-5umbrello/umlwidgets/associationwidget.cpp
M +5-5umbrello/umlwidgets/componentwidget.cpp
M +12 -12 umbrello/umlwidgets/entitywidget.cpp
M +3-3umbrello/umlwidgets/enumwidget.cpp
M +1-1umbrello/umlwidgets/messagewidget.cpp
M +1-1unittests/testumlobject.cpp
https://invent.kde.org/sdk/umbrello/commit/33d00b623636603280059f6ba429fae688c6d3cb
--
You are receiving this mail because:
You are watching all bug changes.
[umbrello] [Bug 442134] "const" correctness in Umbrello sources
https://bugs.kde.org/show_bug.cgi?id=442134
--- Comment #8 from Oliver Kellogg ---
Git commit 54a365905a971803a7791bedaca7f87d11d4e58f by Oliver Kellogg.
Committed on 21/11/2021 at 14:51.
Pushed by okellogg into branch 'master'.
Address comment #7 by Robert Hairgrove : In uml1model/umlobject.{h,cpp} add
const overloads to the asUMLActor() to asUMLUseCase() functions.
M +31 -1umbrello/uml1model/umlobject.cpp
M +32 -0umbrello/uml1model/umlobject.h
https://invent.kde.org/sdk/umbrello/commit/54a365905a971803a7791bedaca7f87d11d4e58f
--
You are receiving this mail because:
You are watching all bug changes.
[umbrello] [Bug 442134] "const" correctness in Umbrello sources
https://bugs.kde.org/show_bug.cgi?id=442134
--- Comment #7 from Robert Hairgrove ---
(In reply to Oliver Kellogg from comment #6)
> Git commit 7a8d1cfb0b562fab051c7ec3b46e6eededee5195 by Oliver Kellogg.
> Committed on 11/09/2021 at 08:57.
> Pushed by okellogg into branch 'master'.
>
> Address remaining trivial const correctness fixes from attachment 141364
> [details].
> Suggestions that require code change beyond function signature are postponed
> to a further batch.
>
> M +3-3umbrello/dialogs/multipagedialogbase.cpp
(...big snip...)
If you could now add const overloads to the following functions starting at
line 225 in "umlobject.h", this would undoubtibly help further progress in
making other things const correct, i.e.:
UMLActor * asUMLActor();
UMLArtifact * asUMLArtifact();
UMLAssociation * asUMLAssociation();
UMLAttribute * asUMLAttribute();
(etc. ... then add these declarations after the group:)
const UMLActor * asUMLActor() const;
const UMLArtifact * asUMLArtifact() const;
const UMLAssociation * asUMLAssociation() const;
const UMLAttribute * asUMLAttribute() const;
and in umlobject.cpp starting at line 1382:
UMLActor* UMLObject::asUMLActor(){ return
dynamic_cast(this); }
UMLArtifact * UMLObject::asUMLArtifact() { return
dynamic_cast(this); }
UMLAssociation * UMLObject::asUMLAssociation() { return
dynamic_cast(this); }
(...)
adding the corresponding methods after this group, i.e.:
const UMLActor* UMLObject::asUMLActor() const {
return dynamic_cast(this); }
const UMLArtifact * UMLObject::asUMLArtifact() const{
return dynamic_cast(this); }
const UMLAssociation * UMLObject::asUMLAssociation() const {
return dynamic_cast(this); }
I don't think this would break any existing code?
--
You are receiving this mail because:
You are watching all bug changes.
[umbrello] [Bug 442134] "const" correctness in Umbrello sources
https://bugs.kde.org/show_bug.cgi?id=442134 --- Comment #6 from Oliver Kellogg --- Git commit 7a8d1cfb0b562fab051c7ec3b46e6eededee5195 by Oliver Kellogg. Committed on 11/09/2021 at 08:57. Pushed by okellogg into branch 'master'. Address remaining trivial const correctness fixes from attachment 141364. Suggestions that require code change beyond function signature are postponed to a further batch. M +3-3umbrello/dialogs/multipagedialogbase.cpp M +3-3umbrello/dialogs/multipagedialogbase.h M +5-5umbrello/dotgenerator.cpp M +5-5umbrello/dotgenerator.h M +2-2umbrello/layoutgenerator.cpp M +2-2umbrello/layoutgenerator.h M +2-2umbrello/toolbarstateother.cpp M +2-2umbrello/toolbarstateother.h M +10 -10 umbrello/uml.cpp M +11 -11 umbrello/uml.h M +2-1umbrello/uml1model/classifier.cpp M +2-1umbrello/uml1model/classifier.h M +5-5umbrello/uml1model/umlcanvasobject.cpp M +5-6umbrello/uml1model/umlcanvasobject.h M +32 -32 umbrello/uml1model/umlobject.cpp M +33 -33 umbrello/uml1model/umlobject.h M +25 -25 umbrello/umldoc.cpp M +25 -25 umbrello/umldoc.h M +9-8umbrello/umllistview.cpp M +6-6umbrello/umllistview.h M +1-1umbrello/umllistviewitem.cpp M +2-2umbrello/umllistviewitem.h https://invent.kde.org/sdk/umbrello/commit/7a8d1cfb0b562fab051c7ec3b46e6eededee5195 -- You are receiving this mail because: You are watching all bug changes.
[umbrello] [Bug 442134] "const" correctness in Umbrello sources
https://bugs.kde.org/show_bug.cgi?id=442134 Oliver Kellogg changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED Latest Commit|https://invent.kde.org/sdk/ | |umbrello/commit/0372f89d799 | |5a5fbc557e6c6090208bc54950e | |88 | --- Comment #5 from Oliver Kellogg --- Ouch. I put the wrong bug number in commit 0372f89, sorry. -- You are receiving this mail because: You are watching all bug changes.
[umbrello] [Bug 442134] "const" correctness in Umbrello sources
https://bugs.kde.org/show_bug.cgi?id=442134
Oliver Kellogg changed:
What|Removed |Added
Resolution|--- |FIXED
Latest Commit||https://invent.kde.org/sdk/
||umbrello/commit/0372f89d799
||5a5fbc557e6c6090208bc54950e
||88
Status|ASSIGNED|RESOLVED
--- Comment #4 from Oliver Kellogg ---
Git commit 0372f89d7995a5fbc557e6c6090208bc54950e88 by Oliver Kellogg.
Committed on 10/09/2021 at 05:51.
Pushed by okellogg into branch 'master'.
Fix for "C++ importer does not recognize 'noexcept' keyword" :
lib/cppparser/keywords.h
- Align INSERT calls as table. Add INSERT("noexcept", Token_noexcept).
lib/cppparser/lexer.h
- In enum Type add Token_noexcept.
lib/cppparser/parser.cpp
- In functions skipUntilDeclaration, skipUntilStatement while-loop
switch add case Token_noexcept.
- In function parseExceptionSpecification handle the case
(m_lexer->lookAhead(0) == Token_noexcept).
test/import/cxx/const-methods.h
- Rename file to const-noexcept-methods.h.
test/import/cxx/const-noexcept-methods.h
- Rename class to ConstNoexceptMethodClass.
- Add NoexceptMethod with trailing noexcept.
- Add ConstNoexceptMethod with const noexcept and implementation.
Related: bug 338649
M +84 -83 lib/cppparser/keywords.h
M +1-0lib/cppparser/lexer.h
M +15 -2lib/cppparser/parser.cpp
D +0-3test/import/cxx/const-methods.h
A +5-0test/import/cxx/const-noexcept-methods.h *
The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.
https://invent.kde.org/sdk/umbrello/commit/0372f89d7995a5fbc557e6c6090208bc54950e88
--
You are receiving this mail because:
You are watching all bug changes.
[umbrello] [Bug 442134] "const" correctness in Umbrello sources
https://bugs.kde.org/show_bug.cgi?id=442134
--- Comment #3 from Robert Hairgrove ---
(In reply to Oliver Kellogg from comment #1)
> Thanks for making the attachment, it is helpful.
>
> Minor point:
> > File: codedocument.h
> > virtual QString getUniqueTag(const QString& prefix = QString()); // const
>
> This one can't be made const due to a side effect this the function body,
>
> QString CodeDocument::getUniqueTag (const QString& prefix) const
> {
> [...]
> m_lastTagIndex = number;
>
> The compiler reports
> "assignment of member ‘CodeDocument::m_lastTagIndex’ in read-only object".
Thank you, Oliver!
As I replied in the umbrello-devel user group (but under another email address,
sorry about that), one could declare "CodeDocument::m_lastTagIndex"
mutable...this would be the easiest way to fix the compilation error.
However, from looking at the implementation code, it appears that this member
merely implements some kind of sequence number used to generate the new tag.
Shouldn't this rather be made a static member, or have a static
"generateSequence()" function? Unless there is only one singleton instance of
CodeDocument objects, the danger of having duplicate values seems very real
here, because each derived instance will have its own copy of the member.
Also, the function is declared virtual ... what if a derived class overrides it
and thus cannot update the private member of the base class?
I suppose this could be avoided if each class were required to have its own
unique prefix which is prepended to the number, but I'm not sure where this is
enforced.
--
You are receiving this mail because:
You are watching all bug changes.
[umbrello] [Bug 442134] "const" correctness in Umbrello sources
https://bugs.kde.org/show_bug.cgi?id=442134 --- Comment #2 from Oliver Kellogg --- Git commit 0457a2ebba571932d609e6ac14d145ce573f585c by Oliver Kellogg. Committed on 08/09/2021 at 21:01. Pushed by okellogg into branch 'master'. Const correctness fixes addressing roughly the first half of attachment 141364. Changes that did not succeed offhand are postponed to a second batch. M +2-2umbrello/codegenerators/ada/adawriter.cpp M +2-2umbrello/codegenerators/ada/adawriter.h M +26 -20 umbrello/codegenerators/classifiercodedocument.cpp M +16 -13 umbrello/codegenerators/classifiercodedocument.h M +7-7umbrello/codegenerators/codedocument.cpp M +6-6umbrello/codegenerators/codedocument.h M +2-2umbrello/codegenerators/codegenerator.cpp M +2-2umbrello/codegenerators/codegenerator.h M +2-2umbrello/codegenerators/codeparameter.cpp M +2-2umbrello/codegenerators/codeparameter.h M +2-2umbrello/codegenerators/cpp/cppcodegenerator.cpp M +2-2umbrello/codegenerators/cpp/cppcodegenerator.h M +3-3umbrello/codegenerators/cpp/cppmakecodedocument.cpp M +3-3umbrello/codegenerators/cpp/cppmakecodedocument.h M +2-2umbrello/codegenerators/cpp/cppwriter.cpp M +2-2umbrello/codegenerators/cpp/cppwriter.h M +2-2umbrello/codegenerators/csharp/csharpwriter.cpp M +2-2umbrello/codegenerators/csharp/csharpwriter.h M +3-3umbrello/codegenerators/d/dclassifiercodedocument.cpp M +3-3umbrello/codegenerators/d/dclassifiercodedocument.h M +2-2umbrello/codegenerators/d/dcodegenerator.cpp M +2-2umbrello/codegenerators/d/dcodegenerator.h M +2-2umbrello/codegenerators/d/dwriter.cpp M +2-2umbrello/codegenerators/d/dwriter.h M +2-2umbrello/codegenerators/idl/idlwriter.cpp M +3-3umbrello/codegenerators/idl/idlwriter.h M +2-2umbrello/codegenerators/java/javaantcodedocument.cpp M +2-2umbrello/codegenerators/java/javaantcodedocument.h M +4-4umbrello/codegenerators/java/javaclassifiercodedocument.cpp M +4-4umbrello/codegenerators/java/javaclassifiercodedocument.h M +2-2umbrello/codegenerators/java/javacodegenerator.cpp M +2-2umbrello/codegenerators/java/javacodegenerator.h M +2-2umbrello/codegenerators/java/javawriter.cpp M +2-2umbrello/codegenerators/java/javawriter.h M +2-2umbrello/codegenerators/pascal/pascalwriter.cpp M +2-2umbrello/codegenerators/pascal/pascalwriter.h M +2-2umbrello/codegenerators/perl/perlwriter.cpp M +2-2umbrello/codegenerators/perl/perlwriter.h M +2-2umbrello/codegenerators/python/pythonwriter.cpp M +2-2umbrello/codegenerators/python/pythonwriter.h M +4-4umbrello/codegenerators/ruby/rubyclassifiercodedocument.cpp M +4-4umbrello/codegenerators/ruby/rubyclassifiercodedocument.h M +2-2umbrello/codegenerators/sql/mysqlwriter.cpp M +2-2umbrello/codegenerators/sql/mysqlwriter.h M +2-2umbrello/codegenerators/sql/postgresqlwriter.cpp M +2-2umbrello/codegenerators/sql/postgresqlwriter.h M +2-2umbrello/codegenerators/sql/sqlwriter.cpp M +2-2umbrello/codegenerators/sql/sqlwriter.h M +2-2umbrello/codegenerators/vala/valawriter.cpp M +2-2umbrello/codegenerators/vala/valawriter.h M +2-2umbrello/codeimport/classimport.h M +1-1umbrello/debug/debug_utils.cpp M +1-1umbrello/debug/debug_utils.h M +2-2umbrello/dialogs/activitydialog.h M +2-2umbrello/dialogs/codeeditor.h M +4-4umbrello/dialogs/finddialog.cpp M +4-4umbrello/dialogs/finddialog.h M +2-2umbrello/dialogs/objectnodedialog.h M +5-3umbrello/dialogs/pages/codegenerationpolicypage.cpp M +2-2umbrello/dialogs/settingsdialog.h M +2-2umbrello/dialogs/statedialog.h M +3-3umbrello/docwindow.cpp M +3-3umbrello/docwindow.h M +2-2umbrello/petalnode.h M +2-2umbrello/uml1model/artifact.cpp M +2-2umbrello/uml1model/artifact.h M +1-1umbrello/uml1model/attribute.cpp M +3-2umbrello/uml1model/attribute.h M +3-2umbrello/uml1model/checkconstraint.cpp M +3-2umbrello/uml1model/checkconstraint.h M +20 -20 umbrello/uml1model/classifier.cpp M +20 -20 umbrello/uml1model/classifier.h M +3-2umbrello/uml1model/classifierlistitem.cpp M +3-2umbrello/uml1model/classifierlistitem.h M +2-2umbrello/uml1model/component.cpp M +2-2umbrello/uml1model/component.h M +3-3umbrello/uml1model/entity.cpp M +3-3umbrello/uml1model/entity.h M +3-2umbrello/uml1model/entityattribute.cpp M +3-2umbrello/uml1model/entityattribute.h M +2-2umbrello/uml1model/enum.cpp M +2-2umbrello/uml1model/enum.h M +3-2
[umbrello] [Bug 442134] "const" correctness in Umbrello sources
https://bugs.kde.org/show_bug.cgi?id=442134
--- Comment #1 from Oliver Kellogg ---
Thanks for making the attachment, it is helpful.
Minor point:
> File: codedocument.h
> virtual QString getUniqueTag(const QString& prefix = QString()); // const
This one can't be made const due to a side effect this the function body,
QString CodeDocument::getUniqueTag (const QString& prefix) const
{
[...]
m_lastTagIndex = number;
The compiler reports
"assignment of member ‘CodeDocument::m_lastTagIndex’ in read-only object".
--
You are receiving this mail because:
You are watching all bug changes.
[umbrello] [Bug 442134] "const" correctness in Umbrello sources
https://bugs.kde.org/show_bug.cgi?id=442134 Oliver Kellogg changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 CC||okellogg@users.sourceforge. ||net -- You are receiving this mail because: You are watching all bug changes.
