[valgrind] [Bug 358697] valgrind.h: Some code remains even when defining NVALGRIND

2017-03-30 Thread Julian Seward
https://bugs.kde.org/show_bug.cgi?id=358697

Julian Seward  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #6 from Julian Seward  ---
Committed, r16290.  Thanks for the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.


[valgrind] [Bug 358697] valgrind.h: Some code remains even when defining NVALGRIND

2017-03-30 Thread Matthias Schwarzott
https://bugs.kde.org/show_bug.cgi?id=358697

--- Comment #5 from Matthias Schwarzott  ---
Patch valgrind-3.12.0-valgrind_printf-simple-nvalgrind-fix-plus-testcase.patch
has been tested with MSVC 2008 configured to warning level 4.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 358697] valgrind.h: Some code remains even when defining NVALGRIND

2017-03-30 Thread Matthias Schwarzott
https://bugs.kde.org/show_bug.cgi?id=358697

--- Comment #4 from Matthias Schwarzott  ---
Created attachment 104809
  --> https://bugs.kde.org/attachment.cgi?id=104809&action=edit
valgrind-3.12.0-valgrind_printf-simple-nvalgrind-fix-plus-testcase.patch

This new patch fixes the problem in the simplest way: "(void)format;"
Additionally it adds a testcase to compile and run the existing vgprintf.c with
NVALGRIND

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 358697] valgrind.h: Some code remains even when defining NVALGRIND

2016-01-29 Thread Matthias Schwarzott via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358697

--- Comment #3 from Matthias Schwarzott  ---
e.g. QT has a macro like this:

#define Q_UNUSED(x) (void)x;

To be used inside functions:
Q_UNUSED(format)

-- 
You are receiving this mail because:
You are watching all bug changes.


[valgrind] [Bug 358697] valgrind.h: Some code remains even when defining NVALGRIND

2016-01-28 Thread Matthias Schwarzott via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358697

--- Comment #2 from Matthias Schwarzott  ---
The simplest solution could be to use "(void)format" and protect this with an
ifdef checking that we are not running under the problematic static code
checker.

-- 
You are receiving this mail because:
You are watching all bug changes.


[valgrind] [Bug 358697] valgrind.h: Some code remains even when defining NVALGRIND

2016-01-28 Thread Matthias Schwarzott via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358697

--- Comment #1 from Matthias Schwarzott  ---
Created attachment 96891
  --> https://bugs.kde.org/attachment.cgi?id=96891&action=edit
valgrind-improve-unused-parameter-on-r15763.patch

This patch implements the __attribute__ usage.
But I am not sure about the ifdef code. It is just what was originally around
the __attribute__ usage.

-- 
You are receiving this mail because:
You are watching all bug changes.